IETF Logo Mail Archive

Re: [yang-doctors] Dealing with BFD RFC 9127 client-cfg-parms for PIM, OSPF, ISIS and other BFD clients on some platforms

Mahesh Jethanandani <mjethanandani@gmail.com> Mon, 08 November 2021 20:01 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 833A93A11D4; Mon, 8 Nov 2021 12:01:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.087
X-Spam-Level:
X-Spam-Status: No, score=-2.087 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YJxF1Rt_F8NL; Mon, 8 Nov 2021 12:01:50 -0800 (PST)
Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9C8D83A12AB; Mon, 8 Nov 2021 12:01:16 -0800 (PST)
Received: by mail-pf1-x42d.google.com with SMTP id x64so17100521pfd.6; Mon, 08 Nov 2021 12:01:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=I7Y4fHRgJLdQUJ4+wLJLyAR1Hhb+qxTZJahphesHGME=; b=HxRvBuyX8nzQUyAFhOO57yMye4g8yIBoglnSFK9hqFPu3leWlmq8ZmEtsdMJqJKkwp qT5JjGCK7SOfrHMNYgGeRKdt9/SOh6OscPaF0yMgfvQSk14oxHQvPljP+r/FGz9WZAFj 3jJbM1vC5Potr16ATXahbPvADo5rLXConiF8UQSW5gNSKu5PS6FinwVr4OF6VQnmsWV6 +QUKzggUb/E7K4Q35cRzelJPWeTdeqxBvx/Lfk2GcDC5r7O9GNOqpdoBUVOoSN59jiU9 HjArdc+ZqF9Ek9+e+LvzBD7BH7G4Ycpn/A910++0Wi3+EuTm0N9nyfrdwGYVt1yti1dk UOyg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=I7Y4fHRgJLdQUJ4+wLJLyAR1Hhb+qxTZJahphesHGME=; b=K32/F5rkftRVCqhwUVFdcWA5UX4gId4KoLq7lNg4IN5mM6GTd6Ab6nVWAr09HC85E9 4Cm3sU2dq11YsVj9LQoOIWlVX0QwRJk8J4NKAteCqBjFFNJ31WvhzR/YSaaUQLJ7AiIw koEce+6TiXgPHFg8qStDmbArgO2oDszh+0f1wusK6e1nd9VO+DVRv26taIpiFKYOLfAO r73XGJ65945Orad3VSwXDQs/Ma/PyZ7/XXvXJDWz8QkNB7mZLl26gfTFgOGko0xx2m8p C3eCIvLOAW7PHGsJD4s8TdpT8i24+mdJAorywgyiczhAVogESyrkp8Lq7liIG4vYAVty TCgQ==
X-Gm-Message-State: AOAM531lWt6jDyXK1dmZPYxCpOb7xMN6xyrv2BQuskLizwxjASY8vOwL Y3Mdlt2wVfcPNLrrtdsBUrinr3qDxB4=
X-Google-Smtp-Source: ABdhPJyvyqYAdGrQxXBK+dJp+t+txq94nCpUc8UQlcPAxZPgVtW6WfB7Lu6j6LUIbZ42XRyty9fN/Q==
X-Received: by 2002:a05:6a00:1584:b0:49f:e5dd:f904 with SMTP id u4-20020a056a00158400b0049fe5ddf904mr1815075pfk.55.1636401675004; Mon, 08 Nov 2021 12:01:15 -0800 (PST)
Received: from [192.168.1.133] (c-69-181-169-15.hsd1.ca.comcast.net. [69.181.169.15]) by smtp.gmail.com with ESMTPSA id u32sm5761438pfg.220.2021.11.08.12.01.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Nov 2021 12:01:14 -0800 (PST)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <648DD172-F0F2-424F-B601-4D4AF1E3F7E5@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_A7C4DE49-CCF4-4C44-BA5F-69D9E0E3F848"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Date: Mon, 8 Nov 2021 12:01:13 -0800
In-Reply-To: <478689A9-35DA-43D5-A4B3-28C702571D44@pfrc.org>
Cc: "Acee Lindem (acee)" <acee@cisco.com>, Reshad Rehman <reshad@yahoo.com>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "Rob Wilton (rwilton)" <rwilton=40cisco.com@dmarc.ietf.org>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
To: Jeffrey Haas <jhaas@pfrc.org>
References: <316113928.668710.1636140378658@mail.yahoo.com> <E5128CE2-3EF9-4723-85C6-D5BE3E1E826A@gmail.com> <D018DDBB-08B3-4671-8EBF-5DAAC4D7528E@cisco.com> <BD68BAE3-7CA0-466B-A16A-E94FBAFD0710@gmail.com> <761418F7-F382-45EE-BD96-27317587C8EA@cisco.com> <7C1C266F-DD19-4274-8967-9A54B68C5F62@pfrc.org> <0B440C73-DEAD-475D-9111-8B76841F0B24@gmail.com> <478689A9-35DA-43D5-A4B3-28C702571D44@pfrc.org>
X-Mailer: Apple Mail (2.3608.120.23.2.7)
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/ZBqUkhhSDnIxLu66KaYnFfIvXbM>
Subject: Re: [yang-doctors] Dealing with BFD RFC 9127 client-cfg-parms for PIM, OSPF, ISIS and other BFD clients on some platforms
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Nov 2021 20:02:03 -0000

Hi Jeff,

And here is the full set of diffs that I had in mind.



> On Nov 8, 2021, at 11:12 AM, Jeffrey Haas <jhaas@pfrc.org> wrote:
> 
> Mahesh,
> 
>> On Nov 8, 2021, at 1:49 PM, Mahesh Jethanandani <mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>> wrote:
>> 
>> Hi Jeff,
>> 
>>> On Nov 8, 2021, at 10:19 AM, Jeffrey Haas <jhaas@pfrc.org <mailto:jhaas@pfrc.org>> wrote:
>>> 
>>> 
>>> 
>>>> On Nov 7, 2021, at 1:56 PM, Acee Lindem (acee) <acee@cisco.com <mailto:acee@cisco.com>> wrote:
>>>> 
>>>> 
>>>> From: Mahesh Jethanandani <mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>>
>>>> 
>>>>> With Jeff’s diff, you’d still need two features. The base BFD feature which is in the protocol model and the bfd:client-cfg-parameters in the diff.
>>>>  
>>>> [mj] Acee, I was merely trying to point out to Reshad that we may not need a separate grouping with just the ‘enabled’ flag called ‘client-cfg-no-parms” or ‘client-cfg-enabled’ as the ‘enabled’ flag is needed by both modes of operation. I am fine with Jeff’s diffs.
>>>>  
>>>> But since you bring it up, how about moving the base BFD feature definition from the protocol drafts into the BFD types definition file, so there is one single way to enable the feature, rather than each protocol defining their own feature definition?
>>>>  
>>>> Sure.
>>> 
>>> The original diff I had sent out vs. the RFC was lost when the yang doctors were added.
>>> 
>>> Here's the diff again.  I think aside from adding appendix test and a little bit of word smithing, it's about all we need:
>>> 
>>> <rfc9127-bis-from-.diff.html>
>> 
>> All three protocol drafts (BGP, ISIS and OSPF, I did not check PIM) define their own feature statements for the base and for the client-cfg-parms in their own models. All I am suggesting is those feature definitions be moved into ietf-bfd-types YANG module as part of this update. But if the desire is to keep the change to the min, I am ok with it too.
> 
> My diff had it in that module.
> 
> Here's the full .xml for you to peruse.
> 
> 
> 
> -- Jeff
> <rfc9127.xml>

Mahesh Jethanandani
mjethanandani@gmail.com

v2.8.7 | Report a Bug | By Email