Re: [yang-doctors] Dealing with BFD RFC 9127 client-cfg-parms for PIM, OSPF, ISIS and other BFD clients on some platforms

Jeffrey Haas <jhaas@pfrc.org> Tue, 23 November 2021 16:59 UTC

Return-Path: <jhaas@pfrc.org>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 581E03A05AA; Tue, 23 Nov 2021 08:59:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5JHKbbLZOoEz; Tue, 23 Nov 2021 08:59:31 -0800 (PST)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id 930A63A05A0; Tue, 23 Nov 2021 08:59:31 -0800 (PST)
Received: from smtpclient.apple (99-59-193-67.lightspeed.livnmi.sbcglobal.net [99.59.193.67]) by slice.pfrc.org (Postfix) with ESMTPSA id 60D251E2F3; Tue, 23 Nov 2021 11:59:30 -0500 (EST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
From: Jeffrey Haas <jhaas@pfrc.org>
In-Reply-To: <7B218D32-A783-42E2-8C05-6C2A8FCC2E34@juniper.net>
Date: Tue, 23 Nov 2021 11:59:29 -0500
Cc: "Rob Wilton (rwilton)" <rwilton@cisco.com>, Mahesh Jethanandani <mjethanandani@gmail.com>, =?utf-8?Q?Martin_Bj=C3=B6rklund?= <mbj+ietf@4668.se>, "ladislav.lhotka@nic.cz" <ladislav.lhotka@nic.cz>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, Reshad Rahman <reshad@yahoo.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <850727E4-0575-4A76-8A28-7BDC4CAE6119@pfrc.org>
References: <BY5PR11MB4196C864C6D23A4A2651342AB5939@BY5PR11MB4196.namprd11.prod.outlook.com> <0A207FB0-C39F-4198-8565-0BA6542F6E59@pfrc.org> <BY5PR11MB4196467831FC39D5971C6B95B59C9@BY5PR11MB4196.namprd11.prod.outlook.com> <41D23C55-AFA9-4040-B67D-3EE81688BE20@pfrc.org> <7B218D32-A783-42E2-8C05-6C2A8FCC2E34@juniper.net>
To: John Scudder <jgs@juniper.net>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/_LrD0Fnw3h0xmQHXmge2z1baCQA>
Subject: Re: [yang-doctors] Dealing with BFD RFC 9127 client-cfg-parms for PIM, OSPF, ISIS and other BFD clients on some platforms
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Nov 2021 16:59:36 -0000

We have a proposed set of changes slightly different than my original diff.

Mahesh is working with the yanglint tools team on the validator tooling to ensure we're doing the right thing.  

If it helps move things along, we certainly can post the current diff.

-- Jeff


> On Nov 23, 2021, at 11:21 AM, John Scudder <jgs@juniper.net> wrote:
> 
> Just checking in again on this. Sorry to nag, but we had (somewhat arbitrarily) set tomorrow as a deadline:
> 
>>>> On Nov 10, 2021, at 4:42 PM, Rob Wilton (rwilton) <rwilton@cisco.com> wrote:
> ...
>>>> We would like to reach an agreement on what the plan/changes are no later than Nov 24th, sooner if possible.
> 
> 
> Are we there yet?
> 
> Thanks,
> 
> —John
> 
>> On Nov 19, 2021, at 8:02 AM, Jeffrey Haas <jhaas@pfrc.org> wrote:
>> 
>> [External Email. Be cautious of content]
>> 
>> 
>> We've been iterating on it in the background.  Reshad had pointed out the original diff I created was not correct for part of where the base config is inherited, offered an update and we're tweaking it based on language feature.
>> 
>> The version that circulated last night seems promising.  I think we're waiting on Mahesh to respond for the review.
>> 
>> -- Jeff
>> 
>> 
>>> On Nov 19, 2021, at 4:56 AM, Rob Wilton (rwilton) <rwilton@cisco.com> wrote:
>>> 
>>> Hi Jeff, Mahesh,
>>> 
>>> Any update on that diff?
>>> 
>>> Thanks,
>>> Rob
>>> 
>>> 
>>> -----Original Message-----
>>> From: Jeffrey Haas <jhaas@pfrc.org>
>>> Sent: 10 November 2021 23:26
>>> To: Rob Wilton (rwilton) <rwilton@cisco.com>
>>> Cc: Martin Björklund <mbj+ietf@4668.se>se>; ladislav.lhotka@nic.cz; rtg-ads@ietf.org; yang-doctors@ietf.org; Reshad Rahman <reshad@yahoo.com>
>>> Subject: Re: [yang-doctors] Dealing with BFD RFC 9127 client-cfg-parms for PIM, OSPF, ISIS and other BFD clients on some platforms
>>> 
>>> I spent some time talking to Mahesh this afternoon and think we’re in sync.
>>> 
>>> Expect a complete diff from him soon.
>>> 
>>> Jeff
>>> 
>>>> On Nov 10, 2021, at 4:42 PM, Rob Wilton (rwilton) <rwilton@cisco.com> wrote:
>>>> 
>>>> [Resending with Reshad's correct address]
>>>> 
>>>> Hi,
>>>> 
>>>> Thanks for the input so far.
>>>> 
>>>> Having chatted with Alvaro and John, I believe that we are looking for a solution such that (1) we know what is being done in RFC 9127bis, and (2) allows the Auth48 of the protocol drafts to complete so that they can be published.  I.e., it is okay to delay Auth48 by a couple of weeks so that we know exactly what changes need to be made to the modules in Auth48, but not to delay publishing of the protocol drafts until RFC 9217bis has gone through the process.
>>>> 
>>>> We would like to reach an agreement on what the plan/changes are no later than Nov 24th, sooner if possible.
>>>> 
>>>> My reading of the consensus so far so that it is acceptable to make non-backwards-compatible changes to RFC 9217bis, if necessary, but we should not make non-backwards-compatible changes without a good justification.
>>>> 
>>>> I think, if I understand the proposals correctly, that I'm leaning towards option (2) that Martin described below.
>>>> 
>>>> Regards,
>>>> Rob
>>>> 
>>>> 
>>>> -----Original Message-----
>>>> From: Martin Björklund <mbj+ietf@4668.se>
>>>> Sent: 10 November 2021 15:26
>>>> To: jhaas@pfrc.org
>>>> Cc: Rob Wilton (rwilton) <rwilton@cisco.com>om>; ladislav.lhotka@nic.cz; rtg-ads@ietf.org; yang-doctors@ietf.org; rrahman@cisco.com
>>>> Subject: Re: [yang-doctors] Dealing with BFD RFC 9127 client-cfg-parms for PIM, OSPF, ISIS and other BFD clients on some platforms
>>>> 
>>>> Jeffrey Haas <jhaas@pfrc.org> wrote:
>>>>>> On Wed, Nov 10, 2021 at 03:24:19PM +0100, Martin Björklund wrote:
>>>>>> I'm not ok with this violation in general, but I am ok with it in this
>>>>>> particular case.  Hence my questions.
>>>>> 
>>>>> Understood.
>>>>> 
>>>>>> If it turns out that in the end
>>>>>> you modify the AUTH48-docs and wait for the bis anyway, then I don't
>>>>>> think this is the right way to go.
>>>>> 
>>>>> So, your preference is "ship AUTH48 docs unchanged, even though it'd have a
>>>>> potentially redundant 'feature bfd'"?
>>>> 
>>>> Of course my preference is to not violate the upgrade rules, if
>>>> possible.
>>>> 
>>>> 1.  publish the auth48-docs now with redundant "bfd" feature
>>>> 2.  publish the auth48-docs now and remove the redundant "bfd" feature
>>>> 3.  remove the redundant "bfd" feature and wait for -bis
>>>> 
>>>> I am not sure I understand what the proposal is at this point (as I
>>>> understood it, your original proposal was (1), but also w/o "bfd" in
>>>> -bis).
>>>> 
>>>> With (2), the published docs won't be very useful until the -bis is
>>>> published, right?
>>>> 
>>>> In the case of (3), I think it is better to make a proper fix to -bis.
>>>> 
>>>> And in the case of (1), you could as well introduce redundant
>>>> "client-cfg-param" features (as I suggested earlier), and avoid the
>>>> proposed -bis YANG upgrade rule violation.
>>>> 
>>>> Anyway, if you still decide to go with (1) or (2), I am ok with the
>>>> proposed -bis.  (I prefer (2) over (1)).
>>>> 
>>>> 
>>>> 
>>>> /martin
>>> 
>> 
>