Re: [yang-doctors] Yangdoctors last call review of draft-ietf-rtgwg-yang-rib-extend-03
Yingzhen Qu <yingzhen.qu@futurewei.com> Thu, 25 June 2020 22:45 UTC
Return-Path: <yingzhen.qu@futurewei.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BD2813A1051; Thu, 25 Jun 2020 15:45:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.09
X-Spam-Level:
X-Spam-Status: No, score=-2.09 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mla2vy6ag7Jx; Thu, 25 Jun 2020 15:45:03 -0700 (PDT)
Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700104.outbound.protection.outlook.com [40.107.70.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8504B3A104E; Thu, 25 Jun 2020 15:45:00 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OCiAsbM2yONwzHVHDlilxqqrXJLlo/z0DInqaRyNe7gTlHTeNR5oqPsIjm1YfRJ1Ehkldcq8Rwn8yAeXVgFjwSzlwm0NfVq7qK7eknNB5gSRXAMnBlQMH+Gk53vP5vgplJlkkSlYqJvDz13UHmptlh0SB/ue7RWMk5rOSo9vV0I/NKhSrF0K5Tzv7w30J8ZwBF+tjuyc5/cI98abJtD76/1u/jMKpZ1JYdjl/JImMl2pykJ/0vS+ocdW8BzeVYd0+CLGZhfiWZ4xOJS2KhD2A/6pX0/27x7RgHTrsV7hn+RRk7IYQHOKGLa5oTaJWIJ82ZUh6pNCmywZWdtAWRMs2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=okXNyAq3ymbDMU31UibIZH29xf7xys4X8dkzs/Q1oaU=; b=Ae60cIgdtxCxgfwQh/G+eZSMAjw6S1ssFU6hmv9dPk5txjdr0cQhQBOcflw3cYEJGhbYJoFoqv7GHozJktEk4oxW1SkHnVhoF1n49Y6Mj+oJPTcQLlWPtk0cihTVnFOqf0p2+xRiTLAZMadI6dRRUPm3O1MJVGdSDqvzR9QT/NTwl7IAqcJMMcU/IB1ifzf1xRqPLZ+AcL7H86wl+lF6rZIJKthv0WVKFQwCvJZzKhJ+ZODPYeCWvqrgsJuWgbG0DvOTeel55BaWxOxZawxxBa3UZsPxqzxOXj+5bmub+5BdeJKZXCtTADOXUAsPbRh1jK+3lQl72osspsNfdKBuWA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=futurewei.com; dmarc=pass action=none header.from=futurewei.com; dkim=pass header.d=futurewei.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=okXNyAq3ymbDMU31UibIZH29xf7xys4X8dkzs/Q1oaU=; b=pZf7gdY9tIt1RBB4AqQPVysCq6BoMGn4rnfEtPByoS1RYRZclZ0XkvPQ4G7wM93/mv5XQfSsIzisoR6oOCm35jTFZGuhrzyTnR0GSaWIQZq2VpBhUjF2/+twhjha5BS0Xmz/PXd2SnMOxrVMduoBvHaydYjdrKIsuEghCV4VO8w=
Received: from BY5PR13MB3048.namprd13.prod.outlook.com (2603:10b6:a03:188::21) by BYAPR13MB2885.namprd13.prod.outlook.com (2603:10b6:a03:fc::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.12; Thu, 25 Jun 2020 22:44:57 +0000
Received: from BY5PR13MB3048.namprd13.prod.outlook.com ([fe80::28f0:8a33:3418:b39b]) by BY5PR13MB3048.namprd13.prod.outlook.com ([fe80::28f0:8a33:3418:b39b%4]) with mapi id 15.20.3153.012; Thu, 25 Jun 2020 22:44:56 +0000
From: Yingzhen Qu <yingzhen.qu@futurewei.com>
To: Christian Hopps <chopps@chopps.org>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "rtgwg@ietf.org" <rtgwg@ietf.org>, "draft-ietf-rtgwg-yang-rib-extend.all@ietf.org" <draft-ietf-rtgwg-yang-rib-extend.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-rtgwg-yang-rib-extend-03
Thread-Index: AQHWQRbxoo8oQ8D7KUSnL3vIv1A7+qjpjPgA
Date: Thu, 25 Jun 2020 22:44:56 +0000
Message-ID: <DC357563-E3D0-4A23-BCA2-12FDD1EC9AF3@futurewei.com>
References: <159200698154.14152.758833840972322733@ietfa.amsl.com>
In-Reply-To: <159200698154.14152.758833840972322733@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1e.0.191013
authentication-results: chopps.org; dkim=none (message not signed) header.d=none;chopps.org; dmarc=none action=none header.from=futurewei.com;
x-originating-ip: [2601:646:9500:c900:2c1c:f8e1:146b:215d]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5d9b32ea-59d2-4159-9fb3-08d819596298
x-ms-traffictypediagnostic: BYAPR13MB2885:
x-microsoft-antispam-prvs: <BYAPR13MB2885B98E917DB826888BB5F2E1920@BYAPR13MB2885.namprd13.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 0445A82F82
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Oj+yaFjN9lj6UhUEjahX0yVx4/gX0we2n+AFR/h6w1XZKSMWlnfXx5vbstro0hVOPixl8p/CJAPsLnXwI5NoMWlLQf+uQxOkVEkhc1Gs8KRniMl0uyvH6XD/qTPIFiQ0uRQVRqs2ixJNCRRd/rlNUT8z3kLlaVnPcJCeisjyejTZHNBV1mKat1nFXsqB+md9AYOPe3jskS7TeSJx/0JpGvKHbKV+hF9r5VTNv3qG6J+zo1YUw8LNaU9seAok8a8uh45mF3s0dVs37ZaAyVGjYlt2wYuk5dstsAL5VrkzJAK/5ejLTs7AiBrOreGLuJg/s6OKyMcw3uybjNYc4fRguQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR13MB3048.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(376002)(136003)(39840400004)(366004)(66556008)(4326008)(2906002)(33656002)(110136005)(36756003)(5660300002)(316002)(8676002)(186003)(54906003)(86362001)(76116006)(478600001)(44832011)(64756008)(2616005)(6512007)(71200400001)(66446008)(66476007)(6486002)(8936002)(66946007)(83380400001)(6506007); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: kJEii/E4n/mu2uQsU/hyea94qq/6+JCnMOBsc14QHNqj4ulv/EpnmtxbfpKNm0ANyCskt1ihThygz+YirVLXif5J+US9SPogsVwkuF123gJZHZ8URiMp7XmRhyKk7cc6oWSCCbd5j2IkLefnLgEt4xIldgHNte7+BgnHlaUEfk2f6EiQrmz438jV85KBB1UjUupMwFs0q4f53b2HL/mDYMC8YdFdPSQzDxI1bRxPa9Cd5h8tj8OAe5/yGIt5hvZ6YB08OPcz2jbY+uAP+iC8jt3RO5/TfSRjdWTisT5ToC/I+MOQz8jWkqub7DrApEiIvoIvnoe2aqYcpTiLPvNapw2iyr9cl8p7RRW2CzDOk4DQDdQUGSStqDBi4d4fZxRN+xsIwvBQVhJ9I58fl+9Q/OIlfGqBgrc+Bw+TZQSPY57crUEoegG5R+2XApWazMWIPImCQpuHABM1K0QAZHmJ5oHCbR5lYxx9YVS7RXhOIZLgIotpWK2K63xp3DIvokE8t3sxxLIjoF3idUABeq+5CEjtH8qLE2XIaY2wnc+eeDgmdOfad9IkDtqwBp6VsQ9q
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <6F425B32A720394FB3660D124F44B120@namprd13.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR13MB3048.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d9b32ea-59d2-4159-9fb3-08d819596298
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2020 22:44:56.7899 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x6DPERLg1rEMHTEx4Em2Ogqton5t66QGSEQ/ku2UBL3pB2dWZKiCi6koC2/xzF3oN0in0wlnFuQeHcUzQWihFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR13MB2885
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/c0pZyWyK0udWuMap_OapMN53leQ>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-rtgwg-yang-rib-extend-03
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2020 22:45:06 -0000
Hi Chris, Thank you for the thorough review. I've uploaded version -04 to address your comments. Please see details inline. Thanks, Yingzhen On 6/12/20, 5:09 PM, "Christian Hopps via Datatracker" <noreply@ietf.org> wrote: Reviewer: Christian Hopps Review result: Almost Ready * Review of draft-ietf-rtgwg-yang-rib-extend-03 ** Questions: - Should the routing-state branch also be augmented? [YQ]: This draft is to augment RFC 8349 with additional RIB entries, which obsoletes RFC 8022 because of NMDA (RFC 8342). The routing-state branch has been obviated and obsoleted because of NMDA. - Preferences are only be added to static routes it seems. Aren't preferences a generic RIB concept though that determines which route the RIB selects as active? Is there are reason to not add them as operational state for all routes? [YQ]: Yes, preference is a generic RIB concept, and it's already included in RFC 8349. From RFC 8349: | +--rw ribs | +--rw rib* [name] | +--rw name string | +--rw address-family identityref | +--ro default-rib? boolean {multiple-ribs}? | +--ro routes | | +--ro route* | | +--ro route-preference? route-preference <------------- - Why are repair-routes (which are really repair-paths i.e., a set of next-hops) defined globally and then referred to by ID with leaf-refs, while normal sets of next hops are not defined this same way (i.e., they are defined inline with the route)? [YQ]: This has been changed to repair-paths and flatten out. ** Major - Experience has shown that examples not only help users but also serve as validation of the module schema itself. I think the document should at minimum include an example which fully exercises the module (and is validated). ([RFC8407] "Module Usage Examples"). [YQ]: an example is added to version -04. My review will assumes the eventual existence of this validated example rather than trying to do by a bye-eye validation of various issues it would catch (e.g., that xpaths free of typos, etc) ** Minor - In a few places more descriptions and reference are warranted . I think the level of expertise being assumed here may be too high (i.e., at the expert routing geek level vs someone with basic routing fundamentals knowledge), some comments following are specific to this point. [YQ]: many descriptions are updated, including "metric", "tag" etc. *** Module - "What's a metric?" A bit more description could be added. As this module is adding both metrics and preferences I think it could be more specific about what they both are. The preference description for static routes is pretty good as it says what it is and how it's used. There's nothing similarly given (in the module) though for the metric leaf. Metrics are briefly mentioned in the document Introduction. This could be as simple as saying something in the module like "The metric value as defined by the source of the route". But I feel like maybe more needs to be said about whether the RIB itself ever uses these metrics (it doesn't right?). Its a bit confusing I think b/c of the presence of possibly unequal metrics in the set of nexthops for a given, possibly active, route. - Appearing in multiple leafs: what is a "tag"s vs "application-tag"s. There's a description of "application-tag" in the module that uses "tag" to help define itself, but nothing for the "tag" its referring to. At least a reference or better, a few references should be given for these tag types. Routing experts with years of experience probably know what these are implicitly, but probably not others. - "repair-route" should probably be named "repair-path". Unlike their sibling "routes" they only really exist inside an actual route (i.e., they have no prefix to stand on their own as a "route"). [YQ]: fixed. ** Nits *** Text Section 3, last words of first paragraph: "monitor RIB." -> "monitor a RIB"? [YQ] : fixed *** Module - "path-attribute" grouping, should probably rename this "repair-path-attribute" (or something similarly more specific since it's only adding one thing) it makes "uses repair-path-attribute" more obvious. [YQ]: this is fixed together with the repair-path flatten-out change.
- [yang-doctors] Yangdoctors last call review of dr… Christian Hopps via Datatracker
- Re: [yang-doctors] Yangdoctors last call review o… Yingzhen Qu