Re: [yang-doctors] [Last-Call] Yangdoctors last call review of draft-ietf-i2nsf-nsf-monitoring-data-model-06

"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Thu, 29 April 2021 14:50 UTC

Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5441D3A0B16; Thu, 29 Apr 2021 07:50:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.455
X-Spam-Level:
X-Spam-Status: No, score=-1.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HK_NAME_FM_MR_MRS=0.631, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FREEMAIL_DOC_PDF=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id la92jblXas5w; Thu, 29 Apr 2021 07:50:22 -0700 (PDT)
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0C9123A0B0E; Thu, 29 Apr 2021 07:50:20 -0700 (PDT)
Received: by mail-lf1-x134.google.com with SMTP id h36so51128140lfv.7; Thu, 29 Apr 2021 07:50:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zbD1vF7tAq+KauhJTAGolcADvEZZnOlypG5Ut0qobHw=; b=c1NVsfcM7+YV2DMTyeDxnm0wG1FNxZoma7h26ZQPE0TvTWwiRHTlr83sTZmy9U/JGy dak3V1QOtFUGFXyH6qKIjNHzd0L18oLLnRxia6OZ3EkPfME5noiy0KkRyogPciAIiVkX mHcuZxNGXRZ8fRqahPWwBEU2eBPtvSaT/U3qzynZhxDFyYjuSVGIessWrtsOcJ5aOApX aNs8I8Z51lCDWeDag8xRGexwgHe5EVcXvdJmrBR7LMuMr8j31peV8i/A6BvfMuVBOjU0 wwnDcw6HLHSN58HwVOr2W8/L4X+Cz4rU+l2M9f7z2mUz6z0sx1CjNKPLZfgNNuy10XHB 6DFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zbD1vF7tAq+KauhJTAGolcADvEZZnOlypG5Ut0qobHw=; b=r1Mlvgivf9LbSRnJ90MwlqWl4FQpZ+0gQMAN+D8qaojVo6VNsz1BwP9KPcsDviCVQb 6WSg6nBguPahvgH4L/q9xaT+dKIXsmamlft2pBOpXPHRQ9kPSB0T7fMn/CU7VWwCrPuv bqxy1Uq/N0uKIfo7ZTxgpdShXtHDJUYlmXEqTnr7Bwfgv6TR2oqP4rCqux0eMIscHriO /cHq9PUB2iwJvVLjSopqdrB+saTc21JUUOYs1QmaTEdMYc5ckC7y+UkGgISzwqzse077 eRN1FNf309fspiV9BYMrb3JLQY/jSpW+iUbU0ad+t5j17JE8vw/1oZ1d07lPfz+S35ET zKvQ==
X-Gm-Message-State: AOAM531N+9i5y2ygdVd4f3E0GgrpEl/F0fZanpUbWZuziPHjSO2wC7zz UPQflpt3cEYQHTXaptv3Xok8CXkbOw7Sx9xCDHo=
X-Google-Smtp-Source: ABdhPJyjr2o8OeSCvmwu7VWEosHpKoqpUNnml9/Fyu9ElpzBdQafQ3QS4fOS0yw5in1htTgfMilIZp42hbk+qui7Vts=
X-Received: by 2002:ac2:5a08:: with SMTP id q8mr24862610lfn.12.1619707818233; Thu, 29 Apr 2021 07:50:18 -0700 (PDT)
MIME-Version: 1.0
References: <161652444666.30886.1452719047245335791@ietfa.amsl.com> <CAPK2Dezp8EZ9S4oCVz2YmAzXKxbne6qGoc5vfz=4MQvr3sWhGA@mail.gmail.com> <607419E2.6080803@btconnect.com>
In-Reply-To: <607419E2.6080803@btconnect.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Thu, 29 Apr 2021 23:49:41 +0900
Message-ID: <CAPK2DeyKg1xgW8uWveaqounDB+rpoyXCUUDOemr6y8ot20_x7g@mail.gmail.com>
To: tom petch <daedulus@btconnect.com>
Cc: Andy Bierman <andy@yumaworks.com>, Linda Dunbar <linda.dunbar@futurewei.com>, Yoav Nir <ynir.ietf@gmail.com>, draft-ietf-i2nsf-nsf-monitoring-data-model.all@ietf.org, "i2nsf@ietf.org" <i2nsf@ietf.org>, Last Call <last-call@ietf.org>, YANG Doctors <yang-doctors@ietf.org>, skku-iotlab-members <skku-iotlab-members@googlegroups.com>, Patrick Lingga <patricklink888@gmail.com>, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/mixed; boundary="00000000000025644205c11d9d60"
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/ec4dxdFei9-vtlWc-x-Tf1mpcmw>
Subject: Re: [yang-doctors] [Last-Call] Yangdoctors last call review of draft-ietf-i2nsf-nsf-monitoring-data-model-06
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Apr 2021 14:50:27 -0000

Hi Tom,
Patrick and I have addressed all your comments below with the following
revision.
https://datatracker.ietf.org/doc/html/draft-ietf-i2nsf-nsf-monitoring-data-model-08

I attach our revision letter.

Thanks.

Best Regards,
Paul

On Mon, Apr 12, 2021 at 6:59 PM tom petch <daedulus@btconnect.com> wrote:

> Paul
>
> Some admin comments on -07; I think that you need to:
>
> - change the title in YANG revision reference
>
> - add to the I-D references
> RFC959
> RFC8632
>
> - shorten lines. There is a limit to line length in RFC as per the Style
> Guide.  This is exceeded in the YANG where some of the path statements
> take it over 80 while some of the examples are over 100.
>
> - add a reference for the import of
> ietf-i2nsf-policy-rule-for-nsf
>
> HTH
>
> Tom Petcb
>
> On 01/04/2021 03:09, Mr. Jaehoon Paul Jeong wrote:
> > Hi Andy, Linda, and Yoav,
> > Patrick and I have addressed all the comments from Andy.
> > Here is the revised draft -07:
> >
> https://tools.ietf.org/html/draft-ietf-i2nsf-nsf-monitoring-data-model-07
> >
> > I attach a revision letter to explain how we addressed the comments.
> >
> > There are the major updates in this revision as follows:
> > ---
> >     o  This version is revised according to the comments of Andy Bierman
> >        who is a YANG doctor.
> >
> >     o  This version updates its title as "I2NSF NSF Monitoring Interface
> >        YANG Data Model".  It clarifies the NSF Monitoring Interface to
> >        deliver NSF monitoring data to an NSF data collector (e.g.,
> >        Security Controller and NSF data analyzer).
> >
> >     o  This version adds an attack destination IP address for DDoS-attack
> >        event to provide an NSF data collector with more information
> about the
> >        destination of DDoS-attack packets.
> >
> >     o  This version supports a notification for monitoring traffic flows
> >       to detect the source and destination (as a victim) of security
> attacks
> >       such as DDoS attack.
> > ---
> > If you have questions and comments, please let me know.
> >
> > Thanks.
> >
> > Best Regards,
> > Paul
> >
> >
> > On Wed, Mar 24, 2021 at 3:34 AM Andy Bierman via Datatracker <
> > noreply@ietf.org> wrote:
>