Re: [yang-doctors] Yangdoctors early review of draft-ietf-mpls-static-yang-09

Andy Bierman <andy@yumaworks.com> Fri, 13 September 2019 05:02 UTC

Return-Path: <andy@yumaworks.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B7D94120088 for <yang-doctors@ietfa.amsl.com>; Thu, 12 Sep 2019 22:02:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yumaworks-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j6vmNFWR-k27 for <yang-doctors@ietfa.amsl.com>; Thu, 12 Sep 2019 22:02:50 -0700 (PDT)
Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8470A120086 for <yang-doctors@ietf.org>; Thu, 12 Sep 2019 22:02:50 -0700 (PDT)
Received: by mail-lj1-x233.google.com with SMTP id q22so21191862ljj.2 for <yang-doctors@ietf.org>; Thu, 12 Sep 2019 22:02:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yumaworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HH9UfvziqSvK7rbCVrReFuT3C/PafEM1LEz/tUAV0Us=; b=w91p9LdQwScJVgS2YVSn+O7r7lFNW4R8dYcZFaUXW3vYeZtyM+h6csIuU3t1qI8r4Q 99dqVTChRiGwkhhlt0QD6cWTd36eE/IjIZCPfkrC23lIcNbSzlXw7H+sLgDwjPnzZ0f9 gjPBY/NCtCfKxTth3EEo7fM6CJEUUyefne/TSCjyIbIUezPG57POyBlt9z3I9ZEDxKoo R1w4AZ+4erh6/WWMEV2LqSQoIEesBt0X1r9UhHO+oX/tcfhe3jxzGVqvERxFCyky3NtV sMnpxa5mIDGBxrVcV/kiDOzwLkf2hEQ1PsxmQgrRHf/i/AUrZ+857gEPZfxn5iC8P/Of Xz5w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HH9UfvziqSvK7rbCVrReFuT3C/PafEM1LEz/tUAV0Us=; b=DPcQxA76/GsdjUia0ePnb06deOh3sIfLqbKEwMuHatvd5TwQRVTbvak8NyTRey2V84 J8/m9DYX6PoUmpudS0y3jDosm1pyW8Tm3ujrrexmW1wsj3b7daXW5ISNSNgenfSnWlME C3oY6tUbYm9PoXgIM9Ts7Zp+vDJi8waYj48XLc3fH9Lz+yLo8u8AS1eEYhkP+XQZRucB mpKodBnEjWqp6IiIXkwoQ0GSi0PFeHWTt6jCK7Yk6PO0rzJ0MXNx8rAs60dkdrwKkwvh FimQO5ZNIm8qD+AEVGZ4RIumBdSM9MP7pW2WjsGS9KTqUgjPb2BXXvPz7v0veuNLPtkt 7PzA==
X-Gm-Message-State: APjAAAVUt/QgkAHjS4e74j4jWxVTbwd9Z4RPZ4UiEJzzpz1eIRiwtS+f +Nbps0SoxR93yzn+yY+bqs9RZ8i0Jy8fgmpIKXIePg==
X-Google-Smtp-Source: APXvYqwbvp0RD7jmQVd9q/e70yqaQFxNUVzM772PbD7XuoZmwl1uhXn7m2ejLA3+dy/lEW6mcPyrtMZRui1fThMXwzA=
X-Received: by 2002:a2e:860c:: with SMTP id a12mr28430513lji.116.1568350968623; Thu, 12 Sep 2019 22:02:48 -0700 (PDT)
MIME-Version: 1.0
References: <156381448119.11357.2555532993158583807@ietfa.amsl.com> <BYAPR19MB341509F6F116B65811BF0DB1FCB00@BYAPR19MB3415.namprd19.prod.outlook.com>
In-Reply-To: <BYAPR19MB341509F6F116B65811BF0DB1FCB00@BYAPR19MB3415.namprd19.prod.outlook.com>
From: Andy Bierman <andy@yumaworks.com>
Date: Thu, 12 Sep 2019 22:02:37 -0700
Message-ID: <CABCOCHRHwOTEy0txGiCz=0k0O+X9pnDHqLVXov82GTwPaYNS-A@mail.gmail.com>
To: Tarek Saad <tsaad.net@gmail.com>
Cc: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-mpls-static-yang.all@ietf.org" <draft-ietf-mpls-static-yang.all@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000005e48c90592682a54"
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/emU1ScM2rmj7CeB2duvN9J12X-k>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-mpls-static-yang-09
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Sep 2019 05:02:54 -0000

Hi,

OK thanks,

Andy


On Thu, Sep 12, 2019 at 8:27 AM Tarek Saad <tsaad.net@gmail.com>; wrote:

> Hi Andy,
>
> Thanks for your review and comments. We have uploaded a new revision that
> addresses your comments.
> https://tools.ietf.org/html/draft-ietf-mpls-static-yang-10
>
> Inline for more details.
>
> ´╗┐On 7/22/19, 12:54 PM, "Andy Bierman via Datatracker" <noreply@ietf.org>;
> wrote:
>
>     Reviewer: Andy Bierman
>     Review result: Ready with Nits
>
>     - No pyang warnings or errors
>     - No noticeable typos or omissions
>
>     Nits:
>      - contact info includes WG Chairs; this was removed in the new usage
> guidelines
> [TS]: removed.
>
>     Questions:
>      - The ietf-mpls-static-extended module is used instead of a YANG
> feature.
>        Is the generic name 'extended' appropriate? What will the next
> module used to
>        avoid a YANG feature be called? extended2?
> [TS]: there are multiple models (at IETF) that have adopted similar
> approach of grouping non-base data in a separate module named as
> 'xxx-extended'. One argument was to enforce the base model be supported
> without any feature check - and hence makes it simpler to understand. Not
> sure I have an answer for names of future extended modules, but maybe
> extended-<feature1>, extended-<feature2>, etc.?
>
> Regards,
> Tarek
>
>
>