Re: [yang-doctors] Yangdoctors early review of draft-ietf-babel-yang-model-03

Mahesh Jethanandani <mjethanandani@gmail.com> Tue, 15 October 2019 01:38 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AE1F21200E6; Mon, 14 Oct 2019 18:38:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V1JL9fuRk0w5; Mon, 14 Oct 2019 18:38:29 -0700 (PDT)
Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AF58D120111; Mon, 14 Oct 2019 18:38:29 -0700 (PDT)
Received: by mail-pg1-x52d.google.com with SMTP id p12so1759525pgn.6; Mon, 14 Oct 2019 18:38:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=LgzMCQBRRxbZ/lSZRHl5g2qaaxFNWJcInEUHAXRG280=; b=DdcuCVbQAhwfcRXtV/cG2Hv3IGF51bI/46dQC47Itdwr/EhnDQGcV8rQqyo5hNIr1/ AZV1PFqkG2F+FBt97gIy7yh2PmoZ3MZVDLBts+PVBB8tBjAwYNwlbXc+ysu8eVYvZuH7 A7p5a+o65xrqorOqAbbu7P+nLnVhzBCuSz35REVMdeG1MT/Sf/KHMNko+cHpOBLmVzBs nT2AIiC+IJzW/p2Yy7wmze/Ttsi3Ra/lwQhPzecHmJkZrHs3l4BEk7B7wpm7TVMj4tIA dlcvRI6ywbpgfgyXyltcy2wQsC3aoYnmS2rT0riUmVl9HsGclCJ/wKAyl8vWN/uAAlXU AJoA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=LgzMCQBRRxbZ/lSZRHl5g2qaaxFNWJcInEUHAXRG280=; b=RYxNzie5BvRuE1B5YnJXeUosZQKL2NG6hScZxT2cq5k5ZVR7I6M9xB39YN6zN48gzX afrij030yYw5D5wRWxZM2wW52amVolsn7vG1OGhWqcsJ5ThaaGmKlTOCnuURjMePUMi2 5D4D/yGKAowk3Vpwjh20BuDsy9VBfCl8W/vuVhkfK4fHnK3mQ0dUXwziB5j31LifGipm Xsi3NA701txlv9IEII32QfqffqAuNMXcZcx360qSt3N49gfMH6EiOrS8fmZyBjb9jgnc xecbdRAjnthooGLNsAqLmSQZlUF7e8LJQ+oodQhP4jXym+Ahfhmgvgdm93Wxa0Tg1HOW GfNw==
X-Gm-Message-State: APjAAAVLUvIqDbaZCRjH4jSbgg/V5HCcAEl+z+6+ZLxZnINkxI5r2ivj UTlUv5v//16kvh44V+kao0O7mAX9
X-Google-Smtp-Source: APXvYqx5oBrI1FilAJO5xL52pbHoYMx+iJn9yOyEbfXxgv+GC0HEmjqv2zyir2IHcRnYY6Ewn4UCKQ==
X-Received: by 2002:a17:90a:9406:: with SMTP id r6mr41133101pjo.0.1571103508917; Mon, 14 Oct 2019 18:38:28 -0700 (PDT)
Received: from [10.33.123.155] ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id r18sm25965224pfc.3.2019.10.14.18.38.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Oct 2019 18:38:27 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <7C7FF9F2-1B87-46EB-A55D-FCA0C4E3CFD4@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_2BEE055B-C43E-45E5-8E35-B9B305F3D8DC"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Mon, 14 Oct 2019 18:38:26 -0700
In-Reply-To: <20191014.160642.807920684918683059.mbj@tail-f.com>
Cc: rkrejci@cesnet.cz, noreply@ietf.org, yang-doctors@ietf.org, draft-ietf-babel-yang-model.all@ietf.org, babel@ietf.org
To: Martin Bjorklund <mbj@tail-f.com>
References: <157106166738.24700.11185508261809138396@ietfa.amsl.com> <20191014.160642.807920684918683059.mbj@tail-f.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/fdUiM8LaGu593j-wHbP3-83-vhc>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-babel-yang-model-03
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2019 01:38:32 -0000


> On Oct 14, 2019, at 7:06 AM, Martin Bjorklund <mbj@tail-f.com>; wrote:
> 
> Radek Krejčí via Datatracker <noreply@ietf.org>; wrote:
>> Reviewer: Radek Krejčí
>> Review result: Ready with Nits
>> 
>> There is a single module in the draft: ietf-babel@2019-08-22.yang.
>> 
>> There are 2 warnings reported by pyang 2.0.2, but both warnings seem to be
>> false.
> 
> Actually, I think they are correct.
> 
> 
>> ietf-babel@2019-08-22.yang:53: warning: RFC 8407: 3.1: The IETF Trust Copyright
>> statement seems to be missing (see pyang --ietf-help for details).
> 
> Ok it isn't missing, but it doesn't use the eaxct words it should
> use.

Yes, the words are not exact. I see two versions of the copyright statement. Do not know which one is the correct one.

In the model and output of ‘pyang —ietf-help’

     Copyright (c) 2019 IETF Trust and the persons identified as
     the document authors.  All rights reserved.

     Redistribution and use in source and binary forms, with or
     without modification, is permitted pursuant to, and subject
     to the license terms contained in, the Simplified BSD
     License set forth in Section 4.c of the IETF Trust's Legal
     Provisions Relating to IETF Documents
     (http://trustee.ietf.org/license-info).


In the draft:

   Copyright (c) 2019 IETF Trust and the persons identified as the
   document authors.  All rights reserved.

   This document is subject to BCP 78 <https://tools.ietf.org/html/bcp78> and the IETF Trust's Legal
   Provisions Relating to IETF Documents
   (https://trustee.ietf.org/license-info <https://trustee.ietf.org/license-info>) in effect on the date of
   publication of this document.  Please review these documents
   carefully, as they describe your rights and restrictions with respect
   to this document.  Code Components extracted from this document must
   include Simplified BSD License text as described in Section 4.e of
   the Trust Legal Provisions and are provided without warranty as
   described in the Simplified BSD License.

> 
>> ietf-babel@2019-08-22.yang:208: warning: the module seems to use RFC 2119
>> keywords, but the required text from RFC 8174 is not found (see pyang
>> --ietf-help for details).
> 
> This one seems legit as well.

Yes, it is missing the word “NOT RECOMMENDED”. I will add it.

Thanks.

> 
> 
> /martin

Mahesh Jethanandani
mjethanandani@gmail.com