Re: [yang-doctors] [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Wed, 06 November 2019 13:31 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF109120894; Wed, 6 Nov 2019 05:31:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=TqURsGH8; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=omdVFJot
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w-bpNUNlGa21; Wed, 6 Nov 2019 05:31:53 -0800 (PST)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 25C731208C0; Wed, 6 Nov 2019 05:31:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=18785; q=dns/txt; s=iport; t=1573047113; x=1574256713; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=F2zKYJtutJ6Mmp62krDsxIchCluJ7eby+eQteOkc70c=; b=TqURsGH8UlA2iRT8VURaWxT7F0sGYT1d7tl6O352bwZ3tp85Ki62Sn6p tLFI9O/iCvPhuIiPPx5OvyuODUNcNoS10rFuH/4YMfdAKEk1cFUH/W2il tQYOArZDIpr0Bp6b3nGdmX3YoGox1YDUabtPRIEqzkJmfTDg3rqQHgoMe o=;
IronPort-PHdr: =?us-ascii?q?9a23=3ADG66oxR/BMKwkjqHXeqZ5o26Ddpsv++ubAcI9p?= =?us-ascii?q?oqja5Pea2//pPkeVbS/uhpkESXBdfA8/wRje3QvuigQmEG7Zub+FE6OJ1XH1?= =?us-ascii?q?5g640NmhA4RsuMCEn1NvnvOjYgFcRHXVlN9HCgOk8TE8H7NBXf?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0C5AQDLycJd/4sNJK1LGhoBAQEBAQE?= =?us-ascii?q?BAQEDAQEBAREBAQECAgEBAQGBfoEcL1AFbFggBAsqhCmDRgOKf06CEIlWiUa?= =?us-ascii?q?EYoFCgRADVAkBAQEMAQEYAQ4GAgEBgUyBPoE2AheDdyQ4EwIDCwEBBAEBAQI?= =?us-ascii?q?BBQRthTcMhVEBAQEBAwEBEBEdAQEpAwsBDQICAQgRAwECKAMCAgIUCwYLFAk?= =?us-ascii?q?IAgQOBSKDAAGBeU0DLgEOOaVdAoE4iGB1gTKCfgEBBYE0AQMCAQsCQAGCfg0?= =?us-ascii?q?LghcJBYExjBQYgUA/gTgfgh4uPoIbRwEBAQIBgSoBEgE2CQ0Jgloyggoij04?= =?us-ascii?q?3hT8khlGCRY5FQQqCJIcVihYEhA0bgjxyhmuPU5ADhRuBVIISjyMCBAIEBQI?= =?us-ascii?q?OAQEFgT8qImdxcBU7KgGCQQlHERSCYiQ4gztqhCqFP3QBgSeOJA0XB4ITAQE?=
X-IronPort-AV: E=Sophos;i="5.68,274,1569283200"; d="scan'208,217";a="358481324"
Received: from alln-core-6.cisco.com ([173.36.13.139]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 06 Nov 2019 13:31:52 +0000
Received: from XCH-RCD-016.cisco.com (xch-rcd-016.cisco.com [173.37.102.26]) by alln-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id xA6DVqU9027464 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 6 Nov 2019 13:31:52 GMT
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by XCH-RCD-016.cisco.com (173.37.102.26) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 6 Nov 2019 07:31:51 -0600
Received: from xhs-aln-003.cisco.com (173.37.135.120) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 6 Nov 2019 08:31:50 -0500
Received: from NAM04-CO1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 6 Nov 2019 07:31:49 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TU/c5i7H7x1Kn0kRsIYNzsuiAcjjkMBQ8k/u8zqMc7g6EWEmMx09cWNl7QvNEHPgSpPyQLN1hQ2txUxa94UG9yEmWO44yj+Ie0ObeS8nwzvS+vjxine3eWGGjXC1HozQOtjis49LhDfSwyr+F1/GwNzmw8jKsSME6CJcodasuavFBnrqskVzm0aLKPFL4fBPWEYgbiYWNNgGvWS5RhfLJaULZhjU/2q1pcew0v+YeluUPCY57cm2s1FaJ/38+dEL1xpgFl5w/nxmpohT8ljmYZoM0ef1yPZj1bA/K+p8cYPVV1fwEicgp1+BlwzFvS5ryZ0Rjc8bu9Phory16b7fgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F2zKYJtutJ6Mmp62krDsxIchCluJ7eby+eQteOkc70c=; b=oIRVb37NpALdYE+umKA5UgCvcN9HSmGH40LdGDpaCGWiS5hn994DGcJ7EmkjT+If8UbTVMOtefrcj0YTzOGRE9QqT9f4bdQKCnozfdx8EKoPaIxLjlrPVHQwsQdcPhFyYNBSbJCADLO9HjKC5w4OdXrn/v9WKH/ED4o0V//fKCrZgaCj1d+Ki5rspvWRWGs62ek/aLrAMg/lGQGZ1PM/gq4vgAA/KzeRu2AslVilOU3OzeDoKZvheCed4DUu79cXIGZyaooZ6KuO/g4QcPf7H/jLenCQy1vzXE+DG6bc/gdVohWg1uEBqmNErKoSTBiyURjhPU4MXnJCAC+IhpMUjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F2zKYJtutJ6Mmp62krDsxIchCluJ7eby+eQteOkc70c=; b=omdVFJotfnpIt6nz6/bHVkpEaQvrW3UZqOrbuimCyjcCbOoyX9QKdJ5XNObeTVXsvpEdbNsUEOtKfIXztR7EjJOQmFGycXoB7dYhaHq7zVHcZyEMOhXyCBtLIFZhK25TIH0EozQBc6ycdEYLNkRtJBCnAcNpXt9G5RZdApPI3SQ=
Received: from MN2PR11MB4157.namprd11.prod.outlook.com (10.255.181.213) by MN2PR11MB4302.namprd11.prod.outlook.com (52.135.36.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Wed, 6 Nov 2019 13:31:48 +0000
Received: from MN2PR11MB4157.namprd11.prod.outlook.com ([fe80::88cb:fcc7:df90:124]) by MN2PR11MB4157.namprd11.prod.outlook.com ([fe80::88cb:fcc7:df90:124%5]) with mapi id 15.20.2408.024; Wed, 6 Nov 2019 13:31:48 +0000
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
CC: YANG Doctors <yang-doctors@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>, "draft-ietf-i2nsf-registration-interface-dm.all@ietf.org" <draft-ietf-i2nsf-registration-interface-dm.all@ietf.org>, Sangwon Hyun <swhyun77@gmail.com>, "skku-iotlab-members@googlegroups.com" <skku-iotlab-members@googlegroups.com>
Thread-Topic: [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04
Thread-Index: AQHVQvTAkkfTX09q5USrQyd4LCPXc6d+Bl8AgABs+IA=
Date: Wed, 6 Nov 2019 13:31:48 +0000
Message-ID: <FB2A8303-B455-4D37-A4C3-57834411EE6F@cisco.com>
References: <156175664267.21931.10329030969352120108@ietfa.amsl.com> <CAPK2DezmXhBA39GFMrU6tYFte_rDK+DE=WyWpzSNFMvnNU+xGQ@mail.gmail.com> <CAPK2Deym5jVmi4JKekRVznpNCkO_x8PN7jz7DLXkgUNZ9V4uUw@mail.gmail.com>
In-Reply-To: <CAPK2Deym5jVmi4JKekRVznpNCkO_x8PN7jz7DLXkgUNZ9V4uUw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1e.0.191013
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rrahman@cisco.com;
x-originating-ip: [2001:420:2840:1250:6900:eb73:e481:aee6]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f6f4b07c-c5dc-44a1-c97a-08d762bdacea
x-ms-traffictypediagnostic: MN2PR11MB4302:|MN2PR11MB4302:
x-ms-exchange-purlcount: 4
x-microsoft-antispam-prvs: <MN2PR11MB4302E8AD9D6316BDF338E0D1AB790@MN2PR11MB4302.namprd11.prod.outlook.com>
x-ms-exchange-transport-forked: True
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 02135EB356
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(189003)(199004)(71200400001)(33656002)(478600001)(8676002)(4326008)(66946007)(186003)(58126008)(256004)(9326002)(46003)(2616005)(14444005)(476003)(36756003)(76176011)(53546011)(6506007)(6916009)(8936002)(236005)(76116006)(6512007)(99286004)(107886003)(15188155005)(316002)(54896002)(66446008)(6306002)(66476007)(64756008)(66556008)(6246003)(14454004)(81156014)(7736002)(71190400001)(81166006)(102836004)(6486002)(54906003)(11346002)(16799955002)(6436002)(446003)(486006)(86362001)(91956017)(5660300002)(606006)(25786009)(966005)(2906002)(6116002)(325944009)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4302; H:MN2PR11MB4157.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: gCGvl7gflLfgpWh/fHse7QT+fpWFjvC1kH1YyUG+Gg5RHS8bayLeJLqeakSBy8GUDjIx/FWn49/s/tSKauximO6O7EQQkprNcFO0n6aP8Py5cXvtMN4NJWeqcFXQ2i5GhFdo5X8xdm/JQNgxoLWKTCnHC+J4vBekpnKbEbSZ3mFKCXQJN3GnUx4q1c3TLDJulqW07wbxBCve1dhgrI8Amld52bdIF8PVU6Ty9Z9pV7t6RpmSa9WUwftx/hQJWYsVaLzb+4uvoPs9+5pNYPGgf/Nq8L+AFmbqNn3x3IVzwJXDMnKsw5h4p8qbVdx+IMBlGV6YnSxA9gc7mlAM6AKK0J5Ij6kELYLj7eY8fJFi+NgJT7rPH7Nsk2m3b1kqkrkJIgXilUE2Zt0quE5EKC2Sv2015nLBhhQj69+hsA70XEag6kpjZcjWtzXTGmLI+STixaISIX5V7zjIzTNL/6c2qOdKiGQjkap11nXJWcMrLOE=
Content-Type: multipart/alternative; boundary="_000_FB2A8303B4554D37A4C357834411EE6Fciscocom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f6f4b07c-c5dc-44a1-c97a-08d762bdacea
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2019 13:31:48.4454 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +tFPpSlPdKuECYfaKJxRvA8w94KTCc8BKI3xRUcJeP8SZa49VkUKN+Ps8VZVvqJyVQLce449gkMRf7aXNI9KoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4302
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.26, xch-rcd-016.cisco.com
X-Outbound-Node: alln-core-6.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/hTGCDuwbLgxDCVlVYT5sNggDH30>
Subject: Re: [yang-doctors] [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2019 13:31:56 -0000

Hi Paul,

I have started looking at the recent revision of the draft but haven’t managed to do a formal re-review yet. I will do one as soon as possible.

Apologies for the delay.

Regards,
Reshad.

From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>;
Date: Tuesday, November 5, 2019 at 9:02 PM
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>;
Cc: YANG Doctors <yang-doctors@ietf.org>;, "i2nsf@ietf.org"; <i2nsf@ietf.org>;, "draft-ietf-i2nsf-registration-interface-dm.all@ietf.org"; <draft-ietf-i2nsf-registration-interface-dm.all@ietf.org>;, Sangwon Hyun <swhyun77@gmail.com>;, "skku-iotlab-members@googlegroups.com"; <skku-iotlab-members@googlegroups.com>;, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>;
Subject: Re: [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04

Hi Reshad,
I believe that I have addressed your comments on I2NSF Registration Interface Data Model:
https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-05

If you are satisfied with the revision, could you update the Review result in the following page?
https://datatracker.ietf.org/doc/review-ietf-i2nsf-registration-interface-dm-04-yangdoctors-lc-rahman-2019-06-28/

Thanks.

Best Regards,
Paul

On Thu, Jul 25, 2019 at 11:23 PM Mr. Jaehoon Paul Jeong <jaehoon.paul@gmail.com<mailto:jaehoon.paul@gmail.com>> wrote:
Hi Reshad,
Here is the revision letter for the revised draft, reflecting your comments along with the revised draft:
https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-05

If you have further comments and questions, please let me know.

Thanks.

Best Regards,
Paul

On Fri, Jun 28, 2019 at 5:17 PM Reshad Rahman via Datatracker <noreply@ietf.org<mailto:noreply@ietf.org>> wrote:
Reviewer: Reshad Rahman
Review result: On the Right Track

YANG Doctor review of draft-ietf-i2nsf-registration-interface-dm-04 (by Reshad
Rahman)

Major comments:
- Look at appendix B of RFC8407 for an example of how a YANG module should be
structured. This document does not abide to that. - Poor descriptions e.g.
"nsf-name" for leaf "nsf-name" etc - prefix "iiregi" doesn't seem right. What
about "nsfreg"? Probably needs coordination with the other I2NSF YANG modules
to have consistency between the prefixes. I see that YD Acee suggested
"nsfintf" for draft-ietf-i2nsf-nsf-facing-interface-dm-06 - No unit specified
for bandwidth, processing (performance) - nsf-address is IPv4 specific -
Security considerations should list the nodes as per section 3.7 of RFC8407. -
Should this document be informational since 8329 is informational? - Section 2
should use RFC8174 also - Refer to RFC8407 instead of 6807 (YANG Guidelines) -
Examples should use IPv6 as examples (use the range from RFC3849). Kudos for
all the examples.

Minor comments and questions:
- The YANG trees such as Figure 6, 7 etc don't show the contents of the
groupings. So they don't help much. - nsf-port-address should be nsf-port? -
Section 4, last bullet. I am not an expert on I2NSF so not clear to me why this
query is needed, is it because NSF may not re-register after their capabilities
have been updated? Might be worth adding some explanation. - Have the examples
been validated?

_______________________________________________
I2nsf mailing list
I2nsf@ietf.org<mailto:I2nsf@ietf.org>
https://www.ietf.org/mailman/listinfo/i2nsf


--
===========================
Mr. Jaehoon (Paul) Jeong, Ph.D.
Associate Professor
Department of Software
Sungkyunkwan University
Office: +82-31-299-4957
Email: jaehoon.paul@gmail.com<mailto:jaehoon.paul@gmail.com>, pauljeong@skku.edu<mailto:pauljeong@skku.edu>
Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php<http://cpslab.skku.edu/people-jaehoon-jeong.php>


--
===========================
Mr. Jaehoon (Paul) Jeong, Ph.D.
Associate Professor
Department of Software
Sungkyunkwan University
Office: +82-31-299-4957
Email: jaehoon.paul@gmail.com<mailto:jaehoon.paul@gmail.com>, pauljeong@skku.edu<mailto:pauljeong@skku.edu>
Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php<http://cpslab.skku.edu/people-jaehoon-jeong.php>