Re: [yang-doctors] Yangdoctors early review of draft-ietf-bfd-unsolicited-01

Martin Bjorklund <mbj@tail-f.com> Mon, 19 August 2019 19:18 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 639D61200F3; Mon, 19 Aug 2019 12:18:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4M2Dwlb_8Hfp; Mon, 19 Aug 2019 12:18:39 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 38FB7120019; Mon, 19 Aug 2019 12:18:39 -0700 (PDT)
Received: from localhost (h-46-233.A165.priv.bahnhof.se [46.59.46.233]) by mail.tail-f.com (Postfix) with ESMTPSA id 8D27A1AE0397; Mon, 19 Aug 2019 21:18:37 +0200 (CEST)
Date: Mon, 19 Aug 2019 21:18:37 +0200 (CEST)
Message-Id: <20190819.211837.1184862907842631386.mbj@tail-f.com>
To: rrahman@cisco.com
Cc: mjethanandani@gmail.com, yang-doctors@ietf.org, rtg-bfd@ietf.org, draft-ietf-bfd-unsolicited.all@ietf.org, ietf@ietf.org, draft-ietf-bfd-yang@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <22279DB9-A0F3-4D5E-BFDC-38B2AD5B109F@cisco.com>
References: <156621414936.19813.853283734958376284@ietfa.amsl.com> <0CD4CB48-9382-4724-A5A6-A7B0DE7D7D57@gmail.com> <22279DB9-A0F3-4D5E-BFDC-38B2AD5B109F@cisco.com>
X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=utf-8
Content-Transfer-Encoding: base64
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/m8Xvjy9pXgB58wU9L-Ehksym6c8>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-bfd-unsolicited-01
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Aug 2019 19:18:42 -0000

"Reshad Rahman (rrahman)" <rrahman@cisco.com>; wrote:
> Thanks Martin and Mahesh.
> 
> I believe we should add a mandatory statement to the choic (speaking
> as BFD YANG co-author,)

But then it is not clear why all leafs in the cases have default
statements.

Since the 'single-interval' case is optional with a if-feature (which
BTW is weird since it is trivial to implement), and the only other
case has default values on both its leafs, I would have assumed that
the intention was that if nothing is configured, the server should use
1000000 microseconds for the intervals.  If this is the intention,
perhaps a statement:  "default tx-rx-intervals;" can be added to the
module, even though the doc is in the RFC ed q.


/martin



> 
> Just created https://github.com/bfd-wg
> 
> Regards,
> Reshad.
> 
> 
> On 2019-08-19, 2:45 PM, "Mahesh Jethanandani" <mjethanandani@gmail.com>; wrote:
> 
>     [Adding the authors of BFD YANG module]
>     
>     Martin brings up a good point. But since the document that contains ietf-bfd-types is sitting in RFC Ed Queue, this will have to go into a bis document.
>     
>     Chairs, could you create a bfd-wg in GitHub for us to track this as an issue to be fixed as part of a bis document?
>     
>     > On Aug 19, 2019, at 4:29 AM, Martin Björklund via Datatracker <noreply@ietf.org>; wrote:
>     > 
>     > Reviewer: Martin Björklund
>     > Review result: Ready with Nits
>     > 
>     > I have reviewed this document from a YANG model perspective only.
>     > 
>     > My only comment is actually for a grouping defined in ietf-bfd-type, but used
>     > in this module.  There is a choice "interval-config-type":
>     > 
>     >  +--rw unsolicited {bfd-unsol:unsolicited-params-global}?
>     >       +--rw enable?                           boolean
>     >       +--rw local-multiplier?                 multiplier
>     >       +--rw (interval-config-type)?
>     >          +--:(tx-rx-intervals)
>     >          |  +--rw desired-min-tx-interval?    uint32
>     >          |  +--rw required-min-rx-interval?   uint32
>     >          +--:(single-interval) {single-minimum-interval}?
>     >             +--rw min-interval?               uint32
>     > 
>     > This choice is not mandatory and doesn't have a default case, so the question
>     > is what happens if no nodes from the choice has been configured?   I would
>     > expect the choice to have a default case (but this then would apply to
>     > ietf-bfd-types, not this document.)
>     > 
>     > 
>     
>     Mahesh Jethanandani
>     mjethanandani@gmail.com
>     
>     
>     
>     
>