Re: [yang-doctors] Yangdoctors last call review of draft-ietf-bfd-yang-09

Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> Tue, 13 March 2018 14:58 UTC

Return-Path: <j.schoenwaelder@jacobs-university.de>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B0D5B124B0A; Tue, 13 Mar 2018 07:58:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bGmF1n-DoFGe; Tue, 13 Mar 2018 07:58:47 -0700 (PDT)
Received: from atlas5.jacobs-university.de (atlas5.jacobs-university.de [212.201.44.20]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 26D86127369; Tue, 13 Mar 2018 07:58:47 -0700 (PDT)
Received: from localhost (demetrius5.irc-it.jacobs-university.de [10.70.0.222]) by atlas5.jacobs-university.de (Postfix) with ESMTP id 730A8DD0; Tue, 13 Mar 2018 15:58:45 +0100 (CET)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from atlas5.jacobs-university.de ([10.70.0.217]) by localhost (demetrius5.jacobs-university.de [10.70.0.222]) (amavisd-new, port 10032) with ESMTP id mYE3asELa_iE; Tue, 13 Mar 2018 15:58:43 +0100 (CET)
Received: from hermes.jacobs-university.de (hermes.jacobs-university.de [212.201.44.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hermes.jacobs-university.de", Issuer "Jacobs University CA - G01" (verified OK)) by atlas5.jacobs-university.de (Postfix) with ESMTPS; Tue, 13 Mar 2018 15:58:45 +0100 (CET)
Received: from localhost (demetrius4.jacobs-university.de [212.201.44.49]) by hermes.jacobs-university.de (Postfix) with ESMTP id 4810420161; Tue, 13 Mar 2018 15:58:45 +0100 (CET)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from hermes.jacobs-university.de ([212.201.44.23]) by localhost (demetrius4.jacobs-university.de [212.201.44.32]) (amavisd-new, port 10024) with ESMTP id 3RVbNJocqWIl; Tue, 13 Mar 2018 15:58:44 +0100 (CET)
Received: from elstar.local (unknown [10.50.231.133]) by hermes.jacobs-university.de (Postfix) with ESMTP id 8A79720160; Tue, 13 Mar 2018 15:58:44 +0100 (CET)
Received: by elstar.local (Postfix, from userid 501) id 55489426E138; Tue, 13 Mar 2018 15:58:44 +0100 (CET)
Date: Tue, 13 Mar 2018 15:58:44 +0100
From: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
Cc: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-yang.all@ietf.org" <draft-ietf-bfd-yang.all@ietf.org>
Message-ID: <20180313145844.c5zz27p6tscl7me6@elstar.local>
Reply-To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
Mail-Followup-To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-yang.all@ietf.org" <draft-ietf-bfd-yang.all@ietf.org>
References: <151868731494.7525.9572645824096052010@ietfa.amsl.com> <6A04AE1F-F538-40CD-BFB4-3452B50C7F9D@cisco.com> <9A6B372F-2FD1-409A-BF3B-AFF48D1E74B4@cisco.com> <F5EE16C2-B4E3-4B0A-835F-EB729900323E@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F5EE16C2-B4E3-4B0A-835F-EB729900323E@cisco.com>
User-Agent: NeoMutt/20171215
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/oRIGMZDfLUwVwKmt6c9bsAi9hr0>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-bfd-yang-09
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Mar 2018 14:58:50 -0000

On Sun, Mar 04, 2018 at 02:12:30PM +0000, Reshad Rahman (rrahman) wrote:
> 
> We have made the changes in revs 10 and 11 to address your comments . The exception is module ietf-bfd-types which did not get renamed per reason below.
>

Hi,

here is my re-review of draft-ietf-bfd-yang. I think the document has
significantly improved since the -09 version, the authors have done an
excellent job to improve the document quality.

I have mostly a few minor mostly editorial issues left, except the
first one, which concerns the schema mount use case.

- Thanks for clarifying that the modules can be used on standalone
  devices. The new text is helpful.

  For the LNE and NI use cases, does it make sense to detail the mount
  points that are used? My understanding is that schema mount requires
  that mount points are identified with a "mount-point" extension
  statement, i.e., you can't mount at arbitrary places in the
  hierarchy but only at places that have been designated as mount
  points.

  That all said, since your YANG modules are basically augmenting
  other YANG modules that may be mounted, you do not seem to need a
  separate schema mount. If my understanding is correct, then here is
  a starting point for making this clearer:

  OLD

    When used at the network device level, the BFD YANG model is used
    "as-is".  When the BFD model is to be used in a Logical Network
    Element or in a Network Instance, the approach taken is to do a
    schema-mount (see Schema Mount [I-D.ietf-netmod-schema-mount]) of the
    BFD model in the appropriate location.  For example, if an
    implementation supports BFD IP multihop in network instances, the
    implementation would do schema-mount of the BFD IP multihop model in
    a mount-point which resides in a network instance.

  NEW

    When used at the network device level, the BFD YANG model are used
    "as-is".  When the BFD YANG model is used in a Logical Network
    Element or in a Network Instance, then the BFD YANG model augments
    the mounted routing model for the Logical Network Element or the
    Network Instance.

  Note that with this change, you also do not need a reference to
  schema mount.
  
- Since the different use cases (device, LNE, NI) are discussed right
  at the beginning of Section 2, it seems the following statements in
  Sections 2.5, 2.6, 2.7, 2.8, 2.9 are not really needed:

                                   The "bfd" node under control-plane-
   protocol can be used in a network device (top-level), or mounted in
   an LNE or in a network instance.

                                            The "ip-sh" node can be used
   in a network device (top-level), or mounted in an LNE or in a network
   instance.

                                                            The "ip-mh"
   node can be used in a network device (top-level), or mounted in an
   LNE or in a network instance.

                              The "lag" node can be used in a network
   device (top-level), or mounted in an LNE or in a network instance.

                                                             The "mpls"
   node can be used in a network device (top-level), or mounted in an
   LNE or in a network instance.

- The text at the beginning of Section 2.13 should also mention RFC
  8177 since you are importing it.

- It might be useful to give more explicit instructions to IANA. I
  assume you want IANA to update the iana-bfd-types module whenever
  changes are made to the "BFD Diagnostic Codes" registry and "BFD
  Authentication Types" registries. Giving clear instructions what
  IANA is expected to do and when is better than a soft statement such
  as "intended to reflect". But IANA is going to ask questions about
  this anyway during their review I assume.

- The feature definitions in ietf-bfd-types have text of the form "as
  defined in RFC 5880" and perhaps it makes sense to add reference
  statements to these feature definitions. There are also a number of
  identities that say "as per RFC 588X" where perhaps reference
  statements should be added.

- The text at the beginning of Section 2.13 should also	mention	RFC
  6991 since you are importing it. And you are also importing from
  RFC XXXX (the routing model).

- The text at the beginning of Section 2.16 should also mention
  that you import from RFC XXXX (the routing model).

- The text at the beginning of Section 2.17 should also mention that
  you import from RFC 6991 and from RFC XXXX (the routing model).

- The text at the beginning of Section 2.18 should also mention that
  you import from RFC XXXX (the routing model).

- The text at the beginning of Section 2.19 should also mention that
  you import from RFC XXXX (the routing model).

- I have not validated the examples - I hope the authors have done so.
  They look more plausible than in the previous version I reviewed.

/js

-- 
Juergen Schoenwaelder           Jacobs University Bremen gGmbH
Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>