Re: [yang-doctors] Yangdoctors early review of draft-ietf-mpls-base-yang-10

Tarek Saad <tsaad.net@gmail.com> Wed, 23 October 2019 18:46 UTC

Return-Path: <tsaad.net@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 98B5E120D61; Wed, 23 Oct 2019 11:46:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5jgReG5ygeIK; Wed, 23 Oct 2019 11:46:27 -0700 (PDT)
Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 132EF120D57; Wed, 23 Oct 2019 11:46:24 -0700 (PDT)
Received: by mail-wm1-x336.google.com with SMTP id f22so44323wmc.2; Wed, 23 Oct 2019 11:46:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :content-transfer-encoding:mime-version; bh=KHJm6gsfIrGv+oJROU4YwhLVdWNUZNv6QMmt0uSwWUk=; b=VQQMNl/tmNXddEKcSWHiNc4Yqr7OqWufrKzMI3AAzgaKd7Q3T1JnYX5mnZCH69uRQ7 85Xs8orjmWGvjln5y3ThOHvKYmCI4Cgoh1mBbLC+qnFqfTGImgBzjQOR6ZmOL1MjQ1sL 3EkBlNIFGue+9OWQbhrPCCGWtB5LvvU/AyWkGGwa0wY46YulvK2hufoc0N+DC3O89CG/ 1CDJlNW8jlgIrGirgz+p+wJMfMgTe6ilX0zZaDRmI1lOTHdID7ughbBOi4wWHImnp7SQ Bze1Xt2Y8W4sWuDG9tiBEW+jzsTaje+viyepoF4niTi3fgBQP5qHHkoKxy4tAk3w2LnF CnOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:content-transfer-encoding:mime-version; bh=KHJm6gsfIrGv+oJROU4YwhLVdWNUZNv6QMmt0uSwWUk=; b=O8i+AqonyPBOcKGmlTlUijwI6WPHd9LUZGJmztkonCMGEIoNqCT9OU3V6B+RQ9D9tg +JqIPTxhViRTBs2AEw9BdAaAjEvydb4QpuMOpiYmK4VrU3PfISHTDFRU9fGj52F4kt0o vKP0lf4e6L4WR2d8ju/Pt0exMrkOdavHXSkpoXOKttcIHDTRIZvHZj/zSzaoPeaXXuil MaZZuo8iiOoBl5uXEOxhbjNHReu2UodAci/CzmvusV9Ar3rPJhrzcPQOduTxPw1o8Zv7 vkWtpg6hT7uH2Y3jvwi173T39r7A9WmAWOg5vot/yuNj2nwMAosR47j3or9M0DHDkUjV yg9A==
X-Gm-Message-State: APjAAAVaceRBxCX7mt6PSNlY9R8KL0GiOsOeq0m+7lJdHttF8bWq8Vh+ mpWlBugLZagfpt/BLfsmmQy4IVhz
X-Google-Smtp-Source: APXvYqxl2o5enN4m5FP4uW5T2WrDJ7Lqga/185OYUm6FLxVcqIjZ86ZO3mUoAt1BkxJqzJd+EIWOxA==
X-Received: by 2002:a1c:544e:: with SMTP id p14mr1191523wmi.17.1571856382497; Wed, 23 Oct 2019 11:46:22 -0700 (PDT)
Received: from DM6PR19MB3689.namprd19.prod.outlook.com ([2603:1036:301:21db::5]) by smtp.gmail.com with ESMTPSA id 65sm21386702wrs.9.2019.10.23.11.46.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Oct 2019 11:46:21 -0700 (PDT)
From: Tarek Saad <tsaad.net@gmail.com>
To: Ebben Aries <exa@arrcus.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "mpls@ietf.org" <mpls@ietf.org>, "draft-ietf-mpls-base-yang.all@ietf.org" <draft-ietf-mpls-base-yang.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-mpls-base-yang-10
Thread-Index: ATkwNDk0XwiEpmF5LrvZdM9A3YooWzAyQUMztzGp1Iw=
X-MS-Exchange-MessageSentRepresentingType: 1
Date: Wed, 23 Oct 2019 18:46:19 +0000
Message-ID: <DM6PR19MB3689566DE34C337886D046E8FC6B0@DM6PR19MB3689.namprd19.prod.outlook.com>
References: <156615954036.3697.1825462750505422399@ietfa.amsl.com> <BYAPR19MB3415533CD4DEA0AEB56022DBFCB00@BYAPR19MB3415.namprd19.prod.outlook.com>
In-Reply-To: <BYAPR19MB3415533CD4DEA0AEB56022DBFCB00@BYAPR19MB3415.namprd19.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-Exchange-Organization-SCL: -1
X-MS-TNEF-Correlator:
X-MS-Exchange-Organization-RecordReviewCfmType: 0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/oaL_pZOV0ia7ikf0LeLvstgIHQc>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-mpls-base-yang-10
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Oct 2019 18:46:30 -0000

Hi Ebben,

Can you please advise whether you are OK with revision 11 which addresses your review comments?
https://tools.ietf.org/html/draft-ietf-mpls-base-yang-11

Regards,
Tarek

On 9/12/19, 9:18 AM, "Tarek Saad" <tsaad.net@gmail.com>; wrote:

    Hi Ebben,
    
    Thanks for your review and comments. We have uploaded a new revision of the document that addresses the comments.
    Inline for more details.
    
    On 8/18/19, 4:19 PM, "Ebben Aries via Datatracker" <noreply@ietf.org>; wrote:
    
        Reviewer: Ebben Aries
        Review result: On the Right Track
        
        1 module in this draft:
        - ietf-mpls@2019-02-24.yang
        
        No YANG compiler errors or warnings (pyang 2.0.1, yanglint 1.1.40, confdc 6.6.3)
        
        Module ietf-mpls@2019-02-24.yang:
        --------------------------------------------------
        - Remove WG Chairs from contact information per
          https://tools.ietf.org/html/rfc8407#appendix-B
    [TS]: done.
    
        - 'ietf-interfaces' import should reference RFC8343 rather
    [TS]: updated.
    
        - Must clause for start/end-label is incorrect.  Would suggest moving this
          must statement underneath the `leaf end-label` as well:
        
          e.g.
        
          leaf end-label {
              type rt-types:mpls-label;
              must '. >= ../start-label' {
                  error-message
                    "The end-label must be greater than or equal " +
                    "to start-label";
              }
              description "Label-block end";
          }
    [TS]: OK, I moved this check to under end-label. I added similar check for start-label too.
    
        - Use of 'state' container under '/routing/mpls/label-blocks/label-block/state'
          These nodes could sit as r/o nodes by the looks of it directly under the
          label-block list.  In addition, do these nodes need '-count' suffixes?
          Should they rather be of type `yang:counter32`?
    [TS]: removed the 'state' container and updated to directly go under list. Also changed to type to yang:counter32.
    
          See: https://github.com/netmod-wg/FAQ/wiki/NMDA-Modelling-FAQ
        - Is there any intention to define any surrounding features?
    [TS]: updated.
        
        General comments/minor nits on the draft/modules:
        --------------------------------------------------
        - Section 1: s/feauture/feature/
        - Section 2.1: s/the the/the/
        - Section 2.1: 'labeled' vs. 'labelled'
        - Section 2.4: s/followinig/following/
        - Module line 354/367: This is for the 'active-route' action statement rather
        
     [TS]: addressed the typos, thanks.
    
    Regards,
    Tarek (for authors)