Re: [yang-doctors] [I2nsf] Need YANG Doctor reviewing the YANG module of draft-ietf-i2nsf-sdn-ipsec-flow-protection which I2NSF is about to call WGLC

Yoav Nir <ynir.ietf@gmail.com> Fri, 05 April 2019 18:13 UTC

Return-Path: <ynir.ietf@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9BA3012008D; Fri, 5 Apr 2019 11:13:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.998
X-Spam-Level:
X-Spam-Status: No, score=-0.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2E_2cu84Np0e; Fri, 5 Apr 2019 11:13:34 -0700 (PDT)
Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 21D9F12000F; Fri, 5 Apr 2019 11:13:34 -0700 (PDT)
Received: by mail-wm1-x334.google.com with SMTP id y197so8173163wmd.0; Fri, 05 Apr 2019 11:13:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=iA2RClccBsB7vRCQW+k4GpUVMnzGXw80OHRsF+1iGQc=; b=FGvg44g5+e2fgfiztKu7MlWb/mHRavBe9LbR6vJqfID+V+H35zwL7mDckmv9evazi1 QgTzZaWvMtVbdK4GHzyPUrDrnWDLmB4v1YV8e2dgZXEeEusyS28SQ4zUbnW0/FwPS7F8 yg8EDJtVu5J7BS3myz2yVP0vm4xTlt/BTkADhL8qvFCvySoyCULIJ1JkHWnjsM0k4Gct 7/hPGyVuIuTjKLdT4P8qrf+oRDnxB/32fZqEaAwo4DS8LNqmz0Q4eIxNLX6wh7dCy/fh Txsuk8S/Tq0m0dfs/FlUJ65Zc78y/Y7GYDlRQQ22xBI0W/GZ1NCmekYHSWTDCXhf3/ez +1Ow==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=iA2RClccBsB7vRCQW+k4GpUVMnzGXw80OHRsF+1iGQc=; b=kV6uH68Mb/jobn2IQ4zYpqV8rcq785MrAFbQnpwT3qMDEou9fwoqQkhMUAT3sBh7oU 3eKMIuj0GozXHhHV5SgfSvxvadEBQYNXzl6UeKgu2ZGYBH+YLVWSUDRqqY8sNBDd8+Cb pSXsdGOxNXRAINr5uSCFK3S+SWHzni5dk50FuO2AIVAabQ9CU6N+JTlKbDBFIaea3ngs jcpMgdSYxc7OUOd0Rtj3hLPYtvEzR7aQKcdfySAxX2zpATaDqrB+Pbcgs5m0fadH63DO ZSd4/FXrkwnP4Ti0lZqZwlVcK0UFbmTIhN7/U34xj1Np5hdd/EGEOphNnuQ30MDTuhCj 9D6Q==
X-Gm-Message-State: APjAAAVzVu8LEzJcdbQWtuc1teJ3pXc7xihhvkJne4jxgk1PqUo1fi0H AfplgTV7W71t70ovidgdHso=
X-Google-Smtp-Source: APXvYqwfzzYuK4+gOg81DRYWS5bpRTmVDHlgbVn9jyl/L0YIs6x9/BrP8ICOhJYnXvV0AEX7Pi8ZaQ==
X-Received: by 2002:a1c:d106:: with SMTP id i6mr8473082wmg.134.1554488012561; Fri, 05 Apr 2019 11:13:32 -0700 (PDT)
Received: from [192.168.1.13] ([46.120.57.147]) by smtp.gmail.com with ESMTPSA id r30sm64805047wrr.46.2019.04.05.11.13.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 11:13:31 -0700 (PDT)
From: Yoav Nir <ynir.ietf@gmail.com>
Message-Id: <80347D5B-C4DB-4F0C-BD73-A927585442BF@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_BD666911-CFBF-42DF-9C8C-9F95D27A9FFB"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Date: Fri, 05 Apr 2019 21:13:29 +0300
In-Reply-To: <CABCOCHRf3iGUt9wb3htpDYGJ+pAKErvq8OrozndgELUVKYT4Kg@mail.gmail.com>
Cc: Mahesh Jethanandani <mjethanandani@gmail.com>, "i2nsf@ietf.org" <i2nsf@ietf.org>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, Linda Dunbar <linda.dunbar@huawei.com>
To: Andy Bierman <andy@yumaworks.com>
References: <4A95BA014132FF49AE685FAB4B9F17F66B363EB2@sjceml521-mbs.china.huawei.com> <420D3E9A-9E3C-4575-9C92-200CAA0B868C@gmail.com> <CABCOCHRf3iGUt9wb3htpDYGJ+pAKErvq8OrozndgELUVKYT4Kg@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.104.8)
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/qpnQsmP2eizc6qtRqvp-8lyWVuo>
Subject: Re: [yang-doctors] [I2nsf] Need YANG Doctor reviewing the YANG module of draft-ietf-i2nsf-sdn-ipsec-flow-protection which I2NSF is about to call WGLC
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Apr 2019 18:13:37 -0000

At this point I’m wondering if it would not be a better strategy to avoid all enumerations of algorithms, whether they are spelled out or imported from draft-ietf-netconf-crypto-types, and instead use the numbers from the IANA registry for IPsec.

That does not help us deprecate old algorithms, but it solves the other issue, which is what to do when a new algorithm is added to IPsec. We don’t want to have to publish a new i2nsf document whenever that happens, and if the algorithm identifier is just a number, new values can be added by IANA.

Yoav

> On 5 Apr 2019, at 20:42, Andy Bierman <andy@yumaworks.com> wrote:
> 
> Hi,
> 
> I think conformance for identities is handled very poorly in YANG.
> There is an if-feature-stmt allowed inside an identity in YANG 1.1.
> This implies that any identity without if-feature is mandatory-to-implement.
> 
> If the identities are in a separate module, the server can list it as an imported module,
> which tells the client the server does not implement any of the identities.
> 
> There is no standard way for the server to inform the client which identities it supports
> for a given identityref data node.
> 
> The common implementation strategy is to completely ignore YANG conformance for identities
> (as Mahesh explained). You just try setting the leaf and see if the server accepts it.
> 
> Andy
> 
> 
> On Fri, Apr 5, 2019 at 10:33 AM Mahesh Jethanandani <mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>> wrote:
> Hi Linda,
> 
> 
>> On Apr 5, 2019, at 9:51 AM, Linda Dunbar <linda.dunbar@huawei.com <mailto:linda.dunbar@huawei..com>> wrote:
>> 
>> Dear YANG Doctor:
>>  
>> We need your help in reviewing the YANG model in draft-ietf-i2nsf-sdn-ipsec-flow-protection which I2NSF WG is about to call WGLC.
>>  
>> In particular, we need your advice on the following issue:
>>  
>> draft-ietf-i2nsf-sdn-ipsec-flow-protection-04 imports from draft-ietf-netconf-crypto-types, which appears to be a generic list of algorithms.
>> The problem is that the list in draft-ietf-netconf-crypto-types could contain algorithms that are not suitable for IPsec (such as secp192r1 for key agreement), and right now it seems to lack some older algorithms that have fallen out of fashion (3DES) but is still needed in IPsec.  
> 
> All the algorithms in draft-ietf-netconf-crypto-types are defined as identities. If you do not find the algorithm you are looking for in the list of defined algorithms, you can go ahead and define your own in your own draft, using the same base identity from the ietf-crypto-types module.
> 
>>  
>>  
>> Questions to the YANG Doctor:
>> 1.       Is it better to list the IPsec specific algorithms in draft-ietf-i2nsf-sdn-ipsec-flow-protection (which is a subset of draft-ietf-netconf-crypto-types? Or to import all crypto algorithms many of which are not relevant to IPsec? What is the common practice? 
> 
> Importing ietf-crypto-types does not mean you have to implement every algorithm listed in the module. You can import the module and chose to implement the algorithms you want to implement, including defining any new ones.
> 
>> 2.      If we do import from draft-ietf-netconf-crypto-types, does it mean draft-ietf-i2nsf-sdn-ipsec-flow-protection cannot be published until draft-ietf-netconf-crypto-types is published?
> 
> Yes. The i2nsf draft will hit the state of MISSREF in the RFC Editor queue. But that should not prevent anyone from starting implementation of the module. As a side note, the NETCONF WG is planning on sending the crypto-types draft to IESG shortly. What you do not want is to duplicate the definition of the algorithms in your own draft.
> 
> HTH.
> 
>>  
>>  
>> Thank you very much, 
>>  
>> Linda & Yoav
>>  
>> _______________________________________________
>> yang-doctors mailing list
>> yang-doctors@ietf.org <mailto:yang-doctors@ietf..org>
>> https://www.ietf.org/mailman/listinfo/yang-doctors <https://www.ietf.org/mailman/listinfo/yang-doctors>
> Mahesh Jethanandani
> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
> 
> 
> 
> _______________________________________________
> yang-doctors mailing list
> yang-doctors@ietf.org <mailto:yang-doctors@ietf.org>
> https://www.ietf.org/mailman/listinfo/yang-doctors <https://www.ietf.org/mailman/listinfo/yang-doctors>
> _______________________________________________
> I2nsf mailing list
> I2nsf@ietf.org <mailto:I2nsf@ietf.org>
> https://www.ietf.org/mailman/listinfo/i2nsf <https://www.ietf.org/mailman/listinfo/i2nsf>