[yang-doctors] Yangdoctors last call review of draft-ietf-pim-igmp-mld-snooping-yang-19
Reshad Rahman via Datatracker <noreply@ietf.org> Thu, 30 September 2021 03:08 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: yang-doctors@ietf.org
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 0E5333A0FCC; Wed, 29 Sep 2021 20:08:54 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Reshad Rahman via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
Cc: draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org, last-call@ietf.org, pim@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.38.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <163297133399.7456.4753723321157921343@ietfa.amsl.com>
Reply-To: Reshad Rahman <reshad@yahoo.com>
Date: Wed, 29 Sep 2021 20:08:54 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/vgK6E1iAC5JG1yHIzSFZ53_jgsg>
Subject: [yang-doctors] Yangdoctors last call review of draft-ietf-pim-igmp-mld-snooping-yang-19
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Sep 2021 03:08:55 -0000
Reviewer: Reshad Rahman Review result: Ready with Nits This is my 3rd review of the document. While I have focused on changes done since my last review, some comments apply to parts of the YANG model which hasn't changed recently. Main comments ============= - Feature immediate-leave mentions “fast leave” in the description. RFC3376 mentions fast leave but not immediate leave. Should the feature, and the leaf node which depends on it, be renamed to fast-leave? - Leaf send-query, description says that it cooperates with parameter querier-source. I believe there should be enforcement that send-query can only be set if querier-source is also set (must statement)? Also querier-source in IGMP mentions VLAN, no such mention in MLD, is that correct? Questions ======== - Feature static-l2-multicast-group. The description mentions L2 multicast static-group. Is it a static multicast group or a multicast static group? I believe it’s the former and the description should be changed? - igmp-version and mld-version are both uint8 with a range (1..3 and 1..2). If we get a new version someday, the range will have to be changed. I don’t recall if this was brought up before. Another option is to use an identity. I realize we don’t spin out a new version frequently so this may not be an issue. And probably with a new version other changes would be needed anyway… - Last-reporter is present under the group and also under each source entry. Is the one under the group the last host from all sources? - Leaf node require-router-alert. What happens if it’s set to true and the IP hdr does not contain RA? Consider updating description and/or adding a reference. Minor ===== - Typo in bridge-router-interface: dynamicly. - No need to mention the leaf name in description, e.g. in l2-service-type - Leaf “host-address”, rename to “address” since the list is called host (no need to duplicate host). Regards, Reshad.
- [yang-doctors] Yangdoctors last call review of dr… Reshad Rahman via Datatracker
- Re: [yang-doctors] Yangdoctors last call review o… Hongji Zhao
- Re: [yang-doctors] Yangdoctors last call review o… Hongji Zhao
- Re: [yang-doctors] Yangdoctors last call review o… Reshad Rahman
- Re: [yang-doctors] Yangdoctors last call review o… Hongji Zhao
- Re: [yang-doctors] Yangdoctors last call review o… Reshad Rahman