Re: [yang-doctors] [netconf] Require-instance problem [was: RE: WGLC: draft-ietf-netconf-notification-capabilities-11]

Hi Balasz,

Dne 13. 03. 20 v 10:40 Balázs Lengyel napsal(a):
> Hello Michal,
> While the Require-instance issue may or may not be a problem, it is not caused by my netconf-notification-capabilities draft. I hope we agree on this.
>
> About the require-instance problem:
> Not mentioning derived types for require-instance in 9.9.3 can be intentional or an omission. If I just strictly read the text:
>> The "require-instance" statement, which is a substatement to the
>>    "type" statement, MAY be present if the type is "instance-identifier"
>>    or "leafref".
> This says that the require-instance is allowed under type; full stop.

but there is no full stop, the sentence continues, please read it till
its end, it specifies conditions when the substatement can be used. Also
please compare with the text in 9.4.4 (length) or 9.2.4 (range) where
the derived types are explicitly mentioned in case the statement is
meant to be allowed there. The specification is not supposed to
explicitly state where it IS NOT allowed, instead it specifies where it
IS allowed. By your interpretation, require-instance would be allowed
even in integer types since it is not explicitly denied.

Regards,
Radek

>  Intentions about the pattern of the text are speculation. The text says it MAY be there. So unless an errata is filed, it is allowed. IMHO if that is the intention we would need an explicit sentence like:
> "Usage of require-instance is not allowed for derived types."
> I don't have a strict view on which was the intention (maybe Martin has) but the text is unambiguous to me.
> Regards Balazs
>
> -----Original Message-----
> From: Michal Vaško <mvasko@cesnet.cz> 
> Sent: 2020. március 13., péntek 10:04
> To: Balázs Lengyel <balazs.lengyel@ericsson.com>
> Cc: Mahesh Jethanandani <mjethanandani@gmail.com>; netconf@ietf.org; yang-doctors@ietf.org
> Subject: Re: [netconf] Require-instance problem [was: RE: WGLC: draft-ietf-netconf-notification-capabilities-11]
>
> Hi Balazs,
> just to explain libyang behavior, if you look at (pattern <https://tools.ietf.org/html/rfc7950#section-9.4.5> ) definition, there is explicitly mentioned that it can appear in derived types. There is no such wording for (require-instance <https://tools.ietf.org/html/rfc7950#section-9..9.3> ), it mentions only "instance-identifier" and "leafref" types.
>
> Also, libyang does not allow loading invalid schemas so even if you only import it, it will fail.
>
> Regards,
> Michal
>
> On Friday, March 13, 2020 09:55 CET, Balázs Lengyel <balazs.lengyel=40ericsson.com@dmarc.ietf.org> wrote: 
>  
>> Hello Mahesh,
>>
>> Even if there is some problem with ietf-subscribed-notification how does that effect the validity of instance data for ietf-system-capabilities or ietf-notification-capabilities ? I only import a type and a feature from Yangpush (which imports subscribed notification). These seem nothing to do with require-instance.
>>
>>  
>>
>> Aside from my draft:
>>
>> I do not understand some of libyangs statements:  
>>
>> “as it turned out (ref <https://tools.ietf.org/html/rfc7950#section-9.9.3> ), you cannot put require-instance into a derived type”. 
>>
>> Checking ref I did not find why you cannot put require instance into a typedef.
>>
>>  
>>
>> By the way I have bigger issues with YangValidator. When I load ietf-system-capabilities@2020-03-08 into it I get 
>>
>>  
>>
>> RecursionError at /yangvalidator/validator
>>
>> maximum recursion depth exceeded
>>
>>
>> Request Method:
>>
>> POST
>>
>>
>> Request URL:
>>
>> https://protect2.fireeye.com/v1/url?k=6cc7e6c7-3013efa1-6cc7a65c-8610d8a762ca-0a278d65531d4f4f&q=1&e=b7200729-5cfb-4d52-b459-737457b266e0&u=http%3A%2F%2Fwww.yangvalidator.com%2Fyangvalidator%2Fvalidator
>>
>>
>> Django Version:
>>
>> 3.0.4
>>
>>
>> Exception Type:
>>
>> RecursionError
>>
>>
>> Exception Value:
>>
>> maximum recursion depth exceeded
>>
>>
>> Exception Location:
>>
>> /home/yang/yangvalidator/lib/python3.6/site-packages/pyang-2.1.1-py3.6.egg/pyang/statements.py in newf, line 42
>>
>>
>> Python Executable:
>>
>> /usr/sbin/uwsgi
>>
>>
>> Python Version:
>>
>> 3.6.10
>>
>>
>> Python Path:
>>
>> ['/home/yang/yangvalidator/lib/python3.6/site-packages/pyang-2.1.1-py3.6.egg/pyang/transforms',
>>
>>  
>>
>> Regards Balazs
>>
>>  
>>
>> From: Mahesh Jethanandani <mjethanandani@gmail.com> 
>> Sent: 2020. március 12., csütörtök 22:28
>> To: Balázs Lengyel <balazs.lengyel@ericsson.com>
>> Cc: Kent Watsen <kent+ietf@watsen.net>; netconf@ietf.org; yang-doctors@ietf.org
>> Subject: Re: [netconf] WGLC: draft-ietf-netconf-notification-capabilities-11
>>
>>  
>>
>> [Adding yang-doctors]
>>
>>  
>>
>> Hi Balazs,
>>
>>  
>>
>>  
>>
>> On Mar 10, 2020, at 2:06 AM, Balázs Lengyel <balazs.lengyel@ericsson.com <mailto:balazs.lengyel@ericsson.com> > wrote:
>>
>>  
>>
>> Finally, have all the examples in the appendix been validated?
>>
>> BALAZS: Yes, they have been loaded into a live Confd server.
>>
>>  
>>
>> I bring this up because I ran into issues when validating the https-notif model using ietf-subscribed-notification module, something that you also import. Here is what I see when I try to use yanglint to validate your example. In this case, I named your example as examples-notification-capabilities-1.xml.
>>
>>  
>>
>> bash-3.2$ yanglint -s -i -t auto -p /Volumes/External/git/iana/yang-parameters/ ietf-system-capabilities@2020-03-08.yang <mailto:ietf-system-capabilities@2020-03-08.yang>  ietf-notification-capabilities@2020-03-09.yang <mailto:ietf-notification-capabilities@2020-03-09.yang>  examples-notification-capabilities-1.xml 
>>
>> err : Invalid keyword "require-instance".
>>
>> err : Module "ietf-subscribed-notifications" parsing failed.
>>
>> err : Importing "ietf-subscribed-notifications" module into "ietf-yang-push" failed.
>>
>> err : Module "ietf-yang-push" parsing failed.
>>
>> err : Importing "ietf-yang-push" module into "ietf-notification-capabilities" failed.
>>
>> err : Module "ietf-notification-capabilities" parsing failed.
>>
>>  
>>
>> At first I thought the issue was with yanglint, because just like you I used confd and it did not complain. But folks over at libyang tell me that this was discussed as part of their issue  #881 <https://protect2.fireeye.com/v1/url?k=a6420c80-fa9605e6-a6424c1b-8610d8a762ca-d6cddc5edf1151a7&q=1&e=3cd8e8af-8aea-4f96-939b-8e1e455eac74&u=https%3A%2F%2Fgithub.com%2FCESNET%2Flibyang%2Fissues%2F881>  and the conclusion was that you cannot put require-instance in a derived type based on this <https://tools.ietf.org/html/rfc7950#section-9.9.3>  text.
>>
>>  
>>
>> Who is correct in their assertion, libyang or confd/RFC8639?
>>
>>  
>>
>> In case anyone is wondering which ietf-subsciribed-notifications module is being imported, here it is:
>>
>>  
>>
>> bash-3.2$ ls ..../iana/yang-parameters/ietf-subscribed-notifications@2019-09-09.yang <mailto:iana/yang-parameters/ietf-subscribed-notifications@2019-09-09.yang> 
>>
>>  
>>
>> Cheers.
>>
>>  
>>
>> BTW, even if I comment out the ‘require-instance’ statement, yanglint complains about other issues with ietf-subscribed-notifications, which I will bring up in a separate thread.
>>
>>  
>>
>> Mahesh Jethanandani
>>
>> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com> 
>>
>>  
>>
>>  
>>
>>  
>>
>  
>  
>
>
> _______________________________________________
> netconf mailing list
> netconf@ietf.org
> https://www.ietf.org/mailman/listinfo/netconf

Re: [yang-doctors] [netconf] Require-instance problem [was: RE: WGLC: draft-ietf-netconf-notification-capabilities-11]

Attachment: smime.p7s