Re: [yang-doctors] Yangdoctors last call review of draft-ietf-opsawg-tacacs-yang-03

["Wubo (lana)" <[e-mail]>]

Hi Lada,

Many thanks for the suggestion. Understood, will remove the "case".

Thanks,
Bo

-----邮件原件-----
发件人: Ladislav Lhotka [mailto:[e-mail]] 
发送时间: 2020年5月7日 14:56
收件人: Wubo (lana) <[e-mail]>; [e-mail]
抄送: [e-mail]; [e-mail]; [e-mail]
主题: Re: Yangdoctors last call review of draft-ietf-opsawg-tacacs-yang-03

"Wubo (lana)" <[e-mail]> writes:
>
> - The "case" statements in ietf-system-tacacsplus:tacacsplus/source-type are unnecessary because each contains only one leaf of the same name; I suggest to remove them.
> [Bo] I need to wait for the further guidance from WG. The "choice case" is added based on the email discussion of the WG, which provides some flexibility in specifying the IP address for server communication. Some vendors prefer IP addresses, and some vendors derive IP addresses through interfaces.

I am not suggesting to remove this choice, this is of course not YANG Doctor's business. My comment is related exclusively to YANG syntax: if you have a "case" statement containing only one data node, then the "case" statement can be omitted, see sec. 7.9.2 in RFC 7950. Such a shorthand is IMO preferable (less clutter), unless you want to leave the possibility of augmenting the case node later - I don't think though it is an option here.

Thanks, Lada

-- 
Ladislav Lhotka 
Head, CZ.NIC Labs
PGP Key ID: 0xB8F92B08A9F76C67