IETF Logo Mail Archive

Re: [yang-doctors] Yangdoctors last call review of draft-ietf-ospf-yang-23

"Acee Lindem (acee)" <acee@cisco.com> Mon, 29 July 2019 18:22 UTC

Return-Path: <acee@cisco.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A22DD120025; Mon, 29 Jul 2019 11:22:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=IYynxo/H; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=BqONBMW+
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Ww-YyqnXT5i; Mon, 29 Jul 2019 11:22:23 -0700 (PDT)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2C7041200B9; Mon, 29 Jul 2019 11:22:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2826; q=dns/txt; s=iport; t=1564424543; x=1565634143; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=hhRDKH/wPIEOiPwXyBB08sf+GonihGER6vtkzqkiIXQ=; b=IYynxo/HUhguEp8lGy2xFCwsloPxabvrMl7CC212n22uZRtCa+yxpSQw nJu+8x6GUGii9xEF6QPpE2QqXnhxDHpinjfacw/IyjEqrg026EiCdQ7oy 9HwepS73O7/wHX/T0RjJjGqM18YfPUEz8pm409cjsVBOaWUnq34pO8UPp E=;
IronPort-PHdr: 9a23:lffgmxKwZrocXeXpsdmcpTVXNCE6p7X5OBIU4ZM7irVIN76u5InmIFeCuKd2lFGcW4Ld5roEkOfQv636EU04qZea+DFKa5lQT1kAgMQSkRYnBZuMAkD2BPXrdCc9Ws9FUQwt8g==
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CyAAD+OD9d/49dJa1mGgEBAQEBAgEBAQEHAgEBAQGBZ4FEJCwDbVUgBAsqhB6DRwONAoI2l3iCUgNUCQEBAQwBASUIAgEBhEACF4JVIzgTAQMBAQQBAQIBBm2FHgyFSwIBAxIREQwBATcBDwIBCBoCJgICAjAVEAIEAQ0FIoMAAYFqAx0BAgyhSgKBOIhgcYEygnoBAQWBNgIBCwJAAYMGGIITAwaBDCiLYBeBf4E4DBOCTD6CYQIDAYFdgwsyggQijFuCI5t9CQKCGoZbiUaDcxQHmA6NO4dKkAwCBAIEBQIOAQEFgWchgVhwFRpLAYJBgkKDcYUUhT9ygSmNQwEB
X-IronPort-AV: E=Sophos;i="5.64,323,1559520000"; d="scan'208";a="519964355"
Received: from rcdn-core-7.cisco.com ([173.37.93.143]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 29 Jul 2019 18:22:21 +0000
Received: from XCH-ALN-014.cisco.com (xch-aln-014.cisco.com [173.36.7.24]) by rcdn-core-7.cisco.com (8.15.2/8.15.2) with ESMTPS id x6TIMLdJ032648 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 29 Jul 2019 18:22:21 GMT
Received: from xhs-aln-002.cisco.com (173.37.135.119) by XCH-ALN-014.cisco.com (173.36.7.24) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 29 Jul 2019 13:22:20 -0500
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 29 Jul 2019 13:22:20 -0500
Received: from NAM05-DM3-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 29 Jul 2019 14:22:20 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L7v14H6uIQuyCS0hRhmoK7TvH/3WKz4oV+HxAd9u1xGwCg0wB1vhiYEAF9qBiWBVbd5L1kbYRpEPQ0tXXTdRkFUqv7sJ8KsJ6QJiNk+hmPTzbnj/zJjeenUl2/akp3Af/4+3otZjTaz0WSQGy/gy23x7hrJJCHLax+j8NKhYHVNrATBrOYr+5HxESrI5aa55+QaeKmuNyyHavwwoyiTRBXecw1UcOJfj7skz45NcH7IaFcOPfDbE55E6XFcgwKil5aqz9cfgsY2rDV9cxTdQLAwqCHSCzhB2g/2DXg5JXXk8e2I+0u0pDJFMNTUHVePbEnQs44iW6bNvG7tN543whQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hhRDKH/wPIEOiPwXyBB08sf+GonihGER6vtkzqkiIXQ=; b=F0r2P7CqlXFtcOsfbwiWgcoq1K2VzL6Th+yqGim4oLKgJhmTyr5oWIIvogIMVEGfLN349ny9u/r506TbHeX5TCA7nipgsYieFMKdtYJ3lIK8PWISvJxfQLT2SQziS9cTC7WfYnz8A+V781dphxY4LAhFR6nPYGkgrZatkQGfMCwseTCkAJr93O8WXm6GPU+I5F7K1vkSZwI4k3wE0tBflvk6MbD+h8kj77FBJlUCOMdoH8gCAupZkwaHRTFia2v7W08iQML5KoE+iFMF9uv62Bu2WWK7CHa/JZCYli/5cm/pBsP3hlWo/09OiY/KjB2gFQ/SvgLwZuB2tE4KYvHKFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=cisco.com;dmarc=pass action=none header.from=cisco.com;dkim=pass header.d=cisco.com;arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hhRDKH/wPIEOiPwXyBB08sf+GonihGER6vtkzqkiIXQ=; b=BqONBMW++JNfvmR5KYGiF9rLDczThM+o87bkIdTU5UTgUb+D7FIcTslg3fyz/imNzSQs5ILcvKcknNOj00Rh6ndmudSr5Fws9kWNhEzQ5TpPSPDRLs2ERb18QsHq8Qb+6LlI8rmymEp5nCptgrFcIvDBbRy9etpp+OwhTx+NJZg=
Received: from MN2PR11MB4221.namprd11.prod.outlook.com (52.135.38.14) by MN2PR11MB3583.namprd11.prod.outlook.com (20.178.250.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.13; Mon, 29 Jul 2019 18:22:18 +0000
Received: from MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::859c:f271:3be2:74e0]) by MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::859c:f271:3be2:74e0%3]) with mapi id 15.20.2115.005; Mon, 29 Jul 2019 18:22:18 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Ladislav Lhotka <lhotka@nic.cz>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-ospf-yang.all@ietf.org" <draft-ietf-ospf-yang.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-ospf-yang-23
Thread-Index: AQHVQZvFpafhDuSoKESEgCz0g2QYUqbhrtYA
Date: Mon, 29 Jul 2019 18:22:18 +0000
Message-ID: <EB7BE103-2708-4EB9-AFDC-473DBCF7F9A7@cisco.com>
References: <156391650267.28055.13718648231048242876@ietfa.amsl.com>
In-Reply-To: <156391650267.28055.13718648231048242876@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=acee@cisco.com;
x-originating-ip: [2001:420:c0c4:1003::98]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 37dc1eb3-e2c9-42f1-a8b9-08d71451b0e9
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR11MB3583;
x-ms-traffictypediagnostic: MN2PR11MB3583:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <MN2PR11MB3583D3C43F603508DCDE9E11C2DD0@MN2PR11MB3583.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 01136D2D90
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(366004)(346002)(136003)(39860400002)(189003)(199004)(51914003)(66556008)(66446008)(33656002)(91956017)(76116006)(305945005)(66476007)(6512007)(6306002)(66946007)(6506007)(102836004)(316002)(4326008)(71190400001)(71200400001)(25786009)(256004)(6116002)(54906003)(66574012)(966005)(110136005)(446003)(68736007)(2616005)(7736002)(64756008)(36756003)(76176011)(81156014)(53936002)(486006)(8676002)(11346002)(229853002)(8936002)(6436002)(46003)(86362001)(6486002)(6246003)(478600001)(5660300002)(14454004)(186003)(2501003)(81166006)(476003)(99286004)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3583; H:MN2PR11MB4221.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 9rTjfdwBm81jKFuZmbrPZCTL1vAYLcmKZShbaQf3jHdWck9dHEyHW9EiT8GX0saB5H6IxtgAq1hpFmSl8+Cw10wiDJmMQ0ZctaG+TRm/NzKnmA6U/PXMiV+WD+E7e3AGxeLSmMAx/39qjpCUego4hWTA9t2u1GkbeuoGm2525Zk5yOhNNQSlBwnT587fDXteqHekp70VRPSKVEuA9+Q7v6HxE5J1ldEj8Zzmdr9FJpOOgWj8lnBwqE8UzKQCWt+dKD2DAxcKPyxyNIc8ze9eh/RZlYB8Tn+IoyNpt/R5Ba6RAnb0EKa0wVQ2dFlOJ3rw4auK00qDlaiE7D0mR0CIiAHMMHLZNWXHZqiQbth9476Tz9kabj8pRXFtGaGnENcG/s5lsVrXF8f3qF6KVCFf554PZ+UwIXFP3JJ5VdbVBFM=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A2CCF6DEA3959448851B3F2CF6436BC2@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 37dc1eb3-e2c9-42f1-a8b9-08d71451b0e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2019 18:22:18.8034 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: acee@cisco.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3583
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.24, xch-aln-014.cisco.com
X-Outbound-Node: rcdn-core-7.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/y3_3NUwv_0RuBZmMkj0_8j0A49Q>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-ospf-yang-23
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jul 2019 18:22:26 -0000

Hi Lada, 
Thanks for the review - all the nits will be fixed in the -24 version of the draft. 
Thanks,
Acee

On 7/23/19, 5:15 PM, "Ladislav Lhotka via Datatracker" <noreply@ietf.org> wrote:

    Reviewer: Ladislav Lhotka
    Review result: Ready with Nits
    
    I reviewed already revision 09 of this module [1]. All substantial
    objections and suggestions expressed in that review are addressed in
    revision 23 and I am satisfied with the result. I especially
    appreciate that descriptions were considerably expanded and references
    added in many places.
    
    I tested validity of the ietf-ospf module with pyang and Yangson
    tools, and found no issues. The comments below are non-substantial and
    do not affect practical use of the module.
    
    In summary, I think this YANG module and document is a remarkable
    piece of work demonstrating that it is possible to build quite complex
    vendor-neutral data model that can be used equally well with several
    router plaforms.
    
    Comments:
    
         - names of locally-defined identities as parameters of XPath
           functions derived-from and derived-from-or-self sometimes have
           the 'ospf:' prefix, sometimes don't. I suggest to be
           consistent, and the option without a prefix looks better to me.
    
         - RFC 8407 suggests this format of references to RFC:
           RFC XXXX: Title of the Document
           This draft uses a hyphen instead of a colon. I suggest to
           follow the 8407 convention so as to make parsing easier.
    
         - the title of Sec. 2.8 should be "OSPF Notifications" (plural
           and capitalization)
    
         - enumerations "nssa-translator-state-type" and
           "restart-status-type" define the value parameter
           for two of their enums but not for the third. This should be
           avoided.
    
    [1] https://datatracker.ietf.org/doc/review-ietf-ospf-yang-09-yangdoctors-lc-lhotka-2017-12-06/

v2.23.0 | Report a Bug | By Email