Re: [yang-doctors] [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-capability-data-model-04

"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Wed, 06 November 2019 01:57 UTC

Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 672F6120041; Tue, 5 Nov 2019 17:57:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.988
X-Spam-Level:
X-Spam-Status: No, score=-1.988 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HK_NAME_FM_MR_MRS=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ngg1aKyBGw8b; Tue, 5 Nov 2019 17:57:07 -0800 (PST)
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 31F6312009E; Tue, 5 Nov 2019 17:57:04 -0800 (PST)
Received: by mail-lf1-x136.google.com with SMTP id z12so16686698lfj.9; Tue, 05 Nov 2019 17:57:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DebWGymudrYwgt5VJy9o1jVWwHIj3FF6xGOKyu7gop4=; b=aWvyFMtdymcgcKrh3P7QqtcZYs0PQYZK//cixQoUbJ3+2YqAN7n+/kyNbtzozxM4OP Zcm1nRmHn+rToRwlpJHnzJsU2Ntl9KHlGK9NBtl2hlmelXbkXoPhjisKVI+nAugq0Ry2 7R/V3ta24KloEq2e+6g6oI3b7O5BtRuQxKN+Fgzai6m+QIXAWy6w3YJkoqzEjt+8AUhS H0jjz+B9L6Uv18GM7JoQMY23GkFrgavcQPRqs5Wk4eqHVmn7e5VpTSbBI9vpJ8gFq0tI E2tKGcVsMoaujKUQf9WC8BqGADUBd7cRooKazkQHiosg7ei+i0wPq4nx2SvfnPmFWIlU 1KjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DebWGymudrYwgt5VJy9o1jVWwHIj3FF6xGOKyu7gop4=; b=i725g7gEuSeiIDij5aqqVBTkE1pfNsnfGgT6bxuMEMaZz669hzkDDSjngbOJrkebos MD0XtafyhBd5uh2wLUjCvQ/tohTCg5vox2TBFC9YGYVeIVVm7Ml/Md4c8Z91icEbkkBw 2ZHejjaY0VNJgRPXhUB3/qjWl+xjiEK+rE1K2EEkWAlCnsOJ9tc40V+ubnCj8lPq779p SM2pMPBu1i/IgexGMWYL1i679HSKjyt5kNSBuOyPiq2btd0x4IjL1AWklUWbW419srxp z5OdoE9VRNxZHY4ZCs50VMv9VgvnGl13ptPw7msGrgfYUDt1woX8KrT7FSxOyU2MGyf4 hEcg==
X-Gm-Message-State: APjAAAUdZ3eH4Pwf8u18yFkr+QciIwyWM+VV43UP2N0uvHQOVCN0HTI8 o5YoPlkwnkbxbGY1+iBECnh/doVoAHyt09KQkwo=
X-Google-Smtp-Source: APXvYqyIuE4eMZdf4XoaT2Cfo/PJy08Y1FHtG3oFTSWa76LKbzSZ9ghbzOp7OgehxA54wdEhbGWVmziTCwoyu0ohRws=
X-Received: by 2002:a19:1ce:: with SMTP id 197mr22825073lfb.16.1573005422054; Tue, 05 Nov 2019 17:57:02 -0800 (PST)
MIME-Version: 1.0
References: <156323104862.27197.7523333169738579602@ietfa.amsl.com> <CAPK2DexfAtNCx5SfG6tjgVjbWc0Bo5z_uviYD58exUxRa08h=A@mail.gmail.com>
In-Reply-To: <CAPK2DexfAtNCx5SfG6tjgVjbWc0Bo5z_uviYD58exUxRa08h=A@mail.gmail.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Wed, 6 Nov 2019 10:56:26 +0900
Message-ID: <CAPK2Deym+xgmjPBgUiiJydWT2ETmXpQ-0OU--L4qQcDYvoh+xg@mail.gmail.com>
To: Carl Moberg <calle@tail-f.com>
Cc: YANG Doctors <yang-doctors@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>, draft-ietf-i2nsf-capability-data-model.all@ietf.org, skku-iotlab-members@googlegroups.com, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/alternative; boundary="0000000000006951ec0596a3dd65"
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/ySv0HKPpW7-8g75B2p2W4aILz6o>
Subject: Re: [yang-doctors] [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-capability-data-model-04
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2019 01:57:12 -0000

Hi Carl,
I believe that I have addressed your comments on I2NSF Capability Data
Model:
https://tools.ietf.org/html/draft-ietf-i2nsf-capability-data-model-05

If you are satisfied with the revision, could you update the Review result
in the following page?
https://datatracker.ietf.org/doc/review-ietf-i2nsf-capability-data-model-04-yangdoctors-lc-moberg-2019-07-15/


Thanks.

Best Regards,
Paul

On Thu, Jul 25, 2019 at 11:29 PM Mr. Jaehoon Paul Jeong <
jaehoon.paul@gmail.com>; wrote:

> Hi Carl,
> Here is the revision letter for the revised draft, reflecting your
> comments along with the revised draft:
> https://tools.ietf.org/html/draft-ietf-i2nsf-capability-data-model-05
>
> This revision letter first addresses the comments from Acee and then
> addresses your comments from page 6.
>
> If you have further comments and questions, please let me know.
>
> Thanks.
>
> Best Regards,
> Paul
>
> On Mon, Jul 15, 2019 at 6:50 PM Carl Moberg via Datatracker <
> noreply@ietf.org>; wrote:
>
>> Reviewer: Carl Moberg
>> Review result: Almost Ready
>>
>> This is my review of the ietf-i2nsf-capability@2019-03-28.yang module as
>> part
>> of draft-ietf-i2nsf-capability-data-model-04.
>>
>> The module cleanly passes validation (i.e. 'pyang --ietf') and I have
>> been able
>> to load it into a NETCONF server and done basic operations on it (add,
>> query
>> for and remove capabilties).
>>
>> I have one high-level concern and a couple of nits.
>>
>> This document defines "a YANG data model for capabilities of various
>> Network
>> Security Functions (NSFs)". After my in initial reading of the draft and
>> I2RS
>> background material I found it hard to understand which of the components
>> in
>> the I2RS reference architecture that would implement the YANG module (i.e.
>> provide NETCONF or RESTCONF protocol implementations). The draft says the
>> following:
>>
>> """
>>    This document provides a data model using YANG [RFC6020][RFC7950]
>>    that defines the capabilities of NSFs to centrally manage
>>    capabilities of those security devices.  The security devices can
>>    register their own capabilities into Network Operator Management
>>    (Mgmt) Systems (i.e., Security Controllers) with this YANG data model
>>    through the registration interface [RFC8329].
>> """
>>
>> This seems to point in the direction of the 'Network Operator Managemen
>> (Mgmt)
>> Systems' as the location of the YANG datastore, i.e. where this module
>> would be
>> implemented.
>>
>> My main question then becomes; given the fact that the top-level element
>> of the
>> data model is a container ('nsf') with a set of leaf-lists and containers
>> under
>> it, this model seems to only allow for the registration of one (1) single
>> NSF.
>> This seems to be also supported by the language of the description clauses
>> referencing "network service function" in singular.
>>
>> I would intuitively expect such a registry to be able to store the
>> capabilities
>> of a multitude of NSFs. I would appreciate if the authors could clarify
>> the
>> intent and expected usage of the model based on this question.
>>
>> Given my initial struggles I would suggest adding clearer upfront
>> language on
>> the location of the module and the addition of usage examples of e.g. NSFs
>> registering capability instances to registry. (See
>> https://tools.ietf.org/html/rfc8407#section-3.12). I believe that would
>> provide
>> additional and helpful context to the usage of the model.
>>
>> The following drafts are referenced in 'reference' and 'description'
>> fields in
>> the YANG module, but are missing from the Informative References section
>> of the
>> draft. (See https://tools.ietf.org/html/rfc8407#appendix-A.) -
>> draft-hong-i2nsf-nsf-monitoring-data-model-06 -
>> draft-ietf-i2nsf-capability-04
>> - draft-dong-i2nsf-asf-config-01
>>
>> The modules consistently seem to spell out 'capabilities', but shorten
>> 'capability' to 'capa', e.g.:
>>
>>      +--rw condition-capabilities
>>      |  +--rw generic-nsf-capabilities
>>      |  |  +--rw ipv4-capa*   identityref
>>
>> I would suggest following
>> https://tools.ietf.org/html/rfc8407#section-4.3.1 and
>> spell out 'capability' unless the authors are of the opinion that 'capa'
>> is a
>> well known abbreviation.
>>
>> Remove the following references (they're not used):
>>
>>    [RFC6087]  Bierman, A., "Guidelines for Authors and Reviewers of YANG
>>               Data Model Documents", RFC 6087, DOI 10.17487/RFC6087,
>>               January 2011, <https://www.rfc-editor.org/info/rfc6087>;.
>>
>>    [RFC6991]  Schoenwaelder, J., Ed., "Common YANG Data Types",
>>               RFC 6991, DOI 10.17487/RFC6991, July 2013,
>>               <https://www.rfc-editor.org/info/rfc6991>;.
>>
>> The format used to reference drafts vary in format, some use the
>> 'ietf-draft'
>> prefix in the reference (e.g.
>> '[draft-ietf-i2nsf-sdn-ipsec-flow-protection]')
>> and some don't (e.g. '[i2nsf-advanced-nsf-dm]')
>>
>> Oh. and it looks like the email address of the WG Chair (no less! :-) is
>> spelled incorrectly:
>>
>> OLD:
>>      WG Chair: Linda Dunbar
>>      <mailto:Linda.duhbar@huawei.com>
>>
>> NEW:
>>      WG Chair: Linda Dunbar
>>      <mailto:Linda.dunbar@huawei.com>
>>
>> _______________________________________________
>> I2nsf mailing list
>> I2nsf@ietf.org
>> https://www.ietf.org/mailman/listinfo/i2nsf
>>
>
>
> --
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> <http://cpslab.skku.edu/people-jaehoon-jeong.php>
>


-- 
===========================
Mr. Jaehoon (Paul) Jeong, Ph.D.
Associate Professor
Department of Software
Sungkyunkwan University
Office: +82-31-299-4957
Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
<http://cpslab.skku.edu/people-jaehoon-jeong.php>