IETF Logo Mail Archive

Re: [yang-doctors] Dealing with BFD RFC 9127 client-cfg-parms for PIM, OSPF, ISIS and other BFD clients on some platforms

Jeffrey Haas <jhaas@pfrc.org> Mon, 08 November 2021 18:19 UTC

Return-Path: <jhaas@pfrc.org>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4AB7D3A0D85; Mon, 8 Nov 2021 10:19:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.889
X-Spam-Level:
X-Spam-Status: No, score=-1.889 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kCjrqVqPTqME; Mon, 8 Nov 2021 10:19:19 -0800 (PST)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id C640F3A0D75; Mon, 8 Nov 2021 10:19:18 -0800 (PST)
Received: from smtpclient.apple (99-59-193-67.lightspeed.livnmi.sbcglobal.net [99.59.193.67]) by slice.pfrc.org (Postfix) with ESMTPSA id 4D0891E28D; Mon, 8 Nov 2021 13:19:17 -0500 (EST)
Content-Type: multipart/alternative; boundary="Apple-Mail=_98E3F848-8C50-4E20-8224-D7CAE24C7C1F"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
From: Jeffrey Haas <jhaas@pfrc.org>
In-Reply-To: <761418F7-F382-45EE-BD96-27317587C8EA@cisco.com>
Date: Mon, 8 Nov 2021 13:19:15 -0500
Cc: Mahesh Jethanandani <mjethanandani@gmail.com>, Reshad Rahman <reshad@yahoo.com>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "Rob Wilton (rwilton)" <rwilton=40cisco.com@dmarc.ietf.org>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
Message-Id: <7C1C266F-DD19-4274-8967-9A54B68C5F62@pfrc.org>
References: <316113928.668710.1636140378658@mail.yahoo.com> <E5128CE2-3EF9-4723-85C6-D5BE3E1E826A@gmail.com> <D018DDBB-08B3-4671-8EBF-5DAAC4D7528E@cisco.com> <BD68BAE3-7CA0-466B-A16A-E94FBAFD0710@gmail.com> <761418F7-F382-45EE-BD96-27317587C8EA@cisco.com>
To: "Acee Lindem (acee)" <acee@cisco.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/yc686eaMhI6pVyUtdhsVyzQBzEA>
Subject: Re: [yang-doctors] Dealing with BFD RFC 9127 client-cfg-parms for PIM, OSPF, ISIS and other BFD clients on some platforms
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Nov 2021 18:19:24 -0000


> On Nov 7, 2021, at 1:56 PM, Acee Lindem (acee) <acee@cisco.com> wrote:
> 
> 
> From: Mahesh Jethanandani <mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>>
> 
>> With Jeff’s diff, you’d still need two features. The base BFD feature which is in the protocol model and the bfd:client-cfg-parameters in the diff.
>  
> [mj] Acee, I was merely trying to point out to Reshad that we may not need a separate grouping with just the ‘enabled’ flag called ‘client-cfg-no-parms” or ‘client-cfg-enabled’ as the ‘enabled’ flag is needed by both modes of operation. I am fine with Jeff’s diffs.
>  
> But since you bring it up, how about moving the base BFD feature definition from the protocol drafts into the BFD types definition file, so there is one single way to enable the feature, rather than each protocol defining their own feature definition?
>  
> Sure.

The original diff I had sent out vs. the RFC was lost when the yang doctors were added.

Here's the diff again.  I think aside from adding appendix test and a little bit of word smithing, it's about all we need:

v2.8.7 | Report a Bug | By Email