[babel] Genart last call review of draft-ietf-babel-dtls-05

Dan Romascanu via Datatracker <noreply@ietf.org> Tue, 25 June 2019 16:50 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: babel@ietf.org
Delivered-To: babel@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 277A61208D8; Tue, 25 Jun 2019 09:50:11 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Dan Romascanu via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-babel-dtls.all@ietf.org, ietf@ietf.org, babel@ietf.org, dromasca@gmail.com
X-Test-IDTracker: no
X-IETF-IDTracker: 6.98.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Dan Romascanu <dromasca@gmail.com>
Message-ID: <156148141106.31261.11148445355862352575@ietfa.amsl.com>
Date: Tue, 25 Jun 2019 09:50:11 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/daQGamoPzl2AlkZzMFMnAgNua68>
Subject: [babel] Genart last call review of draft-ietf-babel-dtls-05
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jun 2019 16:50:15 -0000

Reviewer: Dan Romascanu
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-babel-dtls-05
Reviewer: Dan Romascanu
Review Date: 2019-06-25
IETF LC End Date: 2019-07-04
IESG Telechat date: Not scheduled for a telechat

Summary:

The document is Ready from a Gen-ART perspective. A couple of unclear /
redundant statements are mentioned in the 'nits/editorial comments' bullet
below.

Major issues:

Minor issues:

Nits/editorial comments:

1. In section 2.1:

> The default port
   for Babel over DTLS is registered with IANA as the "babel-dtls" port
   (UDP port TBD, see Section 4), and the port exchanging unencrypted
   Babel traffic is registered as the "babel" port (UDP port 6696).

A reference would be desirable here.

2. In section 2.4

> Nodes MUST silently ignore any unprotected
   packet sent over unicast.  When parsing an unprotected packet, a node
   MUST silently ignore all TLVs that are not of type Hello.  Nodes MUST
   also silently ignore any unprotected Hello with the Unicast flag set.

Is the last sentence necessary? Is this case not covered by the statement in
the first sentence?