[bess] Shepherd's review of draft-ietf-bess-rfc5549revision-01
"Bocci, Matthew (Nokia - GB)" <matthew.bocci@nokia.com> Mon, 10 February 2020 11:53 UTC
Return-Path: <matthew.bocci@nokia.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86D7B120154; Mon, 10 Feb 2020 03:53:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gLNzc8mgvnks; Mon, 10 Feb 2020 03:53:51 -0800 (PST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60123.outbound.protection.outlook.com [40.107.6.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 790CC1200A4; Mon, 10 Feb 2020 03:53:47 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i12yTk7zCe3gznG2stDZNVZyfOuR0AWlj07RB7SQUon4syJxJcPDkmcTkPVlYnOH3OPB9qP4Rg0Z76EgL+HKLWmT0bF4JFAOd7+xSYM7clwCJGqcOhfBc46Jzfm7hvC0JEpInihR2PUzJWbiWKSVpljtxDbaobitDJc9XoCdFYcu7VNjkj87s2Cek/7pjRYwEDzY8ktrcrsS+uyqn/+INolfyzYR70sB4RIEFRJp+Q7I6Mgqr5L87rBIhsxVRbfNzHaU4N2t6oQzZVyETGtjmarfUI+seoycFRW0uWlV/LeXDDZwvyBfffMWRYjMaAfa82mENzpDLskVPgbbioQD5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LSNZOI5GVm3bdLeThF7pgD3COorBX0MtlY0QC/+bkm8=; b=QrSwBw36kogsLgs+wUd+C8ul/cFfTqEl/KC7BoGvBqjfgsfXw/y44sUXYJOdvmXuH1kLROkbqMQwZRnhV6nhBb+hf4yGRt599fF+JjC9Dmgpp+YQQ4kEeMyTq8u+xSlrpwncZzjU72jU5L44RPX0QS23sAF0UvVVmWnmxJYb2XA+qkaN51Jr/VfrJ4dnHAKkBqxjkE7YbzpTY6fcEC4jnATH+8XIatPLboezYwEGhXG8WHGg8mEh0coBRhZ0nIqh5ta7ISSwQ/hQ/p3PkCVtxYLsj5UW2xvx1rlKImdwRQrqxnltU/WL6VZOJG+RW78aisgRErQ3woiPHYTJss8+bQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LSNZOI5GVm3bdLeThF7pgD3COorBX0MtlY0QC/+bkm8=; b=aJ0nE0r6PLWt192LhbE8jeTM8xrQdkO0A7jv2G0h5ULRBsbg3SHeWms8ikuiEXxfC0TV2zZkmk7CAh18kHeNeGOUK/ERvHQU72IshCFVikBcVV4rXJowk/oYsNR4I8pEnMVgnrXY5aIpQ2qHjthWTi/cEwQD65Ei/JLga7Fdz1o=
Received: from DB7PR07MB4106.eurprd07.prod.outlook.com (52.134.103.159) by DB7PR07MB4780.eurprd07.prod.outlook.com (52.135.133.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.16; Mon, 10 Feb 2020 11:53:45 +0000
Received: from DB7PR07MB4106.eurprd07.prod.outlook.com ([fe80::f414:bb9:5b0e:c5f6]) by DB7PR07MB4106.eurprd07.prod.outlook.com ([fe80::f414:bb9:5b0e:c5f6%7]) with mapi id 15.20.2729.020; Mon, 10 Feb 2020 11:53:45 +0000
From: "Bocci, Matthew (Nokia - GB)" <matthew.bocci@nokia.com>
To: "draft-ietf-bess-rfc5549revision@ietf.org" <draft-ietf-bess-rfc5549revision@ietf.org>, "bess@ietf.org" <bess@ietf.org>
Thread-Topic: Shepherd's review of draft-ietf-bess-rfc5549revision-01
Thread-Index: AQHV4Ai/AEt2qYnVME+eKkVFd9Ss4Q==
Date: Mon, 10 Feb 2020 11:53:45 +0000
Message-ID: <58D9DA41-62A1-4F3B-BCA0-ABDF26ADE9F5@nokia.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.21.0.200113
authentication-results: spf=none (sender IP is ) smtp.mailfrom=matthew.bocci@nokia.com;
x-originating-ip: [81.108.178.133]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 11566ee4-612c-468e-124f-08d7ae1fe1f3
x-ms-traffictypediagnostic: DB7PR07MB4780:
x-microsoft-antispam-prvs: <DB7PR07MB478074618D1607834B9E1336EB190@DB7PR07MB4780.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 03094A4065
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(39860400002)(346002)(396003)(376002)(136003)(366004)(199004)(189003)(478600001)(26005)(36756003)(33656002)(55236004)(71200400001)(6506007)(2906002)(2616005)(64756008)(76116006)(91956017)(86362001)(450100002)(66476007)(66446008)(66556008)(66946007)(6486002)(81156014)(186003)(81166006)(5660300002)(316002)(8676002)(6512007)(110136005)(8936002); DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR07MB4780; H:DB7PR07MB4106.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: nokia.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: BkMkB6G5lATMDqInKfm9pbn7ITHZq+y/kxwum9kzUJVVTD4hbv/7FYKmvYrp9tdDfzWaelTaezNVvydUSy7RjKkzWM+tVZo9tseJRWYh7nYKRzSQVtr4oYyGIAidoGrWreSdYlqkLTOZMtby3PaIxd9GE5QTBW0eD3WgkKd2mw0oYxNFkVTJUML2X4LFtIdpKJtQuqjBMDzYSBOvn+FMNdmrHPYAZQV0VVYC3WXXga9sr8wZgNfP1Guj6EPTrjbRqVMR/ipqLhoXqEpAjMYbcw+YNlLM3V9Q5LV3qxXfHqQO4WzowQF/cqAQ3D6sTPgyhBQFMLzupEzHi5+S3+speWK2nRNYra/4dgpZ55NQKSrnC/DHoH9/tahFN+Zn5sxDN0wWuUe65U6OcrOzbJ+jqeo9P+a8aEfyMnXdGqreqpCoSXB8EIzK10Ud8srG7BsFENFpbViWfwnetsHTBWOx8k2Xbmcl3uu9o+kpx4GvfgSuTDcG3+AaysyO101UZY7n2kP6gHFEdAtBVVjHo3I84Q==
x-ms-exchange-antispam-messagedata: EgUquArBB19UdRMih1sZqA48uPWeqluZxz5OUAdqmEln7sAHLyAmFLRYQdYto8QgMJIBU8dpS8M6Vf0+tiiDizTcdf20OTg9Dq7UQ0zTjh+LkW3sXrRit2EqNxGlmz3sgwY75Bo/5jF2k8kKlXH3Bw==
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_58D9DA4162A14F3BBCA0ABDF26ADE9F5nokiacom_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11566ee4-612c-468e-124f-08d7ae1fe1f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2020 11:53:45.3507 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JIvArV08VI+Q0TRnZn4oJOslxopEAIyBiDi3ZWF9d75AlUgpBIgtJ7LXpqR+nL4Mieu9Hta4jmgVBOtE0kGS6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR07MB4780
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/xhp7DSW6zpNFnibtVuNMggtpbTA>
Subject: [bess] Shepherd's review of draft-ietf-bess-rfc5549revision-01
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Feb 2020 11:53:54 -0000
Authors
I have reviewed the draft. It is well written, and I only have a few very minor editorial comments.
Please treat these as you would any other WG LC comment.
Pg 5:
“o Next Hop Address = VPN-IPv6 address of next hop with an 8-octet RD
is set to zero (potentially followed by the link-local VPN-IPv6
address of the next hop with an 8-octet RD is set to zero).”
s/is set to zero/set to zero, in both cases.
Pg7:
“This specification does not propose that the Extended Next Hop
Encoding capability be used with any other combinations of <NLRI AFI,
NLRI SAFI, Nexthop AFI>. In particular, this specification does not
propose that the Extended Next Hop Encoding capability be used for
NLRI AFI/SAFIs whose definition already allows use of both IPv4 and
IPv6 next hops (e.g., AFI/SAFI = <1/132> as defined in [RFC4684<https://tools.ietf.org/html/rfc4684>]).
Similarly, it does not propose that the Extended Next Hop Encoding
capability be used for NLRI AFI/SAFIs for which there is already a
solution for advertising a next hop of a different address family
(e.g., AFI/SAFI = <2/1>, <2/2>, or <2/4> with IPv4 Next Hop as per
[RFC4798<https://tools.ietf.org/html/rfc4798>] and AFI/SAFI = <2/128> with IPv4 Next Hop as per
[RFC4659<https://tools.ietf.org/html/rfc4659>]).”
I am not sure “propose” is the right word, as this document (when published as an RFC) specifies a specific set of procedures. It will not be a proposal. I suggest rephrasing the first sentence to:
“The Extended Next Hop Encoding capability MUST NOT be used with any other combinations of <NLRI AFI, NLRI SAFI, Nexthop AFI>.”
I also found the second part of the paragraph starting “In particular” to be unnecessary given the first sentence. If it is needed, then maybe you could rephrase it to read as an example, e.g.:
“For example, the Next Hop Encoding capability specified in this document is not intended to be used for...” and “Similarly, it is not intended that the Extended Next Hop Encoding capability be used for NLRI AFI/SAFIs for which there is already solution...”.
Best regards
Matthew
- [bess] Shepherd's review of draft-ietf-bess-rfc55… Bocci, Matthew (Nokia - GB)