Re: [Cbor] Starting WGLC on draft-iet-cbor-sequence

Jim Schaad <ietf@augustcellars.com> Mon, 19 August 2019 19:59 UTC

Return-Path: <ietf@augustcellars.com>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D34C71208F2; Mon, 19 Aug 2019 12:59:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kRMWJyHBE4Xg; Mon, 19 Aug 2019 12:59:49 -0700 (PDT)
Received: from mail2.augustcellars.com (augustcellars.com [50.45.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0C7F51208E0; Mon, 19 Aug 2019 12:59:46 -0700 (PDT)
Received: from Jude (73.180.8.170) by mail2.augustcellars.com (192.168.0.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 19 Aug 2019 12:59:20 -0700
From: Jim Schaad <ietf@augustcellars.com>
To: <draft-ietf-cbor-sequence@ietf.org>
CC: <cbor@ietf.org>
References: <030e01d552b8$c7c9d110$575d7330$@augustcellars.com>
In-Reply-To: <030e01d552b8$c7c9d110$575d7330$@augustcellars.com>
Date: Mon, 19 Aug 2019 12:59:19 -0700
Message-ID: <01f501d556c8$97d452a0$c77cf7e0$@augustcellars.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGWLfiTnFim1QpWkbA0RZBLNAKVHKeBLa8w
Content-Language: en-us
X-Originating-IP: [73.180.8.170]
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/K3MUd5ekYHp2hYelwzIp_et1mmw>
Subject: Re: [Cbor] Starting WGLC on draft-iet-cbor-sequence
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Aug 2019 19:59:51 -0000

Here is my WGLC review - and also a reminder that people need to, at a
minimum, say that they have no problems with the document.  The hope is to
close the WGLC before the next CBOR interim.

Jim


1.  Section 1: Should the introduction note the registration in the CBOR
content format registry as well?  I have no personal opinion on this.

2.  Section 2: I find the paragraph about delimiters slightly difficult to
read.  Something that might be better is:

CBOR Sequences, unlike JSON Text Sequences [], do not use a marker between
items.   This is because CBOR data items are self-delimiting and the end can
always be calculated.  This is no longer true for JSON as a simple value
such as an number is now a JSON document.

This reads slightly better in my opinion and also highlights why JSON is no
longer self-delimiting.

3.  Section2: In the second bullet under decode - would "deliver a sequence
of CBOR data model values" be better as "deliver one or more CBOR data model
values" ?  I don't have a personal opinion, I just wonder if avoiding
sequence is better in this context.