Re: [Cellar] [FFV1] Adding Bayer support

Jerome Martinez <jerome@mediaarea.net> Thu, 11 October 2018 12:09 UTC

Return-Path: <jerome@mediaarea.net>
X-Original-To: cellar@ietfa.amsl.com
Delivered-To: cellar@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B5206130E1B for <cellar@ietfa.amsl.com>; Thu, 11 Oct 2018 05:09:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TNcy1kD4f4JT for <cellar@ietfa.amsl.com>; Thu, 11 Oct 2018 05:09:36 -0700 (PDT)
Received: from 17.mo7.mail-out.ovh.net (17.mo7.mail-out.ovh.net [188.165.35.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12541130DD1 for <cellar@ietf.org>; Thu, 11 Oct 2018 05:09:35 -0700 (PDT)
Received: from player787.ha.ovh.net (unknown [10.109.160.244]) by mo7.mail-out.ovh.net (Postfix) with ESMTP id AE730DCDD4 for <cellar@ietf.org>; Thu, 11 Oct 2018 14:09:33 +0200 (CEST)
Received: from [192.168.2.120] (p5DDB4865.dip0.t-ipconnect.de [93.219.72.101]) (Authenticated sender: jerome@mediaarea.net) by player787.ha.ovh.net (Postfix) with ESMTPSA id 7BE006000BB for <cellar@ietf.org>; Thu, 11 Oct 2018 14:09:33 +0200 (CEST)
To: cellar@ietf.org
References: <96b8ef11-ab4d-99fd-b260-ebec6b563a6c@mediaarea.net> <20180113111734.GB17711@michaelspb> <9a28a229-0016-a7cb-e656-7ffcd0e690bc@mediaarea.net> <20180113120933.GC17711@michaelspb>
From: Jerome Martinez <jerome@mediaarea.net>
Message-ID: <b435719f-50ef-57cc-22fb-ee7712871bff@mediaarea.net>
Date: Thu, 11 Oct 2018 14:09:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20180113120933.GC17711@michaelspb>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Ovh-Tracer-Id: 4430697609120452753
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudekgdeghecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecu
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/21Tbhm0ZiEY1HMUSwBLzMVM-ZjQ>
Subject: Re: [Cellar] [FFV1] Adding Bayer support
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Oct 2018 12:09:39 -0000

On 13/01/2018 13:09, Michael Niedermayer wrote:
>
> about samples, please include both very sharp and more blurry (at pixel level)
> samples. These 2 should behave quite different compression wise with sparse
> sampling of colors. Also high noise and low noise content should be included
> high ISO low light would produce very noisy content, low ISO bright light
> should produce low noise.


About samples, I have some difficulties to get enough different samples 
(especially compatible with FFmpeg, some files I got are not readable as 
is by FFmpeg so effort would be more important than just updating FFmpeg 
on FFV1 side), and actually I now think that we should not change FFV1 
v3 (and below) much compared to other color_space (study of optimization 
would be done for v4, for both RGB and Bayer, in order to find common 
optimizations), so I changed of strategy and do very minimal additions 
to the bitstream, just what is needed for adding the green difference 
(replacing Alpha) to current RGB code.

I also have a running version of FFmpeg with FFV1 Bayer encoding and 
decoding.

Link to the updated PR + FFmpeg code:
https://github.com/FFmpeg/FFV1/pull/100#issuecomment-427775814

Jérôme