Re: [core] Adam Roach's No Objection on draft-ietf-core-too-many-reqs-05: (with COMMENT)

Ari Keränen <ari.keranen@ericsson.com> Wed, 24 October 2018 06:03 UTC

Return-Path: <ari.keranen@ericsson.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 83787130DE5 for <core@ietfa.amsl.com>; Tue, 23 Oct 2018 23:03:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.791
X-Spam-Level:
X-Spam-Status: No, score=-3.791 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=XSG5Zpxk; dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=ericsson.com header.b=GY3dh2S+
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 493h6N82ABCl for <core@ietfa.amsl.com>; Tue, 23 Oct 2018 23:03:32 -0700 (PDT)
Received: from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4CADF130DEA for <core@ietf.org>; Tue, 23 Oct 2018 23:03:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1540361005; x=1542953005; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L1lYL7P+xmR2iZTqusve0BBMdJmcVDJz7/2iQyblxtk=; b=XSG5ZpxkRnlroPHeb1KySvpqFOe94z9Nnsi1alG6gXAW+rhrsp5R4I5inwOWgOf0 P1Z+QHFiRn8/r1H8kvmDTb/5nvFhZ1U0IucB4GAu+9O4NrbJXwCSjFCsTCWS3uf8 9GSn8i9GzxLwK51EcSS3WLzHK5dkkn+ZCgjpGO9i5Yw=;
X-AuditID: c1b4fb25-a0b8c9e0000018b4-57-5bd00b2d3078
Received: from ESESSMB504.ericsson.se (Unknown_Domain [153.88.183.122]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 50.14.06324.D2B00DB5; Wed, 24 Oct 2018 08:03:25 +0200 (CEST)
Received: from ESESBMB503.ericsson.se (153.88.183.170) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 24 Oct 2018 08:03:23 +0200
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB503.ericsson.se (153.88.183.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 24 Oct 2018 08:03:23 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AIQEUaGKqFZEeK60S9tme6EXIQ9kxY28uv5yyN/FwkI=; b=GY3dh2S++nyfKK/MyW5nQ0IchpcaNEybJD0QTyQAAkEdTHuFzxodlEbwhVQuZ7CRbPlYu2S5jNVnVedJBIO2OO3ZFxKunnghNzG0xJEqPsawtdLP+r12bdLPjubW/7Wx9Oj5p8OaVIMjYU05rkD8EBcKgZH/it66sxoTjuDcZh4=
Received: from HE1PR07MB4236.eurprd07.prod.outlook.com (20.176.166.145) by HE1PR07MB3290.eurprd07.prod.outlook.com (10.170.246.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.13; Wed, 24 Oct 2018 06:03:22 +0000
Received: from HE1PR07MB4236.eurprd07.prod.outlook.com ([fe80::b074:afe2:469c:dd95]) by HE1PR07MB4236.eurprd07.prod.outlook.com ([fe80::b074:afe2:469c:dd95%2]) with mapi id 15.20.1273.019; Wed, 24 Oct 2018 06:03:22 +0000
From: =?utf-8?B?QXJpIEtlcsOkbmVu?= <ari.keranen@ericsson.com>
To: Adam Roach <adam@nostrum.com>
CC: The IESG <iesg@ietf.org>, "draft-ietf-core-too-many-reqs@ietf.org" <draft-ietf-core-too-many-reqs@ietf.org>, Carsten Bormann <cabo@tzi.org>, "core-chairs@ietf.org" <core-chairs@ietf.org>, "core@ietf.org" <core@ietf.org>
Thread-Topic: Adam Roach's No Objection on draft-ietf-core-too-many-reqs-05: (with COMMENT)
Thread-Index: AQHUallVCqpIJu8I4EypLkUELrHEUqUt6dWA
Date: Wed, 24 Oct 2018 06:03:22 +0000
Message-ID: <B274215B-2253-4213-8925-6EA9DA14EA4B@ericsson.com>
References: <154024846005.13541.11907103981598035179.idtracker@ietfa.amsl.com>
In-Reply-To: <154024846005.13541.11907103981598035179.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [2001:14bb:180:9de9:b582:a195:f23e:eac4]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; HE1PR07MB3290; 6:/9mJYctCFdQT/INO92mvv+9NqvTEJnHeJGCwG2+PZAt13yAQ88BiSO32CFf8ejVe5uqswZLF0grCQuD8eyVr9fYV5IyQagMtSVFmBSnEGbleAOj4MPawaUspU+kWwnGq2Nx/lDG+JCauxTLy1BTe/nvOSnG/Uo6f5sKEaxGP2op+pjUemkn7U3L1xjy03rS/BXbrp6UFQvqqChMoHDU9fGgaGB9MTCBt6AUGE/e29GNXiFEpzZ7NfQLVqLXhVBHGxGTjaH5HPE5yzSomwGfLgSTKPX0C7+T5CDQNOISf3al+/hi/MNSHWd6pshZeWIOnvIlk0EW55tjahHJw+yaOXF/nMecoV5lPpre84s0qGHc108R8fR3/672EoB5JaKZGxtOdxFbWYOa9sq+kX5917kx+UqK7zjcf6r/fhN3ThyS9IMVAFfaJEJUTR9516iWCK/QlOqqgtf9ev4En/LlXNw==; 5:F+7ThnS5BzPimWwO298cgxWtl05f2qFQnL1xtBt+9jOiodjdiHfkMGBB5O5tZ2cEIwlopljdW66FslqCI5iholXFWY8Q/g7gAif5I7sFwauINXfNqlcFaNwVeFVP0H/M2ZIhvlgA4hETBjv6mC/2OOwSrstZJCzOprotUPZYc2c=; 7:SN/x3sepmKvvl11doACN7JZMdORVO/cvcLfRtgAxNWtN3A9noFf5dZUCBVZAbnXTchb9ZdYAK6K4+vbP/9+9Smx7TAQXei2dRGz/eU7ArEBWEzbZulxdNLffKQE44NWdVQT6CK6f83T3NxlK2tJgaw==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: ee8b30ce-66b2-4467-3fdb-08d63976675b
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(49563074)(7193020); SRVR:HE1PR07MB3290;
x-ms-traffictypediagnostic: HE1PR07MB3290:
x-microsoft-antispam-prvs: <HE1PR07MB3290921C5458A4D3584533F285F60@HE1PR07MB3290.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(166708455590820);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(102415395)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(4983020)(52105095)(3002001)(93006095)(93001095)(10201501046)(148016)(149066)(150057)(6041310)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:HE1PR07MB3290; BCL:0; PCL:0; RULEID:; SRVR:HE1PR07MB3290;
x-forefront-prvs: 083526BF8A
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(39860400002)(376002)(346002)(396003)(199004)(189003)(51914003)(85182001)(2906002)(86362001)(7736002)(82746002)(97736004)(53936002)(14454004)(229853002)(105586002)(6346003)(68736007)(85202003)(5250100002)(476003)(256004)(186003)(25786009)(106356001)(486006)(4326008)(11346002)(14444005)(46003)(446003)(2616005)(81166006)(316002)(71190400001)(8676002)(81156014)(6916009)(33656002)(102836004)(6436002)(8936002)(99286004)(6506007)(71200400001)(83716004)(76176011)(36756003)(5660300001)(2900100001)(6246003)(99936001)(6486002)(345774005)(236005)(606006)(6116002)(6306002)(54896002)(54906003)(478600001)(6512007)(966005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB3290; H:HE1PR07MB4236.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ari.keranen@ericsson.com;
x-microsoft-antispam-message-info: o7Kp6YdmY3//oolI+pmKwsm2MOvnp9EvngOgetXVnRfK2ANFd9r8e+lsMxtrq2y5RVw/Z5W0+zmh9007Wvy8tm1AT+nQr4fSmE2obzpbeIflSRvW4emM71T/CvGLExo8gHkbAzebaNyq5zCjMAnSZ3KbcC8jCLIlqvWAVWixcz9jihytn2GeGNsE5MukDozqFFqO3X2J2YERfwAm1ePZGUmNpB8aHmnc5+3x1IfcYDBmwx8Ue4sMPZUnnf1jfodRkUOeHD6Q//QYOtt2Gie2Pr9uiJREYXZgEKkhfYF4XiPO7DyqUNwkdIst+RuOB766DDgJTg7PiwarVNXFGP+F49R2CxmDiYHrVM71GB83cyQ=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/signed; boundary=Apple-Mail-FFBF3744-7EE1-4D6A-9864-4D3D875F945D; protocol="application/pkcs7-signature"; micalg=sha1
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ee8b30ce-66b2-4467-3fdb-08d63976675b
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2018 06:03:22.1992 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3290
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA2WSa0iTYRSAefdd9rlavC7No91wpKgwK01b94J+SFQGFZgVNvNDR7qNfWrp j7LC8tLFamaKoolQmWCZl0zRNvOH+sNZGWWlTKcWWi0TbWUrt3dB0L/nnPOc854DL0fJclk/ Tq1J5fUaVbKcldDFMU2ZCsUC8+E1A5MRytZflWLlM8N7Rtn40Mwq2z7VUsqK7AZaeWvuGrWd jaqqsouiSpqtdNTNSvU+KlayOYFPVqfz+tVbj0mSCrJtYt2YcKqqPDkLNerykAcHeB18uHKO zUMSToY7ETie9NIkmEGQdf4DQ4IqEdzt7ndpNC6g4GxRpbtiEMGX5kJ3MIxgqtfCOCezeAtY s9tc7IX94ULHG8opUXgUgbHc6CosxkfgbucXmkhHYWqoEhEOg7a5PLGTaRwART1XXb4Ub4Ou N3aXI8N7wZ4zPj+U4zxwNPSWbnWmEV4Cs901IidT2AcGrOUicqkXWPp6WMLe8HHEwRDeCB39 72jCy+F5eT5y7gn4FQtFtX3uZgXYCgspwntgYvYHQ6Q+BK+b2t1SCDQ0fKOdCwE+AY6RCJLe BBXZde7eFVB92eJ+7C0FZbd0BWhNyT+7Er6BwHpJWeI62RO6iq00yceB7ft5hvBKaPpUShEO hvb8O27HHwz5FjHhIMiducb8n98E9tJhRDgCJjq/on+dCrSwGnkLvBCfkhgWHsrr1ccFQasJ 1fCpdWj+UxrrfwY8Ri8md5gQ5pB8odTT1ntYxqjShYwUE1o1P2f4wX0z8qM1Wg0v95Li3/Nl aYIqI5PXa+P0acm8YEJLOVruI7WsfxQrw4mqVP4Ez+t4/d+qiPPwy0L+y0boRsX1Gy23uaJd M6qcQ2Mx7O9WzW114NEy0+mgg8Fz3zeEjFNBjpyewG5F5M4DT6PTYnad/DrtG+sTnDkoDNnG o9Nm9xs/nzrzynNyVjtSMzqd25Vkaa6fKET2/qv+LVkXT8bf61zZOun70tAxEHPTnMpE7g5f 9CNysGZQOyWnhSTV2hBKL6j+AC4K7cGcAwAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/a5FWhZlKYw5Q-EXQg655_ZhiwwA>
Subject: Re: [core] Adam Roach's No Objection on draft-ietf-core-too-many-reqs-05: (with COMMENT)
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 06:03:33 -0000

Thank you for the review Adam! I started a new PR to address the IESG review comments:
https://github.com/core-wg/too-many-reqs/pull/5/files

See answers to your comments inline.

> On 23 Oct 2018, at 1.48, Adam Roach <adam@nostrum.com>; wrote:
> 
> Adam Roach has entered the following ballot position for
> draft-ietf-core-too-many-reqs-05: No Objection
[...]
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thanks for the work that everyone did on this document. I have one major
> comment, and a couple of small editorial nits.
> 
> This document defines the use of the Max-Age option that is very different from
> its originally defined use. It seems to me that the IANA registry entry for
> Max-Age needs to be updated to reference this document in addition to RFC 7252.

While the Max-Age use is a bit different in 2.xx series answers, how this draft uses it is actually very similar to how it’s used by the 5.03 code: “to indicate the number of seconds after which to retry”. I clarified this in the intro now (see the PR for details).

IANA registry update might be a good idea though.

> Additionally, the original definition of Max–Age included a default value of 60
> seconds. It is unclear, and somewhat ambiguous, whether that default is intended
> to apply to this mechanism as well. Please add text explicitly indicating
> whether a default applies. In any case, this document should have an indication
> of what the client does if the response contains no max-age option.

Good point. I added a note saying that the default is assumed if the option is missing, and reference to section 5.10.5 of RFC7252.

> ---------------------------------------------------------------------------
> 
> Title:
> 
> This would benefit from having the COAP protocol named in the title.

Unfortunately adding the CoAP abbreviation in the long title would make the title too long for a single line and the abbreviation alone would be on second line. The short title contains the acronym already though. 

But if the current long title causes confusion, I guess we could ask the RFC editor to split the title in the final version in a more typographically aesthetic way.

> ---------------------------------------------------------------------------
> 
> §1:
> 
>> the too frequent requests from the requesting client are the reason
> 
> Nit: "...too-frequent..."

Fixed.


Thanks,
Ari