Re: [core] AD review of draft-ietf-core-cocoa-02

Jaime Jiménez <jaime.jimenez@ericsson.com> Mon, 12 February 2018 13:33 UTC

Return-Path: <jaime.jimenez@ericsson.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF4EB127978 for <core@ietfa.amsl.com>; Mon, 12 Feb 2018 05:33:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.32
X-Spam-Level:
X-Spam-Status: No, score=-4.32 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m6ldYStYJjId for <core@ietfa.amsl.com>; Mon, 12 Feb 2018 05:33:25 -0800 (PST)
Received: from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B823C126C19 for <core@ietf.org>; Mon, 12 Feb 2018 05:33:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1518442402; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+N7iEeRXVcKIvvb6bHYeBQ49jJFWld6B1AcD2zjBjuA=; b=LP2p50NzIApWymu+3jZ+ORYdFJWMNZTzI/L8eYb0wt5xWkHRB7uhAkzoMfImET0K zkhz9hfytNn6yqq45dZMM/AjU6TWFmqj+wQo8Vn0m1/pX/mICIFMlQUFAXw1e2w6 rx6b/sKMSF8XPzV+pDt/kMXsGv6S4BYS6WGiWVlN2co=;
X-AuditID: c1b4fb25-473ff7000000341b-ec-5a8197a27545
Received: from ESESSHC022.ericsson.se (Unknown_Domain [153.88.183.84]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 0E.45.13339.2A7918A5; Mon, 12 Feb 2018 14:33:22 +0100 (CET)
Received: from ESESSMB107.ericsson.se ([169.254.7.108]) by ESESSHC022.ericsson.se ([153.88.183.84]) with mapi id 14.03.0352.000; Mon, 12 Feb 2018 14:33:22 +0100
From: Jaime Jiménez <jaime.jimenez@ericsson.com>
To: "Mirja Kuehlewind (IETF)" <ietf@kuehlewind.net>
CC: "draft-ietf-core-cocoa.all@ietf.org" <draft-ietf-core-cocoa.all@ietf.org>, "core@ietf.org" <core@ietf.org>
Thread-Topic: AD review of draft-ietf-core-cocoa-02
Thread-Index: AQHToa4aLDrSx6eaQECmLTHGBPgD4KOgt/mA
Date: Mon, 12 Feb 2018 13:33:22 +0000
Message-ID: <4B20067C-5F2E-4F30-8AEB-27B2B07D107C@ericsson.com>
References: <A4762743-0B2C-46BA-8E11-8AC775567DF5@kuehlewind.net>
In-Reply-To: <A4762743-0B2C-46BA-8E11-8AC775567DF5@kuehlewind.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.150]
Content-Type: multipart/signed; boundary="Apple-Mail=_B6C35E6C-23DB-4F7F-BF3E-C115DF8D823C"; protocol="application/pkcs7-signature"; micalg="sha1"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsUyM2J7iO6i6Y1RBof+G1nse7ue2WLmq7es Fi+uf2R2YPZYsuQnk0fLx4WsAUxRXDYpqTmZZalF+nYJXBnn99xkLvhUXnFz5yL2BsZtWV2M nBwSAiYSZ7efZOpi5OIQEjjMKLHx/QkoZwmjRPePW0wgVWwCzhKfnjWyg9giAsYShyd/ZwWx mQUKJBZcesEGYgsLGEm86LrFBlOz5WgTK4RtJNHe18vYxcjBwSKgKvH5ozFImFfAXqK59Qgj iC0k4CixadpssHJOASeJU0uugdmMAmIS30+tYYJYJS5x68l8JoijRSQeXjzNBmGLSrx8/I8V wlaSWLH9EiNE/RRGidVroiB2CUqcnPmEZQKjyCwko2YhKZuFpAwiniSxZE8/M4StLbFs4Wso W1Nif/dyFkxxDYnObxNZIWxTiddHPzJC2NYSM34dZIOwFSWmdD9kX8DIvYpRtDi1OCk33chY L7UoM7m4OD9PLy+1ZBMjMIIPbvmtuoPx8hvHQ4wCHIxKPLzb2xujhFgTy4orcw8xqgDNebRh 9QVGKZa8/LxUJRHeP81Aad6UxMqq1KL8+KLSnNTiQ4zSHCxK4rwnPXmjhATSE0tSs1NTC1KL YLJMHJxSDYw8HtlmdquDW56flHwnKsybHm4R/fM2n8nZNx9uCsyeb+W2u7HeaNJEv7qtXrNX 7VAXfl1x3bCDYdnW49dD6+puMTw77xY4u+RUU1b5U8ZpjYuu8MvP3hjmrnb4xhLhtWHTFs0w yc0OsHz65q/3HdEbiWpm8RfnLjHbGDZ/bXHgrqf2F2bqrMxUYinOSDTUYi4qTgQAFnWmHugC AAA=
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/aGv2R8caKC1WVh-TKOUTAvxHzwI>
Subject: Re: [core] AD review of draft-ietf-core-cocoa-02
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Feb 2018 13:33:27 -0000

> @Jaime: could you please update the shepherd-write to reflect that I’m the responsible area director and maybe provide one additional sentence to explain why informational is the right indented status!

Done!

- - Jaime Jiménez

> On 9 Feb 2018, at 15.58, Mirja Kuehlewind (IETF) <ietf@kuehlewind.net> wrote:
> 
> Hi authors!
> 
> I reviewed the document and think it is ready for IETF last call. Find below a couple of mostly editorial notes that came to my mind while reviewing the document. Please let me know if you’ll like to address (if at all) any of these comments with an update before I start IETF last call, or if I should start the last call immediately with this version!
> 
> @Jaime: could you please update the shepherd-write to reflect that I’m the responsible area director and maybe provide one additional sentence to explain why informational is the right indented status!
> 
> Thanks!
> Mirja
> 
> --------------------------
> 
> Mostly editorial comments:
> 
> 1) First sentence in sec 1, maybe: 
> s/The CoAP protocol/The Constrained Application Protocol (CoAP) [RFC7252]/
> 
> 2) The following note is not necessary:
> "(Note that the present document is itself informational, but it is
>   discussing normative statements about behavior that makes the
>   congestion control scheme work in a safe manner.)“
> 
> 3) The formatting with (1) and (2) is a bit confusing in the equations in section 4.2.; maybe you can add some more space there. Further I really find it confusing that you directly use RTO instead of RTT here and then just later explain that you use an K of 1. I would rather explain that first an maybe even use RTT_weak and RTT_strong instead of E_
> 
> 4) I find the heading of section 4.2.1 a bit confusing and the whole section a bit hard to read as you didn’t really introduce the „new“ backoff calculation yet. Maybe you can actually move some of the discussion (about initial values and K) in the previous subsection and call this ubsection something like „Backoff calculation“ and then maybe add one sentence that explains what RFC6298 does, e.g. „In [RFC6298] the RTO is increased exponentially with a factor of 2 if the RTO timer expires.“
> 
> 4) sec 4.3 "It MUST be kept for at least 255 s.“
> Why is that a MUST and why 255s?
> 
> 5) I would consider to have section 5 before section 4, to give the reader a better idea that the calculated RTO is used to define the sending rate (which is the actually congestion control part of the spec). I think it would also be good to give a high-level (1-2 sentences) overview of the congestion control principle in the intro, e.g. CoCoA calculates the retransmission time-out (RTO) based on the estimated RTT with and without loss and limits the sending rate (for non-confinable packets) to 1/RTO. By taking retransmissions (in a potentially lossy network) into account when estimating the RTT, this algorithm reacts to congestion will a lower sending rate.“
> 
> Also this sentence in section 5.1 could be helpful information in the intro already: "Assuming that the RTO
>   estimation in CoCoA works as expected, RTO[k] should be slightly
>   greater than the RTT[k], thus CoCoA would be more conservative.“
> 
> 6) Maybe consider to integrate Appendix B into the body of the document. I think that would actually help the reader.
> 
>