Re: [DNSOP] Passive DNS - Common Output Format (draft-dulaunoy-kaplan-passive-dns-cof-01)

"L. Aaron Kaplan" <kaplan@cert.at> Thu, 27 February 2014 16:44 UTC

Return-Path: <kaplan@cert.at>
X-Original-To: dnsop@ietfa.amsl.com
Delivered-To: dnsop@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 592071A0234 for <dnsop@ietfa.amsl.com>; Thu, 27 Feb 2014 08:44:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.679
X-Spam-Level:
X-Spam-Status: No, score=-0.679 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_EQ_AT=0.424, HOST_EQ_AT=0.745, J_CHICKENPOX_32=0.6, RP_MATCHES_RCVD=-0.547, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WQsGvzTMjPD7 for <dnsop@ietfa.amsl.com>; Thu, 27 Feb 2014 08:44:05 -0800 (PST)
Received: from nuwen.cert.at (nuwen.cert.at [IPv6:2a02:850:5:64::2]) by ietfa.amsl.com (Postfix) with ESMTP id E3F171A0033 for <dnsop@ietf.org>; Thu, 27 Feb 2014 08:44:04 -0800 (PST)
Received: from cleophus.intern.cert.at (cleophus.intern.cert.at [172.21.47.118]) by nuwen.cert.at (Postfix) with ESMTP id F0B5224124; Thu, 27 Feb 2014 17:43:56 +0100 (CET)
Received: from [172.21.48.118] (unknown [172.21.48.118]) by cleophus.intern.cert.at (Postfix) with ESMTPS id C80D23415CA; Thu, 27 Feb 2014 17:43:59 +0100 (CET)
Content-Type: multipart/signed; boundary="Apple-Mail=_F14839A0-F975-4CA0-86F9-C025BAE7233A"; protocol="application/pgp-signature"; micalg=pgp-sha1
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
From: "L. Aaron Kaplan" <kaplan@cert.at>
In-Reply-To: <alpine.LSU.2.00.1401161404280.13642@hermes-2.csi.cam.ac.uk>
Date: Thu, 27 Feb 2014 17:43:51 +0100
Message-Id: <80FDE505-1ADC-4451-8A74-51CFFE681A1C@cert.at>
References: <52D298FB.3080100@redbarn.org> <52D6E0AB.807@redbarn.org> <alpine.LSU.2.00.1401161404280.13642@hermes-2.csi.cam.ac.uk>
To: Tony Finch <dot@dotat.at>
X-Mailer: Apple Mail (2.1510)
X-CERTat-MailScanner-ID: F0B5224124.A946E
X-CERTat-MailScanner: Found to be clean
X-CERTat-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-2.9, required 5, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90)
X-CERTat-MailScanner-From: kaplan@cert.at
Archived-At: http://mailarchive.ietf.org/arch/msg/dnsop/-uc-G5Zjny68PFIzrU1p9V_fFRA
X-Mailman-Approved-At: Thu, 27 Feb 2014 08:57:57 -0800
Cc: Dulaunoy Alexandre <Alexandre.Dulaunoy@circl.lu>, dnsop@ietf.org
Subject: Re: [DNSOP] Passive DNS - Common Output Format (draft-dulaunoy-kaplan-passive-dns-cof-01)
X-BeenThere: dnsop@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsop>, <mailto:dnsop-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dnsop/>
List-Post: <mailto:dnsop@ietf.org>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsop>, <mailto:dnsop-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Feb 2014 16:44:07 -0000

Hi Tony,

Thanks a lot for your very valuable feedback.

On Jan 16, 2014, at 3:27 PM, Tony Finch <dot@dotat.at>; wrote:

> Paul Vixie <paul@redbarn.org>; wrote:
> 
>> speaking for the authors of the draft below, i request adoption by
>> dnsop. --vixie
>> 
>> https://datatracker.ietf.org/doc/draft-dulaunoy-kaplan-passive-dns-cof/
> 
> A few questions / comments:
> 
> The ws non-terminal isn't defined. I guess it is supposed to be
> 
> 	ws = *( %x10 / %x09 )
> 
I agree. You probably meant 

   ws              = *(
                       %x20 |              ; Space
                       %x09                ; Horizontal tab
                      )

?

> i.e. no newlines within a JSON object, which is different from the
> definition of ws in RFC 4627. (Maybe use core ABNF WSP instead?)
> 
Fixed , thanks for pointing this out.

> The ABNF specifies that the field names are not quoted (the quotes are
> part of the ABNF metasyntax not part of the language it specifies) which
> is incompatible with JSON and disagrees with the examples in the appendix.
> 
Fixed

> The appendix could do with some rubric to explain the backslashes.
> 
Fixed

> Are numeric rrtypes represented as JSON numbers? Or a "TYPEnnn" string?
> 
JSON numbers

> I guess time stamps are represented as JSON numbers.
> 
Yes

> How are sensor_id octet strings encoded as JSON strings?
> 
Correct.


So, the changes are currently in our github repository. Waiting for Alexandre to submit them again.

See you next week.

a.

> Tony.
> -- 
> f.anthony.n.finch  <dot@dotat.at>;  http://dotat.at/
> Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.
> Rough, becoming slight or moderate. Showers, rain at first. Moderate or good,
> occasionally poor at first.
> _______________________________________________
> DNSOP mailing list
> DNSOP@ietf.org
> https://www.ietf.org/mailman/listinfo/dnsop

--- 
// L. Aaron Kaplan <kaplan@cert.at>; - T: +43 1 5056416 78
// CERT Austria - http://www.cert.at/
// Eine Initiative der nic.at GmbH - http://www.nic.at/
// Firmenbuchnummer 172568b, LG Salzburg