Re: [Fecframe] AD Review: draft-ietf-fecframe-rtp-raptor
Thomas Stockhammer <stockhammer@NOMOR.DE> Mon, 10 October 2011 17:39 UTC
Return-Path: <stockhammer@NOMOR.DE>
X-Original-To: fecframe@ietfa.amsl.com
Delivered-To: fecframe@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 43F6A21F8C70 for <fecframe@ietfa.amsl.com>; Mon, 10 Oct 2011 10:39:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zE6GVq-zWCbZ for <fecframe@ietfa.amsl.com>; Mon, 10 Oct 2011 10:39:34 -0700 (PDT)
Received: from mo-p00-ob6.rzone.de (mo-p00-ob6.rzone.de [IPv6:2a01:238:20a:202:53f0::1]) by ietfa.amsl.com (Postfix) with ESMTP id 2A04821F8C6E for <fecframe@ietf.org>; Mon, 10 Oct 2011 10:39:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1318268371; l=4243; s=domk; d=nomor.de; h=To:References:Content-Transfer-Encoding:Cc:Date:In-Reply-To:From: Content-Type:Mime-Version:Subject:X-RZG-CLASS-ID:X-RZG-AUTH; bh=2r37+Of34L9HZJyU7nqscBf1G6E=; b=bzrkYUU078JEASD5VUqCTsKuTUAJFTxF7+p6nZmtzhWgqHSBbwsvDPyiurvMSmyW5yt gSuyM8BIIvV/Dcenlh0BVOrBFHoVixozoMX9242TbUvb1oYYEht+zjj6Yjj6rIVRxyMy2 E0lLu6Fhfh2OR4BGJ5sk7T0ftd2VglzpjD8=
X-RZG-AUTH: :P3gLdkugevKirJkjH/RoTtk5THWq6nlFgKpnuMPeiu1/8loZf+4JHTB1Efz/5cQ=
X-RZG-CLASS-ID: mo00
Received: from [192.168.1.10] (188-192-154-28-dynip.superkabel.de [188.192.154.28]) by smtp.strato.de (cohen mo43) (RZmta 26.10 AUTH) with ESMTPA id Q04ea9n9AHIWGS ; Mon, 10 Oct 2011 19:39:26 +0200 (MEST)
Mime-Version: 1.0 (Apple Message framework v1244.3)
Content-Type: text/plain; charset="windows-1252"
From: Thomas Stockhammer <stockhammer@NOMOR.DE>
In-Reply-To: <13F059AA83B642759B6FFF44745AB29E@davidPC>
Date: Mon, 10 Oct 2011 19:39:27 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <530C6093-7047-4D6A-86D2-0CCF6C5D00E1@NOMOR.DE>
References: <13F059AA83B642759B6FFF44745AB29E@davidPC>
To: David Harrington <ietfdbh@comcast.net>
X-Mailer: Apple Mail (2.1244.3)
Cc: draft-ietf-fecframe-rtp-raptor@tools.ietf.org, fecframe-chairs@tools.ietf.org, fecframe@ietf.org
Subject: Re: [Fecframe] AD Review: draft-ietf-fecframe-rtp-raptor
X-BeenThere: fecframe@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion of FEC Framework <fecframe.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/fecframe>, <mailto:fecframe-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/fecframe>
List-Post: <mailto:fecframe@ietf.org>
List-Help: <mailto:fecframe-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/fecframe>, <mailto:fecframe-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2011 17:39:35 -0000
Dave, all thanks for the comments, please find inline responses. In addition to the comments, the references are separated in normative and informative. I do think we can move the RTP payload also to WGLC, but thus may have to happen in AVTCORE. Thanks Thomas > Can you get a revised ID asap? [T] A revised ID is prepared and has been uploaded here http://www.ietf.org/internet-drafts/draft-ietf-fecframe-rtp-raptor-05.txt > AD Review of draft-ietf-fecframe-rtp-raptor-04: > It would be good to use RFC2119 keywords in active voice - "The implementer SHOULD > select" (or is it the operator?) rather than "It is RECOMMENDED to select". > For example, I recommend changing "The (integer) rate SHALL be larger than 1000". > Whose responsibility is it to enforce this SHALL? MUST implementations > reject values less than 1000? (if implementations don't enforce this, I don't know > how you'll enforce this SHALL. Which means a user MAY choose a lower value; > therefore this isn't really a MUST. yada yada yada ... > So you should use active voice to be explicit about whose responsibility it is to enforce this MUST. (and similar to RFC 3665, MUST is for implementers; SHOULD is for users). [T] It is the responsibility of the operator to pick a value of 1000 at least. This has been made clear in the revision. > in 5.1.1, rate definition. > "rate: The RTP timestamp (clock) rate in Hz. The (integer) rate > SHALL be larger than 1000 to provide sufficient resolution to RTCP > operations. However, it is RECOMMENDED to select the rate that matches the rate of > the protected source RTP stream." The However in this paragraph makes it > sound like you recommend using the rate that matches (even if it is below 1000). > I recommend removing the "However," [T] Done > in 5.1.1, s/shall/SHALL/ [T] Done > "Restrictions on usage: This media type depends on RTP framing, and hence is only > defined for transfer via RTP [[RFC3550]]. Transport within other framing protocols > is not defined at this time. " Do we need the "at this time"? Is it envisioned this > media type will be exteneded for additional framing protocols at a later time? [T] Yes, this may indeed happen. We have seen similar generalization for other formats recently, such as the MPEG-2 TS. So it is considered important to avoid any confusion and make it clear that the registration is for RTP only. > in 12 s/recommended/RECOMMENDED/, s/may/MAY/g [T] Done > in 8, is Session Announcement Protocol (SAP) [RFC2947] the right reference? I saw no mention of SAP in 2947. [T] This is indeed wrong, it needs to be RFC2974. Thanks! > in 15.2, rfc2947 seems to refer to the wrong document. I think you > need 2974. [T] See above > in 1, "Repair data flows may be sent directly over a transport protocol > such as UDP, or they may be encapsulated within RTP." Is RTP the only > protocol that could be used to encapsulate flows? should this be "they may be > encapsulated within specialized transports for multimedia, such as RTP"? [T] Agreed! Despite nothing is defined today, it be in the future. I have changed accordingly. > s/FECs operates/FECs operate/ [T] Done > s/an FEC/a FEC/ [T] Done > Shepherd, Since AVT is the change controller, was this WGLC'd in AVT? [T] No this was not yet done. It would be good to send out the Raptor schemes for WGLC. Once this is done, I will send out a message to the AVT list reporting the status of the Raptor schemes and this payload format and ask if WGLC'd in AVT can be issued. Is this appropriate? Thomas > > Thanks, > David Harrington > Director, IETF Transport Area > ietfdbh@comcast.net (preferred for ietf) > dbharrington@huaweisymantec.com > +1 603 828 1401 (cell) > --- Dr. Thomas Stockhammer (CEO) || stockhammer@nomor.de || phone +49 89 978980 02 || cell +491725702667 || http://www.nomor-research.com Nomor Research GmbH - Sitz der Gesellschaft: München - Registergericht: München, HRB 165856 – Umsatzsteuer-ID: DE238047637 - Geschäftsführer: Dr. Thomas Stockhammer, Dr. Ingo Viering.
- [Fecframe] AD Review: draft-ietf-fecframe-rtp-rap… David Harrington
- Re: [Fecframe] AD Review: draft-ietf-fecframe-rtp… Thomas Stockhammer
- Re: [Fecframe] AD Review: draft-ietf-fecframe-rtp… Ali C. Begen (abegen)
- Re: [Fecframe] AD Review: draft-ietf-fecframe-rtp… Greg Shepherd
- Re: [Fecframe] AD Review: draft-ietf-fecframe-rtp… Ali C. Begen (abegen)
- Re: [Fecframe] AD Review: draft-ietf-fecframe-rtp… David Harrington