[Gen-art] Genart last call review of draft-ietf-spring-segment-routing-policy-14

David Schinazi via Datatracker <noreply@ietf.org> Fri, 12 November 2021 18:57 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 196C83A10E2; Fri, 12 Nov 2021 10:57:37 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: David Schinazi via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-spring-segment-routing-policy.all@ietf.org, last-call@ietf.org, spring@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.39.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <163674345706.30641.15234787368216619753@ietfa.amsl.com>
Reply-To: David Schinazi <dschinazi.ietf@gmail.com>
Date: Fri, 12 Nov 2021 10:57:37 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/66GU9k7Jb11jjBkHL9zpsD2RSFs>
Subject: [Gen-art] Genart last call review of draft-ietf-spring-segment-routing-policy-14
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Nov 2021 18:57:37 -0000

Reviewer: David Schinazi
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-spring-segment-routing-policy-14
Reviewer: David Schinazi
Review Date: 2021-11-12
IETF LC End Date: 2021-11-24
IESG Telechat date: Not scheduled for a telechat

Summary: Well written document. A few minor issues which should be trivial to
address.

Major issues: None

Minor issues:
- in s2.7, please specify if a higher number is more preferred or less preferred
- in s5.1, I would replace "A Segment-List of an explicit candidate path MUST
be declared invalid when:" with "A Segment-List of an explicit candidate path
MUST be declared invalid when any of the following is true:" (unless you mean
"all of the following"

Nits/editorial comments:
- the term headend is never defined. If it's a term of art in this area perhaps
a reference to the document that defines it would help? But if every reader is
expected to know the term because of the required context then that might be OK.