[Gen-art] Genart last call review of draft-ietf-dcrup-dkim-crypto-12

Pete Resnick <presnick@qti.qualcomm.com> Mon, 11 June 2018 16:22 UTC

Return-Path: <presnick@qti.qualcomm.com>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 72B3C131011; Mon, 11 Jun 2018 09:22:23 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Pete Resnick <presnick@qti.qualcomm.com>
To: <gen-art@ietf.org>
Cc: dcrup@ietf.org, ietf@ietf.org, draft-ietf-dcrup-dkim-crypto.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.81.2
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152873414342.2872.16681801090252484956@ietfa.amsl.com>
Date: Mon, 11 Jun 2018 09:22:23 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/FKe_TNTttc2AbdujeMPei53Z_yw>
Subject: [Gen-art] Genart last call review of draft-ietf-dcrup-dkim-crypto-12
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.26
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2018 16:22:32 -0000

Reviewer: Pete Resnick
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.

Document: draft-ietf-dcrup-dkim-crypto-12
Reviewer: Pete Resnick
Review Date: 2018-06-11
IETF LC End Date: 2018-06-12
IESG Telechat date: 2018-06-21

Summary: Nice simple document; Ready to go with nits.

Major issues:

None.

Minor issues:

None.

Nits/editorial comments:

Nit: You should update the 2119 template to the 8174 template.

Comment: If this kind of update is only going to happen every 6 or 7 years, I
guess it's fine, but all that this document really does is: - Trivially update
the ABNF - Add the algorithm to the registry - Update the normative
instructions to indicate that this new algorithm be used. That really could
have all be done with a registry update if the registry had a field for
normative instructions for use of the algorithm. I suppose it's no longer a big
deal to add one more document to the eight-odd-thousand RFCs, but still...

pr