Re: [Gen-art] Genart last call review of draft-ietf-sipcore-sip-push-21 - The pull request

Christer Holmberg <christer.holmberg@ericsson.com> Fri, 21 December 2018 08:51 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 09EEA1292F1 for <gen-art@ietfa.amsl.com>; Fri, 21 Dec 2018 00:51:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.365
X-Spam-Level:
X-Spam-Status: No, score=-4.365 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=a9YCZBYT; dkim=pass (1024-bit key) header.d=ericsson.com header.b=TqgLZOdN
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s4OCp5cusSQ3 for <gen-art@ietfa.amsl.com>; Fri, 21 Dec 2018 00:51:07 -0800 (PST)
Received: from sesbmg22.ericsson.net (sesbmg22.ericsson.net [193.180.251.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 58F1B130DE0 for <gen-art@ietf.org>; Fri, 21 Dec 2018 00:51:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1545382261; x=1547974261; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mx2COZiUt02Kwy5FohU8eGzOR8xxNxxZKqwfcvoD1IQ=; b=a9YCZBYTORCYmyEGll4mHPGvpL1WFGb/szLr9W0oyQblEVnhKKlzeV2OshuBr7yJ RaLzLW4y62pLzT+PVRMXrma8AuXP0BbVQFtQR0S/bwypPzRPhvgJ+b8KTh72I6Hi 4qU1xQn9R5tfoqvoW84EJLXYs4CV7e92FXVTzWZPqxA=;
X-AuditID: c1b4fb30-41b3a9e00000355c-a6-5c1ca9755ef2
Received: from ESESSMB502.ericsson.se (Unknown_Domain [153.88.183.120]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id A0.90.13660.579AC1C5; Fri, 21 Dec 2018 09:51:01 +0100 (CET)
Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 21 Dec 2018 09:50:59 +0100
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 21 Dec 2018 09:51:00 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mx2COZiUt02Kwy5FohU8eGzOR8xxNxxZKqwfcvoD1IQ=; b=TqgLZOdNeLBasaanNjbXPcip5YcAV/jQUgUoTLrvSJCzLlc7VVNyEjvhP2bBlCCdAfTXwwBX//v1CXXHavriwzj6w3h/UW5jHGaNc5ZTQ7PPGog83+sWNal4CwF8rp2FUnDJU9JgyNQyBICdffxgnKZy94zuKbPTkP2f1Rg9K2o=
Received: from AM6PR07MB5621.eurprd07.prod.outlook.com (20.178.91.14) by AM6PR07MB5542.eurprd07.prod.outlook.com (20.178.90.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.11; Fri, 21 Dec 2018 08:50:58 +0000
Received: from AM6PR07MB5621.eurprd07.prod.outlook.com ([fe80::5936:1370:d265:a754]) by AM6PR07MB5621.eurprd07.prod.outlook.com ([fe80::5936:1370:d265:a754%4]) with mapi id 15.20.1446.022; Fri, 21 Dec 2018 08:50:58 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Stewart Bryant <stewart.bryant@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "sipcore@ietf.org" <sipcore@ietf.org>, "iesg@ietf.org" <iesg@ietf.org>, "draft-ietf-sipcore-sip-push.all@ietf.org" <draft-ietf-sipcore-sip-push.all@ietf.org>
Thread-Topic: [Gen-art] Genart last call review of draft-ietf-sipcore-sip-push-21 - The pull request
Thread-Index: AQHUmQpKPNazzBQ3qk6/7LwW2P2v8A==
Date: Fri, 21 Dec 2018 08:50:58 +0000
Message-ID: <F6B5B4D9-C8DA-4B9E-9EE9-372FFCCAE293@ericsson.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.14.0.181208
authentication-results: spf=none (sender IP is ) smtp.mailfrom=christer.holmberg@ericsson.com;
x-originating-ip: [89.166.49.243]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM6PR07MB5542; 6:URPduobwT5hL1Sp2ewVmQuksk475bMvyc9tNOoq/aCjF9gAGwbZ8/vl30BSecHtMt+1YAJ0x7MXBCpPpCLEIZvt/GALcNHd5jGCmmYgjg7b90eV5rTiFPmh7mMGi+yxUKITuvr0HFCx6jCx2j5L1j8bZn4wadf1E9qbUxJgBQe3Nykvrzl8YQljDRhW9ScAhF0YA6X+iXnDx2Ib/pR9NV+mliDDJrL+pKp5W4mOgGoD5D1fY42mPjDj/s87YLc6iHcxcAEA9niXcsR2IDzIp7KneN0l2RNF/rQHpQ7ompOyMdwg+VlU+p9SSDTGAIKtxnD7F1K/Gf4175ycdeLG6cD0kbMGpCZj4VGp/PYO/hKgePgeYX7u0H9JWX/F18sjODFV+X9pHr1NkLUY0Bdki4b9JB5Z8bOb5HGjTSldkbRMvXQUQ2hDp1YtofN2rqDGmjlD+JsU724NTM+PaALzWqA==; 5:ggUz6HlbUSjRTIk1uGoyotOlcgigS20IFN3nMRN6iBBUozbXz7o68COl9patEhwR9AnDX4aNTKbC+cB5lBV3GaLWCIPn4/7EZdnupwCGbvUW0ZACOUDhJ1DwUKHHk+vwh/+XEjii0zu41yj2PpKXWDR45Wvd4BmOaKgp24CnvSk=; 7:C4AWeaThB2eMhZf8EaLDa20UKtOkd6UrFAtgJlMXYKc0aZzrfLZg1P2ioCUPhMMMTY6QX3ae4ogdCFYQJ/tetY4vmQkL1QCpqi/nUX1jgmAXG7KpslRC+LHF0NG6STUMGbexoB/RLeAXgQ0NylwvEw==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 68061edb-b673-4ab1-e040-08d667216d70
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:AM6PR07MB5542;
x-ms-traffictypediagnostic: AM6PR07MB5542:
x-microsoft-antispam-prvs: <AM6PR07MB5542F5A39D07B84EAC697B4193B80@AM6PR07MB5542.eurprd07.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(5005026)(6040522)(2401047)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(149066)(150057)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:AM6PR07MB5542; BCL:0; PCL:0; RULEID:; SRVR:AM6PR07MB5542;
x-forefront-prvs: 0893636978
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(366004)(376002)(346002)(189003)(199004)(105586002)(966005)(6246003)(2616005)(53936002)(54906003)(6306002)(54896002)(6512007)(106356001)(575784001)(236005)(110136005)(86362001)(476003)(6506007)(606006)(2906002)(82746002)(99286004)(83716004)(102836004)(97736004)(71200400001)(3846002)(6116002)(2501003)(7736002)(26005)(186003)(68736007)(58126008)(486006)(5660300001)(229853002)(345774005)(71190400001)(14454004)(6486002)(81156014)(8676002)(6436002)(33656002)(81166006)(25786009)(316002)(478600001)(44832011)(66066001)(256004)(14444005)(36756003)(39060400002)(8936002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR07MB5542; H:AM6PR07MB5621.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: Gn2/uXevWaWKQAANMxupXiigWzHQps46bpyzdhZGpgiJfR69GhP2kk7qvaGJjsHYQzE7oCn3Mk4VGA7CehCiWLbxP/O3odgq86FKvR65JmvBQqYYw1BHvZyiV4tbzoKelM4WpuCPSm/nS7mZ7FyRXnNV9Z4u+eOzvqamm15pxvncU5nc66luEmZhMrc50uOvKSGCoCkURkth/KD/ghvW4EuOw7xsZt2jjXzXcJ4lKYNvpzqS5RVl7DeoShAWAec8BIgsAXaJxkM6nRFhmZHM4FSrK2+edmMCERheDhalVyT1Q2HfjZezRDOgrhQfL7lF
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_F6B5B4D9C8DA4B9E9EE9372FFCCAE293ericssoncom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 68061edb-b673-4ab1-e040-08d667216d70
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2018 08:50:58.6418 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB5542
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHe885247S4nXeHmwWjowyvGK4oMy+WRD4ySyEnHpSUafsTFEx kzQoR6alqVNxxCxcauW1ZV7aQp1mml2sQNxUEiUjSy3LS25ngd9+z/P/P8/7/l9emhQZeB50 klzJKOSyFAnfkaqK6szyzWgQRwcsvXKXfu0wIen7hZ+UtHK9lJSu/G7hS4fMsjBeuF49KQjX ateICOKC4/F4JiUpk1H4h8Y4Js7cmULpOhPKWuqZ5uejLSMqQg404GAY7KqnipAjLcIvEUyV T9iLVQSvzXqCK7QEqAu1fOsIhUtIGFiJ4oRSAu53F/CsgghPI7j1cJtpmo+loNo8Ym274Eh4 +3iCtDKJ6xEs1uVa2RkzoOmvtNld8CXY/MNwdj9Ybrcg7ihv0Ha9sbEQn4TGrQXbGoTd4NdQ I8GtdIfPs3UElwaD9vkoybErzM9s2m7miv3B/KNPwM3KoFdntnu8YOSbxT7rCeN1KmSNBfgD HxqHTXaTL3wvL7fzWfhYpiE40xiC4QENnxN8wNi7JuA4GSytyxTH+0B300LZB0gwPSmwm8RQ M1pMliA/9Y4U6u3HIHEc9FVmqW2hncBUNUtx7cPw6Jk/5/aCMpVFwPEhuFZTa+dwqJhcRjs9 GkTrkCvLsLGpCUFBfowiKY5l0+R+ckbZgrZ/1ou2vwFP0fzcKQPCNJLsFnY/EEeLeLJMNjvV gIAmJS7C6ye2W8J4WXYOo0i7qMhIYVgD2ktTEnfhusgpWoQTZEommWHSGcV/laAdPPIRP1fZ vNhRkTo4cqb98u2xqdzVLk9FjEDPtHnohkQqb2Pz/rZ+XmVwS/Wcfmn8nOFeaKiuKQ/vwc6f 8gNj3arcyptCChsi3K/cyLGo8uauGg9qauTKjZCjTcunwzo7Ns6L1zqT3mXvqqZZZfhSpFfh l7s56mO1rq09xfSBsIZxCcUmygJ9SAUr+wcQW2gFVQMAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/VQ_hwzXV3Yh37xf-d-cJp9szkL0>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-sipcore-sip-push-21 - The pull request
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 08:51:09 -0000

Hi,

Based on the gen-art comments from Stewart, I have created a pull request for the suggested changes.

https://github.com/cdh4u/draft-sip-push/pull/31

Regards,

Christer

From: Christer Holmberg <christer.holmberg@ericsson.com>;
Date: Thursday, 20 December 2018 at 17.37
To: Stewart Bryant <stewart.bryant@gmail.com>;, "gen-art@ietf.org"; <gen-art@ietf.org>;
Cc: "sipcore@ietf.org"; <sipcore@ietf.org>;, "iesg@ietf.org"; <iesg@ietf.org>;, "draft-ietf-sipcore-sip-push.all@ietf.org"; <draft-ietf-sipcore-sip-push.all@ietf.org>;
Subject: Re: [Gen-art] Genart last call review of draft-ietf-sipcore-sip-push-21
Resent-From: <alias-bounces@ietf.org>;
Resent-To: Christer Holmberg <christer.holmberg@ericsson.com>;, <michael.arnold@metaswitch.com>;, "A. Mahoney" <mahoney@nostrum.com>;, Brian Rosen <br@brianrosen.net>;, Ben Campbell <ben@nostrum.com>;, "adam@nostrum.com"; <adam@nostrum.com>;, <aamelnikov@fastmail.fm>;, Brian Rosen <br@brianrosen.net>;
Resent-Date: Thursday, 20 December 2018 at 17.37

Hi Stewart,

Thank You for the review! Please see inline.

>Summary: A well written document with some minor points that could use a little
>attention.
>
>Major issues: None
>
>Minor issues:
>
>In Figure 1 the following is included:
>
>     REGISTER sip:alice@example.com SIP/2.0
>     Via: SIP/2.0/TCP alicemobile.example.com:5060;branch=z9hG4bKnashds7
>     Max-Forwards: 70
>     To: Alice <sip:alice@example.com>
>     From: Alice <sip:alice@example.com>;tag=456248
>     Call-ID: 843817637684230@998sdasdh09
>     CSeq: 1826 REGISTER
>     Contact: <sip:alice@alicemobile.example.com;
>       pn-provider=acme;
>       pn-param=acme-param;
>       pn-prid=ZTY4ZDJlMzODE1NmUgKi0K>
>     Expires: 7200
>     Content-Length: 0
>
> SB> However I don't at this stage of the text see the relationship between the
> SB> packet flow digram and the text that follows.

I could add the following:

“Below is an example of a SIP REGISTER request in Figure 1.”

=========

>   Contact: IESG (iesg@ietf.org<mailto:iesg@ietf.org>)
>
> SB> Is the whole IESG the most appropriate first point of contact?

That is what I was told :)

Note that I have used it also for other documents.

=========

>Nits/editorial comments:
>Presumably the references to RFC XXXX will be replaced by RFC <this RFC> but
>that does not seem to be noted in the text

I will add a note to the RFC editor about that.

        “[RFC EDITOR NOTE: Please replace RFCXXXX with the RFC number of this document.]”

========

> SB> As dicussed in [RFC4320] and [RFC4321], non-INVITE transactions must
> SB> Typo s/dicussed/discussed/

I will fix as suggested.

========

>   Example: pn-prid = 00fc13adff78512
>
>   For more information about the APNs Topic and device token:
>
> SB> Is the following part of the example? If so it could usefully be delimited
> SB> as such, otherwise, I don't understand why it is not a normal document
> SB> reference.
>
>   https://developer.apple.com/library/archive/documentation/NetworkingI
>   nternet/Conceptual/RemoteNotificationsPG/CommunicatingwithAPNs.html
>
> SB> Similarly in the following section

The link reference is not part of the example. Perhaps I could place to reference before the examples, to make that more clear?

Are you suggesting that I add the link to the reference section, similar to document references?

=========

Regards,

Christer