[Gen-art] Gen-ART Last Call review of draft-ietf-ospf-segment-routing-msd-17
Paul Kyzivat <pkyzivat@alum.mit.edu> Mon, 27 August 2018 17:33 UTC
Return-Path: <pkyzivat@alum.mit.edu>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BC7D130DD0; Mon, 27 Aug 2018 10:33:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0oVDWwZf7ury; Mon, 27 Aug 2018 10:33:09 -0700 (PDT)
Received: from alum-mailsec-scanner-3.mit.edu (alum-mailsec-scanner-3.mit.edu [18.7.68.14]) by ietfa.amsl.com (Postfix) with ESMTP id 0C7BD124BE5; Mon, 27 Aug 2018 10:33:05 -0700 (PDT)
X-AuditID: 1207440e-c13ff7000000162b-92-5b8435cfb26c
Received: from outgoing-alum.mit.edu (OUTGOING-ALUM.MIT.EDU [18.7.68.33]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by alum-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP id DB.DD.05675.FC5348B5; Mon, 27 Aug 2018 13:33:04 -0400 (EDT)
Received: from PaulKyzivatsMBP.localdomain (c-24-62-227-142.hsd1.ma.comcast.net [24.62.227.142]) (authenticated bits=0) (User authenticated as pkyzivat@ALUM.MIT.EDU) by outgoing-alum.mit.edu (8.13.8/8.12.4) with ESMTP id w7RHX2hM027343 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 27 Aug 2018 13:33:02 -0400
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
To: draft-ietf-ospf-segment-routing-msd.all@ietf.org
Cc: General Area Review Team <gen-art@ietf.org>
Message-ID: <c1fb54fe-5a52-a860-6778-54b5662e2e9c@alum.mit.edu>
Date: Mon, 27 Aug 2018 13:33:01 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsUixO6iqHvBtCXaYPsJTYv9v24zWlx99ZnF gcljyZKfTAGMUVw2Kak5mWWpRfp2CVwZH/fuYS64IlRx9twF5gbGpXxdjJwcEgImEtM3T2MB sYUEdjBJLPlt0sXIBWQ/ZJLYNXcfO0iCTUBLYs6h/2BFwgLeEruWPWMFsUWAmvtXrmUEsZkF 9CX+PlnMBGLzCthLLDh+EqyeRUBVYu+LfrC4qECaxN/OJYwQNYISJ2c+YYHoNZOYt/khM4Qt LnHryXwmCFteonnrbOYJjHyzkLTMQtIyC0nLLCQtCxhZVjHKJeaU5urmJmbmFKcm6xYnJ+bl pRbpGuvlZpbopaaUbmKEhCHfDsb29TKHGAU4GJV4eCdwtEQLsSaWFVfmHmKU5GBSEuVN1AIK 8SXlp1RmJBZnxBeV5qQWH2KU4GBWEuHd87k5Wog3JbGyKrUoHyYlzcGiJM7LZrI3SkggPbEk NTs1tSC1CCYrw8GhJMGrDow3IcGi1PTUirTMnBKENBMHJ8hwHqDhXCA1vMUFibnFmekQ+VOM lhwNF/onMXOcujcFSP55P3USsxBLXn5eqpQ4r6kJUIMASENGaR7cTFhaecUoDvSiMK8/SBUP MCXBTX0FtJAJaOGMVw0gC0sSEVJSDYzFN1ReHnET/cIapH316wYziaNn+6YbsSXNseCeriNy aMr5vbvP1Ge8/XjTjjeMf/H0Dao7tx/J4Kxln7SqaZ+QUOhu36Prtk3d7rZh+dyHha/uHV5R PqUlXrNWe6PYb+GGgumXbtrq3JF/Xvi0LfzTRo7GxRLWxzdtbJgbpcy289W9L/LFbs89lViK MxINtZiLihMBM4CsfAYDAAA=
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/YPpXxEJwgYhicGmcF2OPGv2j9zc>
Subject: [Gen-art] Gen-ART Last Call review of draft-ietf-ospf-segment-routing-msd-17
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Aug 2018 17:33:11 -0000
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Document: draft-ietf-ospf-segment-routing-msd-17 Reviewer: Paul Kyzivat Review Date: 2018-08-27 IETF LC End Date: 2018-08-29 IESG Telechat date: ? Summary: This draft is on the right track but has open issues, described in the review. Issues: Major: 0 Minor: 3 Nits: 1 1) MINOR: The abstract says: This document defines only one type of MSD, but defines an encoding that can support other MSD types. and later section 1 says: It also defines the Base MPLS Imposition MSD type. I can find nothing in the document that does this definition. It seems that this definition is actually done by draft-ietf-isis-segment-routing-msd, which is referenced. The text needs to agree with the structuring of the documents. 2) MINOR: Section 1 also says: Although MSD advertisements are associated with Segment Routing, the advertisements MAY be present even if Segment Routing itself is not enabled. I found nothing else in the document that elaborated on this. Further explanation is needed, in a section other than the introduction. 3) MINOR: The first paragraph of section 4 says: When Link MSD is present for a given MSD type, the value of the Link MSD MUST take preference over the Node MSD. When a Link MSD type is not signalled but the Node MSD type is, then the value of that *Link* MSD type MUST be considered as the corresponding *Node* MSD type value. This appears to have scrambled the use of Link and Node a bit. I think it is intended to say: When Link MSD is present for a given MSD type, the value of the Link MSD MUST take preference over the Node MSD. When a Link MSD type is not signalled but the Node MSD type is, then the value of that Node MSD type MUST be considered as the corresponding Link MSD type value. 4) NIT: Section 2 uses: 'The Type:' when documenting the "Type" field of the TLV, while sections 3 uses: 'Type:'. These ought to be consistent.
- [Gen-art] Gen-ART Last Call review of draft-ietf-… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Jeff Tantsura
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Jeff Tantsura
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Jeff Tantsura
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Jeff Tantsura