Re: [Gen-art] Gen-ART review of draft-ietf-trill-rfc6439bis-04

Jari Arkko <jari.arkko@piuha.net> Thu, 19 January 2017 07:42 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 22E61129508 for <gen-art@ietfa.amsl.com>; Wed, 18 Jan 2017 23:42:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.099
X-Spam-Level:
X-Spam-Status: No, score=-5.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-3.199] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pBp3vGADA-Pd for <gen-art@ietfa.amsl.com>; Wed, 18 Jan 2017 23:42:33 -0800 (PST)
Received: from p130.piuha.net (p130.piuha.net [IPv6:2a00:1d50:2::130]) by ietfa.amsl.com (Postfix) with ESMTP id 2B9F8120726 for <gen-art@ietf.org>; Wed, 18 Jan 2017 23:42:33 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 0B9B72CEBB; Thu, 19 Jan 2017 09:42:32 +0200 (EET) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ixGlOZt44PQO; Thu, 19 Jan 2017 09:42:31 +0200 (EET)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 37EBF2CCAF; Thu, 19 Jan 2017 09:42:31 +0200 (EET) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_87B9B704-A644-4659-B076-5AB15D6611F8"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <CAF4+nEGACaLibMcA5Xszz76xPmbdca22pEGh7bF7G=EFXHyhtg@mail.gmail.com>
Date: Thu, 19 Jan 2017 09:42:26 +0200
Message-Id: <E14D6ACA-D143-4F81-9060-8CC9E757D968@piuha.net>
References: <7594FB04B1934943A5C02806D1A2204B4BF7D017@ESESSMB209.ericsson.se> <CAF4+nEGACaLibMcA5Xszz76xPmbdca22pEGh7bF7G=EFXHyhtg@mail.gmail.com>
To: Donald Eastlake <d3e3e3@gmail.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/gq0Hq_PGJUdAGCnSU2i-KE8pfrY>
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-trill-rfc6439bis.all@tools.ietf.org" <draft-ietf-trill-rfc6439bis.all@tools.ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-trill-rfc6439bis-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jan 2017 07:42:36 -0000

Thanks for the review, Christer, and responses, Donald!

There’s some discussion to be had here I guess with acronyms
etc but I have posted a no-objection position for today’s IESG telechat.

Jari

On 19 Jan 2017, at 06:27, Donald Eastlake <d3e3e3@gmail.com> wrote:

> Hi Christer,
> 
> On Wed, Jan 18, 2017 at 6:07 PM, Christer Holmberg
> <christer.holmberg@ericsson.com> wrote:
>> I am the assigned Gen-ART reviewer for this draft. The General Area Review
>> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
>> the IETF Chair.  Please treat these comments just like any other last call
>> comments.
>> 
>> For more information, please see the FAQ at
>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>> 
>> 
>> Document:
>> draft-ietf-trill-rfc6439bis-04.txt
>> 
>> Reviewer:                                        Christer Holmberg
>> Review Date:                                  18.01.2017
>> IETF LC End Date:                          10.01.2017
>> IESG Telechat date: (if known)   19.01.2017
>> 
>> 
>> Summary:                                       The document is almost ready
>> for publication, but there are some editorial nit that I’d like the authors
>> to address.
>> 
>> 
>> Major issues:                                 None
>> 
>> 
>> Minor issues:                                 None
>> 
>> 
>> Nits/editorial comments:
>> 
>> 
>> Q1:        In the Abstract and Introduction, please expand “TRILL” on first
>> occurrence.
> 
> OK.
> 
>> Also, in general, the document does expand some acronyms on first
>> occurrence, while it does not expand others. Can the authors verify that all
>> the acronyms NOT expanded so called “well known” acronyms?
> 
> Can you point to one that isn't well known?
> 
>> Q2:        Related to Q1. In section 1.2, you do expand TRILL, but it is
>> different than in RFC 6439. Is the intention really to change the meaning of
>> “TRILL”?
> 
> It seems misleading to just say that it expands it differently when it
> expands it exactly the same way. It's just that is also provides a
> second equally good or, in the opinion of some people, better
> expansion. There has been some effort to change the name of the TRILL
> working group to the second version, which should not be too big a
> deal as the acronym is the same. And I don't see how it hurts anything
> to have both in this document.
> 
>> Q3:        In the Abstract and Introduction, I think it would be good to
>> have a reference to “Appointed Forwarder”.
> 
> OK.
> 
>> Q4:        The end of the introduction contains the following text:
>> 
>> “This documents obsoletes [RFC6439], updates [RFC6325], and updates
>> [RFC7177], as described in Appendix B.”
>> 
>> That’s all good, but I think it would be good to have a few words also in
>> the Introduction, explaining exactly what is obsoleted and updated.
> 
> OK, especially as it is more like it incorporates RFC 6439 to simplify
> things and reduce the number of documents that implementers have to
> look at.
> 
>> Q5:        The end of the introduction contains the following text:
>> 
>> “It also includes reference implementation details.
>>              Alternative implementations that interoperate on the wire are
>>              permitted.”
>> 
>> Is the last sentence really needed? I don’t think an RFC can mandate the
>> usage of one specific implementation of the RFC.
> 
> Well, I think the TRILL WG likes wording similar to that. It also
> occurs in at least RFC 6325, the TRILL base protocol specification.
> 
>> Q6:        In the Security Considerations, please use “This document”
>> instead of “This memo”, in order to have consistent terminology.
> 
> OK.
> 
> Thanks,
> Donald
> ===============================
> Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
> 155 Beaver Street, Milford, MA 01757 USA
> d3e3e3@gmail.com
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art