Re: [Gen-art] [bess] Genart last call review of draft-ietf-bess-evpn-df-election-framework-06

Alissa Cooper <alissa@cooperw.in> Wed, 09 January 2019 16:22 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 64299130EEE; Wed, 9 Jan 2019 08:22:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=OJtTIuzx; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=SiA+4bBL
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dZ5mIouka4Wb; Wed, 9 Jan 2019 08:22:52 -0800 (PST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8F423130EE8; Wed, 9 Jan 2019 08:22:52 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 973BC222C9; Wed, 9 Jan 2019 11:22:51 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 09 Jan 2019 11:22:51 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm2; bh=B jDC1efMDgcIMOTGkd0s03rY3g+QaK4Duxn02dvGQ78=; b=OJtTIuzxX7rbmT4XL LgQwS8rDQ7ApuiBL/CZ+NbQ2UQQU9V+0+jSiRYqQdobflT0bZSoDGAnh4u46wmW/ IpXzicbkul4oGSSm4lMqT79WB8OAFsNeDuFtW8AsD1Q6j1aiihde6Of+vI1N93im fkvah4o+DvexPFq5zMc9PZfYa2ArdY3yddB5sAh2K+GcdLuCctL3HdAcM8iyW5IZ qtza/h4Eh0BN6CaKpuRnUbfHKlplFWLhbGGjGnNddpg54NKtH6a0ckcH7EhiUeAF UkvBiDUMKNu4biaw1T4dYwE2k8BDMhasqdIabzyzNnaKoMwAnDr0LJ3sQRZtCYuL 1tQeA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=BjDC1efMDgcIMOTGkd0s03rY3g+QaK4Duxn02dvGQ 78=; b=SiA+4bBLSTzjC5+uPPVuhC7m6igqQVTkHqo9cjKHOT6CPYffK5eRJ+C8y eNdy4oNWVIEgqag+Ck3rHRvnwOEeWBAhTuhUW2K7GITXSHAonV4E9aCKJcRq+KR+ V/8ei3zf30sk39mosEbUAtxa1vsX64Mq9WNkKX8EHDz1459mY4PIrzgSwuApYJkz tVMsudwg4/zxG58iXaeoyUp8/YiFTgYjeWQd7NJJ64DhQbFbMSHzdxZB+VBMJoYY Kk9vErowJf1IK+op7P7uVxexue49ImjGQSQ3iQF5c8qyiJtrCoQB6OevaRq50MOI JXA4bFg/OwRczUvCz4GuI+l0tpvmg==
X-ME-Sender: <xms:2x82XGFOUHuh_7Z2lFEoW4M08KyQ0sJAb1XSDwXiBmylD4YMNCBe7w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfedugdekkeculddtuddrgedtkedrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptggguffhjgffgffkfhfvofesthhqmhdthhdtjeenucfhrhhomheptehlihhs shgrucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucffohhmrg hinhepihgvthhfrdhorhhgnecukfhppedujeefrdefkedruddujedrkeegnecurfgrrhgr mhepmhgrihhlfhhrohhmpegrlhhishhsrgestghoohhpvghrfidrihhnnecuvehluhhsth gvrhfuihiivgeptd
X-ME-Proxy: <xmx:2x82XO5Uml0TdDxkU_Qw61kuRaJzFp41ifz5qoSYHz5M0cEewtSw7Q> <xmx:2x82XPwHF033eWgRfV4WF0Q7AqLT5GsQuMezaKpUyxvclfca4vp4SA> <xmx:2x82XM0t_huOutnghQoMKRln7gjMIxVWnW1ICnXyprrAi2Nzo6wMIg> <xmx:2x82XDxL6NHza3zXozjLFeMb0POPXWpJDRAwPonC-m9PrnzqAhjpNg>
Received: from rtp-alcoop-nitro5.cisco.com (unknown [173.38.117.84]) by mail.messagingengine.com (Postfix) with ESMTPA id CC03C100E5; Wed, 9 Jan 2019 11:22:50 -0500 (EST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <69F9BBF9-C52E-45F9-BE65-E466140D6823@nokia.com>
Date: Wed, 9 Jan 2019 11:22:49 -0500
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-bess-evpn-df-election-framework.all@ietf.org" <draft-ietf-bess-evpn-df-election-framework.all@ietf.org>, "bess@ietf.org" <bess@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1EB29FEF-B5D2-4FB2-9AD6-2D3AC476499A@cooperw.in>
References: <154480398817.30540.8239762064497446504@ietfa.amsl.com> <69F9BBF9-C52E-45F9-BE65-E466140D6823@nokia.com>
To: "Rabadan, Jorge (Nokia - US/Mountain View)" <jorge.rabadan@nokia.com>, Francesca Palombini <francesca.palombini@ericsson.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/rpYg5Im7vbLoi6BaUVSwTxnOL-U>
Subject: Re: [Gen-art] [bess] Genart last call review of draft-ietf-bess-evpn-df-election-framework-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 16:22:54 -0000

Francesca, thank you for your reviews. Jorge, thanks for your responses. I entered a No Objection ballot but did raise a further question about this document updating RFC 7432.

Alissa

> On Dec 19, 2018, at 5:19 AM, Rabadan, Jorge (Nokia - US/Mountain View) <jorge.rabadan@nokia.com>; wrote:
> 
> Hi Francesca,
> 
> Thank you very much for your review.
> Please see in-line how we are resolving your comments in the next revision (07, to be published asap).
> 
> Thanks.
> Jorge
> 
> -----Original Message-----
> From: BESS <bess-bounces@ietf.org>; on behalf of Francesca Palombini <francesca.palombini@ericsson.com>;
> Date: Friday, December 14, 2018 at 5:13 PM
> To: "gen-art@ietf.org"; <gen-art@ietf.org>;
> Cc: "draft-ietf-bess-evpn-df-election-framework.all@ietf.org"; <draft-ietf-bess-evpn-df-election-framework.all@ietf.org>;, "ietf@ietf.org"; <ietf@ietf.org>;, "bess@ietf.org"; <bess@ietf.org>;
> Subject: [bess] Genart last call review of draft-ietf-bess-evpn-df-election-framework-06
> 
>    Reviewer: Francesca Palombini
>    Review result: Ready with Nits
> 
>    I am the assigned Gen-ART reviewer for this draft. The General Area
>    Review Team (Gen-ART) reviews all IETF documents being processed
>    by the IESG for the IETF Chair.  Please treat these comments just
>    like any other last call comments.
> 
>    For more information, please see the FAQ at
> 
>    <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.
> 
>    Document: draft-ietf-bess-evpn-df-election-framework-06
>    Reviewer: Francesca Palombini
>    Review Date: 2018-12-14
>    IETF LC End Date: 2018-12-18
>    IESG Telechat date: Not scheduled for a telechat
> 
>    Summary: This draft is basically ready for publication, but has nits that
>    should be fixed before publication.
> 
>    Major issues: N/A
> 
>    Minor issues:
> 
>    I agree with the reviewers comments saying that this document should update
>    RFC7432 and RFC8124. In particular, quoting RFC2232
>    (https://tools.ietf.org/html/rfc2223#section-12):
> 
>       [...] A document that
>       merely updates an earlier document cannot stand on its own; it is
>       something that must be added to or inserted into the previously
>       existing document, and has limited usefulness independently.  The
>       terms Supercedes and Replaces are no longer used.
> 
>       Updates
> 
>          To be used as a reference from a new item that cannot be used
>          alone (i.e., one that supplements a previous document), to refer
>          to the previous document.  The newer publication is a part that
>          will supplement or be added on to the existing document; e.g., an
>          addendum, or separate, extra information that is to be added to
>          the original document.
> 
>    (Yes, RFC2232 is obsolete, but I could not find the same text in the more
>    recent RFC7322)
> 
> [JORGE] I think this document "can stand on its own" and it is "useful independently" of RFC7432, although the latter document is a normative reference of course. Please see the resolution to Adrian's comment: https://www.ietf.org/mail-archive/web/bess/current/msg03760.html 
> Martin, please let us know if you are not okay with our resolution.
> 
> 
>    Nits/editorial comments:
> 
>      "but they do not require
>       any changes to the EVPN Route exchange and have minimal changes to
>       their content per se."
> 
>    * what does their refer to?
> [JORGE] changed to the following for clarity:
> "These mechanisms do involve changes to the Default DF Election algorithm, but they do not require any changes to the EVPN Route exchange and have minimal changes in the EVPN routes."
> 
>    * Section 2.2.2: expand MAC-VRF on first usage for readability (or add a
>    reference to its definition)
> [JORGE] added to the terminology section.
> 
>    * Figure 3: add a definition for ANY STATE (the figure is clear, but for
>    consistency I would add that in the text as well)
> [JORGE] Added:
> "5.  ANY_STATE: Refers to any of the above states."
> 
>    * Figure 3: add "or" between VLAN_CHANGE, RCVD_ES, LOST_ES (again, not
>    necessary, suggested for readability of the figure)
> [JORGE] done, thx
> 
>    * Section 3.1: the term "re-entering" needs clarifying: I would consider a loop
>    as re-entering the state, but from bullet 8. it seems like you don't.
> [JORGE] good point. Changed 8 to:
> "8.  DF_CALC on VLAN_CHANGE, RCVD_ES or LOST_ES: do *****as in transition 7.******"
> 
>    * suggestion for figure 4 (otherwise it looks like there are 2 fields Bitmap of
>    1B each):
> 
>          0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>         +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>         | Type=0x06     | Sub-Type(0x06)| RSV |  DF Alg |    Bitmap     ~
>         +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>         ~               |            Reserved                           |
>         +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> [JORGE] done, thanks.
> 
> 
>    * Section 3.2: why was Bit 0 left unassigned in Bitmap?
> [JORGE] there are implementations of https://tools.ietf.org/html/draft-ietf-bess-evpn-pref-df-02 using that bit.
> 
>    * IANA considerations: I think you want to specify that the policy for Alg 31
>    is Experimental use (right now the text describing the policy only says "RFC
>    required", with no distinction for different values).
> [JORGE] ok, done.
> 
> 
>    _______________________________________________
>    BESS mailing list
>    BESS@ietf.org
>    https://www.ietf.org/mailman/listinfo/bess
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art