Re: [Ice] ICE PAC: When to start the timer waiting for possible peer reflexive candidates?

Christer Holmberg <christer.holmberg@ericsson.com> Tue, 30 April 2019 10:30 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: ice@ietfa.amsl.com
Delivered-To: ice@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A35E1202F3 for <ice@ietfa.amsl.com>; Tue, 30 Apr 2019 03:30:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.002
X-Spam-Level:
X-Spam-Status: No, score=-2.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cdDEZ-yIfyZn for <ice@ietfa.amsl.com>; Tue, 30 Apr 2019 03:30:54 -0700 (PDT)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0608.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8BCA81202E1 for <ice@ietf.org>; Tue, 30 Apr 2019 03:30:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QsTzT1vseD7p1n+TDibLEoFGVrJLPad0phM7lA3gmPY=; b=akCTIovrSil0ypzUnweMLWIFMBeFTgVAfpmtMlEG0cxpDiw4EpbybXZ0qjggJm5DxFfic5QxExOnFfeyL6NNdsVhpFRI0VVlBceYWrAJa87H8T0iNfPIPCrpgKmbX3OglMal9RnAZqLoAOrtIDSMjpctRl2Z/nhtXIAv9s367iY=
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com (10.170.245.23) by HE1PR07MB3337.eurprd07.prod.outlook.com (10.170.247.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.8; Tue, 30 Apr 2019 10:30:51 +0000
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::c999:f848:9abc:d321]) by HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::c999:f848:9abc:d321%6]) with mapi id 15.20.1856.008; Tue, 30 Apr 2019 10:30:51 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Justin Uberti <juberti@google.com>
CC: Roman Shpount <roman@telurix.com>, Nils Ohlmeier <nohlmeier@mozilla.com>, "ice@ietf.org" <ice@ietf.org>
Thread-Topic: [Ice] ICE PAC: When to start the timer waiting for possible peer reflexive candidates?
Thread-Index: AQHU+0CsHVyA1kKNxkeJ+j5BwMef3qZNJFeAgAA9yAD//8/IgIAAFleAgAAtFICAAMN1gIAAVFgAgABZAV2AAAWpgIABXUofgAIe4wCAALbUAIAAV6UAgAFE6oA=
Date: Tue, 30 Apr 2019 10:30:51 +0000
Message-ID: <46390078-DE3B-456B-87AC-61AE3C3DF035@ericsson.com>
References: <3A66B735-03C9-41FF-95AD-500B0D469C80@ericsson.com> <CAD5OKxsMgNTQPNP4Ni72H+yD4iUeyNK+x6CSvdBApGnPTpr_vg@mail.gmail.com> <A4EC3C01-4D7D-45DF-876D-E58706F74866@ericsson.com> <CAD5OKxt8tDemkK=v4X1gjwJGLYrxcd95S7uV53_fsga6grZ_rA@mail.gmail.com> <30518269-CA9D-4F50-8CE3-062A01DBCD7F@mozilla.com> <CAD5OKxvmRK8Xzu4FSRv3Lgdg-VrrufzGhjAdSmfcLLkrm-jtjw@mail.gmail.com> <0AD3077C-74FA-4585-942A-375B83B3A7A0@ericsson.com> <CAD5OKxsgpf7Hv_nxFOZFwfNk7-_xNRzmoPTA2bZCqZo3wzudKQ@mail.gmail.com> <HE1PR07MB316172053751D307F83DE0EB933E0@HE1PR07MB3161.eurprd07.prod.outlook.com> <CAD5OKxu332E8vzdc4dt09NxXGf9Cr2izwECDAQjc7V_YDx3r5w@mail.gmail.com> <HE1PR07MB316189447ED302BEC5021946933F0@HE1PR07MB3161.eurprd07.prod.outlook.com> <CAOJ7v-3Dv4N5j0KykxQf-gHQfvJ9x-VzbTTTcdJyfgYgcdYy5A@mail.gmail.com> <HE1PR07MB3161E4496E7BDC5FF419CCE793390@HE1PR07MB3161.eurprd07.prod.outlook.com> <CAOJ7v-3JkrYnWpghusRytVvTn1u7OibL9J3NyVh+ia9neSyuHA@mail.gmail.com>
In-Reply-To: <CAOJ7v-3JkrYnWpghusRytVvTn1u7OibL9J3NyVh+ia9neSyuHA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.18.0.190414
authentication-results: spf=none (sender IP is ) smtp.mailfrom=christer.holmberg@ericsson.com;
x-originating-ip: [89.166.49.243]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fee162a0-704e-4726-c51d-08d6cd56eb5b
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:HE1PR07MB3337;
x-ms-traffictypediagnostic: HE1PR07MB3337:
x-microsoft-antispam-prvs: <HE1PR07MB33370FC87FEEA12DACA3F7D6933A0@HE1PR07MB3337.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 00235A1EEF
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(366004)(396003)(346002)(39860400002)(189003)(199004)(76176011)(66446008)(64756008)(478600001)(66556008)(53936002)(54906003)(6512007)(14454004)(99286004)(33656002)(36756003)(66066001)(97736004)(93886005)(316002)(58126008)(66476007)(7736002)(6246003)(305945005)(82746002)(4326008)(14444005)(256004)(486006)(476003)(44832011)(71200400001)(71190400001)(25786009)(6916009)(8676002)(102836004)(2616005)(6116002)(26005)(6436002)(3846002)(6506007)(229853002)(446003)(11346002)(186003)(6486002)(2906002)(81156014)(81166006)(86362001)(68736007)(83716004)(8936002)(76116006)(66946007)(5660300002)(73956011); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB3337; H:HE1PR07MB3161.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: hH6DP6e6KCjZx/B+OA8eQScG3wR5CmT076mZfYFkhA5XGtsmylt1NITYvbZ4YFoxmY4LRngJcgI0igbldUo+Utdg4BkUBg/UtFaZOzeADmZCOgWvHoLEh+FRUiDotk1bO4/diLzAGUZhC0hhfPFBas52NNwETyitWHucuvO2PS7ruxz0+0mHepnByw+MF/TCiyNy25LA1Ti2jSQkJJg85BykwqcdrBwXAW+hJuV93eo2ds8T5VJisZ4Fs8PX+MWDf1q/hs0v1xqsay4SQK4myM5h/UMmovR9lH2KDJIBq3dtm/1aSvSOGNtVeCUGv6eBGqRdJsaf4J0YGqzMlUIpR9fxovmsAcqD3K2WrS95wxtnQcaA6Zeye+jdWlYTk3pYvEG0XbCuTWZi/dGWRXGLBq0FZC++UfH4LGA7J0ekHI8=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E0AC068F9A0F0744B8B9DF9F912141E4@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fee162a0-704e-4726-c51d-08d6cd56eb5b
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 10:30:51.7856 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3337
Archived-At: <https://mailarchive.ietf.org/arch/msg/ice/Rk4JULYrXwgIt_k-ZxAoJyJtoBM>
Subject: Re: [Ice] ICE PAC: When to start the timer waiting for possible peer reflexive candidates?
X-BeenThere: ice@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Interactive Connectivity Establishment \(ICE\)" <ice.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ice>, <mailto:ice-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ice/>
List-Post: <mailto:ice@ietf.org>
List-Help: <mailto:ice-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ice>, <mailto:ice-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Apr 2019 10:30:58 -0000

Hi,

...

>>> Overall I think the Firefox approach makes the most sense - the PAC timer 
>>> starts when you have either a local or remote candidate. 
>>
>> That would mean that PAC becomes a the-maximum-time-to-run-ICE timer. If that's what people want, fine.
>
> Maybe this is what you meant, but I think it's a "minimum-time-to-run-ICE" timer. 

I guess so, yes.

However, as I said before, I think an agent shall still be allowed to stop earlier, and not be required to wait for peer reflexive candidates, if it already has working pairs.

>> However, you can have a local candidate long before the remote peer gets it, so starting the timer once you 
>> have a candidate sounds strange to me. I think we should at least wait until the agent has sent the agent to the peer. 
>
> This is an important observation - we don't want to start the timer until we think both us and the peer agent are running 
> ICE processing (e.g., if we just gathered candidates but didn't send an offer, we shouldn't start the timer). I'm not totally sure 
> what you meant above,

That is one example: gather candidates but don't yet send an offer.

> but one way to ensure we're in the right state would be to start the timer when both of the below are true:
> 1) We have sent or received an answer.
> 2) Local candidate gathering has completed (including the case when zero candidates have been gathered).
>
> #2 may not be strictly necessary, but gives us more flexibility in trickle cases if gathering takes a very long time (10+ seconds) for some reason.

What about starting the timer after the agent has sent its last set of candidates? That would cover both trickle and non-trickle: in non-trickle there is only one set of candidates, and in trickle it doesn't matter how long it takes to provide all candidates since the timer doesn’t start until the last set of candidates have been sent?

Regards,

Christer