Re: Opsdir last call review of draft-ietf-curdle-cms-ecdh-new-curves-07

Russ Housley <housley@vigilsec.com> Fri, 26 May 2017 19:34 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6AC72129B4C for <ietf@ietfa.amsl.com>; Fri, 26 May 2017 12:34:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.001
X-Spam-Level:
X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 tests=[BAYES_40=-0.001, HTML_MESSAGE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ez1tSw52JTa3 for <ietf@ietfa.amsl.com>; Fri, 26 May 2017 12:34:32 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C998A128BA2 for <ietf@ietf.org>; Fri, 26 May 2017 12:34:32 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 2886D3004AA for <ietf@ietf.org>; Fri, 26 May 2017 15:34:32 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qqHO44VuWt5G for <ietf@ietf.org>; Fri, 26 May 2017 15:34:30 -0400 (EDT)
Received: from new-host-6.home (pool-108-45-101-150.washdc.fios.verizon.net [108.45.101.150]) by mail.smeinc.net (Postfix) with ESMTPSA id 2DC0C30029C; Fri, 26 May 2017 15:34:30 -0400 (EDT)
From: Russ Housley <housley@vigilsec.com>
Message-Id: <2FCD7FC6-1CF6-4B4B-8D2E-6043EC6FE268@vigilsec.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_EA2DDDBE-2388-4EAD-832E-E31DE0D1D28D"
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: Opsdir last call review of draft-ietf-curdle-cms-ecdh-new-curves-07
Date: Fri, 26 May 2017 15:34:29 -0400
In-Reply-To: <149553176028.29418.18414274218431090509@ietfa.amsl.com>
Cc: ops-dir@ietf.org, curdle <curdle@ietf.org>, IETF <ietf@ietf.org>
To: Stefan Winter <stefan.winter@restena.lu>
References: <149553176028.29418.18414274218431090509@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3273)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/2sPEpSLTnO7tYjsWhDTSSA-e7_8>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 May 2017 19:34:35 -0000

> On May 23, 2017, at 5:29 AM, Stefan Winter <stefan.winter@restena.lu> wrote:
> 
> Reviewer: Stefan Winter
> Review result: Has Nits
> 
> Nits: 
> 
> * 2.1 starts with "...  based on a one-way hash function described in
> ANS X9.63 [X963]." s/ANS/ANSI/

The American National Standards Institue (ANSI) is an organization.  See https://www.ansi.org/ <https://www.ansi.org/>.

American National Standards (ASN) are documents.  In this case, ANS X9.63 is being referenced.

I will expand ANS to American National Standard to avoid future confusion.

> 
> * Chapter 7 defines six OIDs (secg-scheme 11 1...3 and smime-alg
> TBD1...3) and also includes the base OIDs under which these new OIDs
> are attached (secg-scheme and smime-alg). Those two are not defined in
> this document, but the text in chapter 7 suggests so.

Section 7 includes:

      secg-scheme OBJECT IDENTIFIER ::= {
        iso(1) identified-organization(3) certicom(132) schemes(1) }

which is followed by 3 OIDs assigned in that arc.


Section 7 also includes:

      smime-alg OBJECT IDENTIFIER ::= {
         iso(1) member-body(2) us(840) rsadsi(113549) pkcs(1)
         pkcs-9(9) smime(16) alg(3) }

which is followed by three TBD OID values that need to be assigned by IANA once the document is approved.

> Maybe it would be a bit clearer if the text stated explicitly which of
> the OIDs in the chapter are NEW, and which ones already exist and are
> provided for reference/context.

Once IANA makes the three assignments, all of the OID values will appear in the RFC.

Russ