[Iot-directorate] Iotdir telechat review of draft-ietf-core-echo-request-tag-12

Eliot Lear via Datatracker <noreply@ietf.org> Fri, 05 February 2021 17:09 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: iot-directorate@ietf.org
Delivered-To: iot-directorate@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E92D3A138C; Fri, 5 Feb 2021 09:09:49 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Eliot Lear via Datatracker <noreply@ietf.org>
To: iot-directorate@ietf.org
Cc: core@ietf.org, draft-ietf-core-echo-request-tag.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.25.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161254498927.30549.15609771383242038227@ietfa.amsl.com>
Reply-To: Eliot Lear <lear@cisco.com>
Date: Fri, 05 Feb 2021 09:09:49 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/iot-directorate/-KCkHKIPxbtKqXQ84-BCQ9ryaqY>
Subject: [Iot-directorate] Iotdir telechat review of draft-ietf-core-echo-request-tag-12
X-BeenThere: iot-directorate@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Mailing list for the IoT Directorate Members <iot-directorate.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/iot-directorate>, <mailto:iot-directorate-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/iot-directorate/>
List-Post: <mailto:iot-directorate@ietf.org>
List-Help: <mailto:iot-directorate-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/iot-directorate>, <mailto:iot-directorate-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Feb 2021 17:09:49 -0000

Reviewer: Eliot Lear
Review result: Ready with Issues

All in all, a very nice piece of work.  I'm not reviewing for other than IoT
issues.

An issue in Section 2.2.1 (you decide if it's minor or major or really just a
question):

I do not understand why the Echo option requires opaque data, and why this
should not be standardized, as it seems that the behavior you are seeking is
standardized.   As you give two example methods in the draft, why not reserve a
few extra bits to specify which method is in use?  This would also allow you to
drop the necessary callback routines in libraries.

Nit:

The last sentence in 2.2: is this meant to be limited to OSCORE or all uses of
DTLS?  I found the inner/outer text confusing, and that a diagram might
actually help.