Re: [Jmap] Benjamin Kaduk's Discuss on draft-ietf-jmap-websocket-04: (with DISCUSS and COMMENT)

Ken Murchison <murch@fastmail.com> Mon, 20 January 2020 20:02 UTC

Return-Path: <murch@fastmail.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 32307120274; Mon, 20 Jan 2020 12:02:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fastmail.com header.b=W99jclG7; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=yFTwaGkv
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b7fwFkPD6fOR; Mon, 20 Jan 2020 12:02:13 -0800 (PST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9075F120020; Mon, 20 Jan 2020 12:02:13 -0800 (PST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BD18421F30; Mon, 20 Jan 2020 15:02:12 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 20 Jan 2020 15:02:12 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=X 9nEWYCycBdKORRDFwaWaPC1xLwi6iXzNzuSDGwAl0k=; b=W99jclG7uhqLHc88C 2Vmzw5+Y9VZI0xN6gn3GQyF7UnzBuFSEvjQpd1VIGfw+VLSSbEYs43rnDsqCcJJN QYJrd8deNdFH94KWL+AzLQrFEN0AvWuSIPunzhSKv0F3ImC4c8A6kCAyEY2UM7Kd Tx5/ohaIybxdlIsQr+nL1dkYr/tTcCmCyRSAIf2uSgyiACG9mkJTsAzxegDA8aP+ 6pCmM6Wk5EaZa0XU+Je/xWq4OtAVzShAiyjXqm41kdwd5DXcbeWRst4XZInU80fC ymlUy3Hy/oByLO3i8bOY9TP+tl3nZ5OMjQHkJ9J/frPUXiFG1/JA+PQldpmACsCa TzMEQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=X9nEWYCycBdKORRDFwaWaPC1xLwi6iXzNzuSDGwAl 0k=; b=yFTwaGkvf9n0ZhscBiKWK+87iPLQbpXtjybZzGwnbBPftKT8fpPck2lAF W31cj8eNKSVhVzyykdpzApnLkDBFfMQlF+VaQ0EKwsVpP0gTB73ELqAVxok14LIr GK5/nlpDEl6QMXcHx90ZEi9Xyke6ecCUfZkkUCySmBzl0q12Q4BbUlSjKnqQBHFA 79rT7NyxESW/qmAndCqSl1WEVZaw5eXc/OG8h+bH5fSjB+HDk4rkvlpO7IBtQmio KH73AaIS95YVxxngOCEVylD7jSIJHH1YVRnt9TX00Xoke2up5Z7ZsqeckKPPZcyp JSh2neNXlHxmPZoOuasrBs0f57WWQ==
X-ME-Sender: <xms:RAcmXqOLUwUQJCeHLg0K8tx5EGJgNjQX5k_OArrTjFVwj1eIjVLbqA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeigdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhffkffgfgggjtgfgsehtkeertddtfeejnecuhfhrohhmpefmvghnucfo uhhrtghhihhsohhnuceomhhurhgthhesfhgrshhtmhgrihhlrdgtohhmqeenucfkphepje egrdejjedrkeehrddvhedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepmhhurhgthhesfhgrshhtmhgrihhlrdgtohhm
X-ME-Proxy: <xmx:RAcmXlTT9Sm8L5X56g-hO5tSiOND1szFb4aijIyXdUvjTOe98gmLrQ> <xmx:RAcmXkB893Ew96v1Wzuug5ol6pxUzP1cwJQPzHc764dokrz16_eqbA> <xmx:RAcmXsgGlcOuRVtYxlRLvPhFWu_VBoVoV3gyMxFm7MXhSFcdIw0C0Q> <xmx:RAcmXkFeVMUEgVlti1V1Z11qd7iCgHU_2PjPPZfzst8JjtAylj-5hQ>
Received: from [192.168.1.22] (cpe-74-77-85-250.buffalo.res.rr.com [74.77.85.250]) by mail.messagingengine.com (Postfix) with ESMTPA id DFE04306098C; Mon, 20 Jan 2020 15:02:11 -0500 (EST)
To: Benjamin Kaduk <kaduk@mit.edu>, The IESG <iesg@ietf.org>
Cc: draft-ietf-jmap-websocket@ietf.org, Jim Fenton <fenton@bluepopcorn.net>, jmap-chairs@ietf.org, jmap@ietf.org
References: <157843131129.21019.4453575321747210277.idtracker@ietfa.amsl.com>
From: Ken Murchison <murch@fastmail.com>
Message-ID: <b568c4bc-41c5-674c-de3e-2d5f2f2bcbab@fastmail.com>
Date: Mon, 20 Jan 2020 15:02:11 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <157843131129.21019.4453575321747210277.idtracker@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/GongJrjHY3saklX8JsKFf3IpQdg>
Subject: Re: [Jmap] Benjamin Kaduk's Discuss on draft-ietf-jmap-websocket-04: (with DISCUSS and COMMENT)
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jan 2020 20:02:20 -0000

Hi Benjamin,

Thank you very much for the detailed review.  I believe that I have 
addressed all of your points in my forthcoming draft, except the one below.


On 1/7/20 4:08 PM, Benjamin Kaduk via Datatracker wrote:
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> The discussion of compression bears some closer scrutiny, as if we allow
> the entire websocket frame to be part of the compression state,
> then there may be more avenues for an attacker to inject content into
> the same compression state as data that we want to keep somewhat
> confidential.  (This is not as bad as, say, the initial CRIME attack
> impact, as the authentication credentials are not being repeatedly sent,
> but the general principle of mixing attacker-controlled and confidential
> data into the same compression domain is the same.)
>
> We could say something in the security considerations about the
> potential consequences for a client that sends multiple requests in
> parallel without request IDs and gets back responses in a different
> order.  (Or just require unique request IDs, I suppose.)


Can you expand on this?  I'm not sure I fully understand the exploit or 
the way(s) to mitigate it.


-- 
Kenneth Murchison
Cyrus Development Team
FastMail US LLC