Re: [Lime] Adam Roach's No Objection on draft-ietf-lime-yang-connection-oriented-oam-model-05: (with COMMENT)

Qin Wu <bill.wu@huawei.com> Thu, 22 February 2018 03:30 UTC

From: Qin Wu <bill.wu@huawei.com>
To: Adam Roach <adam@nostrum.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-lime-yang-connection-oriented-oam-model@ietf.org" <draft-ietf-lime-yang-connection-oriented-oam-model@ietf.org>, "rbonica@juniper.net" <rbonica@juniper.net>, "lime-chairs@ietf.org" <lime-chairs@ietf.org>, "rbonica@juniper.net" <rbonica@juniper.net>, "lime@ietf.org" <lime@ietf.org>
Thread-Topic: Adam Roach's No Objection on draft-ietf-lime-yang-connection-oriented-oam-model-05: (with COMMENT)
Thread-Index: AQHTq4H2gzuk0URW70uqUKovFZXN+aOvw+bw
Date: Thu, 22 Feb 2018 03:30:37 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABA9AD64355@nkgeml513-mbs.china.huawei.com>
References: <151926527112.21223.15521836555061015139.idtracker@ietfa.amsl.com>
In-Reply-To: <151926527112.21223.15521836555061015139.idtracker@ietfa.amsl.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/lime/7YK8Cv78mQ5iwffUqAKNRgDl5Ik>
Subject: Re: [Lime] Adam Roach's No Objection on draft-ietf-lime-yang-connection-oriented-oam-model-05: (with COMMENT)
Precedence: list

Thanks Adam, all nits are fixed.

-Qin
-----邮件原件-----
发件人: Adam Roach [mailto:adam@nostrum.com] 
发送时间: 2018年2月22日 10:08
收件人: The IESG
抄送: draft-ietf-lime-yang-connection-oriented-oam-model@ietf.org; rbonica@juniper.net; lime-chairs@ietf.org; rbonica@juniper.net; lime@ietf.org
主题: Adam Roach's No Objection on draft-ietf-lime-yang-connection-oriented-oam-model-05: (with COMMENT)

Adam Roach has entered the following ballot position for
draft-ietf-lime-yang-connection-oriented-oam-model-05: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-lime-yang-connection-oriented-oam-model/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

I found some small editorial nits while reviewing this document.

§2.2:

>  Connectivity Verification  - Connectivity Verification are used to
>     verify that a destination is connected.  It are also referred to

"...is used to..."

§3:

>  In this document we define a generic YANG model for connection  
> oriented OAM protocols.  The YANG model defined here is generic in a

Hyphenate "connection-oriented".

>  sense that other technologies can extend it for technology specific  
> needs.

Hyphenate "technology-specific".

>  Figure 1 depicts relationship of different YANG modules.

This sentence seems redundant with the earlier "Figure 1 depicts..." statement.


>          |                    |                  |
>   +-------------------------------------------------------+
>   |                      Uniform API                      |
>   +-------------------------------------------------------+
>
>       Relationship of OAM YANG model to generic (base) YANG model

I presume this is Figure 1. It probably should say so.


In the module:

> typedef ma-name-string {
>   type string;
>   description
>     "Generic administrative name for an
>      Maintenance Association (MA).";
> }

"...for a Maintenance..."

[Lime] Adam Roach's No Objection on draft-ietf-li… Adam Roach
Re: [Lime] Adam Roach's No Objection on draft-iet… Qin Wu