Re: [lisp] Alvaro Retana's No Objection on draft-ietf-lisp-rfc6833bis-13: (with COMMENT)

[Alvaro Retana <[e-mail]>]

On September 11, 2018 at 5:15:38 AM, Luigi Iannone ([e-mail]) wrote:

Luigi:

Hi!

Some comments below.  Thanks!

Alvaro.

Hi Alvaro,

thanks for your feedback.

See my comments inline and let us know what you think.

On 10 Sep 2018, at 23:43, Alvaro Retana <[e-mail]> wrote:

Alvaro Retana has entered the following ballot position for
draft-ietf-lisp-rfc6833bis-13: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-lisp-rfc6833bis/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

There are several issues in §5.1 (LISP Control Packet Type Allocations) that
need to be fixed.  I don't think any of them raise up to a DISCUSS, but I
would
like to see them resolved before publication.

§5.1 "defines the LISP control message formats and summarizes for IANA the
LISP
Type codes assigned by this document".

(1) Instructions (or anything directed) to IANA should be in the IANA
Considerations section.  There isn't even a pointer to this section later on
for IANA to look at it.


This can be easily fixed changing the first sentence to:

 This section defines the LISP control message formats and summarizes
           for IANA the LISP Type codes assigned by this document (see
details IANA considerations in Section 11).


What do you think?

The main point is that is you want IANA to look at this text, then the best
way is to put it in the IANA Considerations section.  They may be ok with a
pointer the other way around: from Section 11 to this section (otherwise
they might not notice).





(2) The text seems to imply ("Message type definitions are") that the types
are
defined here (or at least in rfc6833, which this document Obsoletes), but
they
are defined in rfc6830, rfc8111 and rfc8113.  Please properly identify the
source (only the rfc8113 line has a reference).


Would it be sufficient to add a sentence listing the messages that this
documents re-defines and the original RFC which is obsoleted?

I just want the text to be clear about what is defined here and what
isn’t.  I think that references (like the one in there for rfc8113) would
be enough.




(3) Even though draft-ietf-lisp-rfc6830bis is tagged as Obsoleting rfc6830,
I
think that, because of how the contents of that RFC were distributed, this
document should also be tagged as Obsoleting rfc6830.


Meaning that 6833bis obsoletes both 6830 and 6833?

Yes.





(4) The LISP Packet Types registry was set up in rfc8113.  This document
asks
that IANA "refers to this document as well as [RFC8113] as references"
(§11.2),
and it seems to try to change the registration (or the text is incomplete)
in
(§5.1): "Values in the "Not Assigned" range can be assigned according to
procedures in [RFC8126]."  Which procedure?  s/Not Assigned/Unassigned (§6
in
rfc8126)


I think that there is some missing  text, and that most proper sentence
would be:

    Note that according to [RFC8113] the LISP Packet Type values 7 and
9 to 14 can be assigned via Standards
           Action [RFC5226 <https://tools.ietf.org/html/rfc5226>].




(5) Because of the point above, this draft should (at least) Update rfc8113
(see also below).

(6) This document says that "Protocol designers experimenting with new
message
formats SHOULD use the LISP Shared Extension Message Type".  I think this
statement makes rfc8113 a Normative reference -- which results in a
DownRef.
Suggestion: given that this document already updates the registry set up in
rfc8113, and recommends the use of the Shared Extension Message, it may be a
good idea to simply adopt the contents of that document here (grand total
of 6
pages) and declare it Obsolete.


Or just make a 8113bis standard track. The RFC Editor will hold the
document until an RFC number is assigned to all normative references.



Having said that, I wonder if we really need that “SHOULD”.
If I experiment with new messages and I make sure that nothing goes beyond
my own deployment, why being constrained?
And what if (still isolating my experiment) for any reason I would like to
play with the reserved bits of existing messages? How do I do it?

In general because you want to avoid squatting on code points, leaking,
etc..  We’ve seen cases in other WGs where experiments later became
mainstream and changing code points was then a huge pain.

In any case, I’m fine with the sentence below.


Thanks!!

Alvaro.


I would change the sentence in:


 The LISP Shared Extension Message is for experimentation purposes as
described in [RFC8113 <https://tools.ietf.org/html/rfc8113>].




(7) Type 7 is missing.


It is not assigned, and yes… should be stated (see above).

Ciao

L.