Re: [Lsr] Yangdoctors last call review of draft-ietf-isis-yang-isis-cfg-24

"Acee Lindem (acee)" <acee@cisco.com> Tue, 04 December 2018 16:38 UTC

Return-Path: <acee@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 215BB130EB4; Tue, 4 Dec 2018 08:38:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.959
X-Spam-Level:
X-Spam-Status: No, score=-15.959 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-1.459, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ILjm_UYdLpO1; Tue, 4 Dec 2018 08:38:50 -0800 (PST)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6083C12D4EB; Tue, 4 Dec 2018 08:38:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1536; q=dns/txt; s=iport; t=1543941530; x=1545151130; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=xagVUfOa/i5aDcQfS5GAQ99m96Roj84jr5o0ClBLn5I=; b=MlgvorIKFdIZWl8ciPuD2nQjAT6Ui2iYQNBmujuJk7QfxmrEtVyYHjxB 5Wp18CkI2Rs5qRcirua10PKhLbRAdVXxA8/gwHYdKdZoCGkrUuQbVwUzA +0wtjLjihwM2fhTucAy9ihJUMATADAjvUkP54l/GyySZdxSU4UyY1uySX s=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AHAAC3rAZc/5ldJa1kGgEBAQEBAgE?= =?us-ascii?q?BAQEHAgEBAQGBUgQBAQEBCwGBWimBaCcKg2+tfhSBZgsBAYRsAheCcyI1CA0?= =?us-ascii?q?BAwEBAgEBAm0ohT0GIxFFEAIBCBoCJgICAjAVEAIEAQ0FgyGCAqUNgS+KMYE?= =?us-ascii?q?LixMXgX+BOB+CHi6EWw4YgwQxggQiAp95UAkCkT8YkSaJBo9KAhEUgScgATa?= =?us-ascii?q?BVXAVOyoBgkGDPQEDjRpBMYkdgS2BHwEB?=
X-IronPort-AV: E=Sophos;i="5.56,314,1539648000"; d="scan'208";a="491428099"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2018 16:38:49 +0000
Received: from XCH-RTP-002.cisco.com (xch-rtp-002.cisco.com [64.101.220.142]) by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id wB4GcnC3031902 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 4 Dec 2018 16:38:49 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-002.cisco.com (64.101.220.142) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 4 Dec 2018 11:38:48 -0500
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1395.000; Tue, 4 Dec 2018 11:38:48 -0500
From: "Acee Lindem (acee)" <acee@cisco.com>
To: tom petch <ietfc@btconnect.com>, Ebben Aries <exa@juniper.net>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-isis-yang-isis-cfg.all@ietf.org" <draft-ietf-isis-yang-isis-cfg.all@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, "Tarek Saad (tsaad)" <tsaad@cisco.com>
Thread-Topic: [Lsr] Yangdoctors last call review of draft-ietf-isis-yang-isis-cfg-24
Thread-Index: AQHUi+/UfKiWVvfkhUKDIB9kEUVysw==
Date: Tue, 4 Dec 2018 16:38:48 +0000
Message-ID: <0C96BE42-C80C-400A-B1D2-4726B00E0384@cisco.com>
References: <154025553381.13801.5009678921928527816@ietfa.amsl.com> <03ff01d48641$8f8d8600$4001a8c0@gateway.2wire.net>
In-Reply-To: <03ff01d48641$8f8d8600$4001a8c0@gateway.2wire.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.196]
Content-Type: text/plain; charset="utf-8"
Content-ID: <5AA4A26ED10684419E49D5FDC5833F80@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.142, xch-rtp-002.cisco.com
X-Outbound-Node: rcdn-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/AWnMgPXbd-xVb1RxKE33NMqSXMk>
Subject: Re: [Lsr] Yangdoctors last call review of draft-ietf-isis-yang-isis-cfg-24
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Dec 2018 16:38:52 -0000

Hi Tom, 

As always, thanks for your review and comments. Stephane has fixed most of your comments. A couple comments below: 

´╗┐On 11/27/18, 6:10 AM, "tom petch" <ietfc@btconnect.com>; wrote:

    
    Line length is within the RFC limit but the effect is to spread many of
    the description clauses over multiple lines with indentation of 56
    characters, not user friendly
    e.g.
                                            description
                                                    "List of max LSP
    bandwidths for different
                                                     priorities.";

And this is how we want it. I want all the lines to adhere to the current YANG indentation and none to wrap when I open the model with emacs. We have removed tabs that were previously in the model.  
    
    
    Acknowledgements is TBD. I note that the editor list of the YANG module
    is somewhat longer than the editor list of the I-D.

We have this five draft authors limit. However, for a model of this size and complexity, it is a bit silly. 

Thanks,
Acee