Re: [Lsr] Roman Danyliw’s DISCUSS on draft-ietf-ospf-yang-26

"Acee Lindem (acee)" <acee@cisco.com> Wed, 21 August 2019 17:50 UTC

Return-Path: <acee@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F642120DE8; Wed, 21 Aug 2019 10:50:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.499
X-Spam-Level:
X-Spam-Status: No, score=-14.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=H7TRTsAX; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=SJyTKdno
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oBIcPPiDjDJ3; Wed, 21 Aug 2019 10:50:36 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CC3BB120DE4; Wed, 21 Aug 2019 10:50:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=20395; q=dns/txt; s=iport; t=1566409836; x=1567619436; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=xFbvXRvbvvZOzKk2u9ZjYnzLyCE3jm1BfNh9A1AU1ng=; b=H7TRTsAXcP/+GV3uTNCsyq4Mzqbyt/8XTntTTCUOd12Sl+uqLpwGd0LN FUj01L2rOJBSYVh7Fjt843iSFjBfXJcStHhHWGUVmaTm6oCY6O6N3PLMJ f3mz9DRuxLncClKQKR8nkM+dSjH8ay3Xwvz/uPuNJ96DQas5N4urgQWSV w=;
IronPort-PHdr: =?us-ascii?q?9a23=3AqBznLxMycNv78HaRvdYl6mtXPHoupqn0MwgJ65?= =?us-ascii?q?Eul7NJdOG58o//OFDEuKg/l0fHCIPc7f8My/HbtaztQyQh2d6AqzhDOIdJSw?= =?us-ascii?q?dDjMwXmwI6B8vQAEb2IdbhbjcxG4JJU1o2t3w=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DGAABog11d/4UNJK1kGgEBAQEBAgE?= =?us-ascii?q?BAQEHAgEBAQGBZ4EWL1ADbVUgBAsqhB+DRwOKZ4I3JYleiS2EWoJSA1QJAQE?= =?us-ascii?q?BDAEBIwoCAQGEPwIXgkUjOBMCBQEBBAEBAQIBBgRthScMhUoBAQEBAxIRHQE?= =?us-ascii?q?BNwEPAgEIDgMDAQIrAgICHxEaAwgCBAENBSKDAAGBHU0DHQECDJ96AoE4iGF?= =?us-ascii?q?zgTKCewEBBYUXDQuCFgMGgTSKG4FTGIF/gREnDBOCTD6CGkcCgUEBAT4Ngl4?= =?us-ascii?q?ygiaOZjGFDyOIX41xQAkCgh2GaIlYg3kbgjGLSIpNgy+KLIdjgXqOMQIEAgQ?= =?us-ascii?q?FAg4BAQWBZyFEgRRwFTsqAYJBgkKDcoUUhT9yDIEdiVqCQwEB?=
X-IronPort-AV: E=Sophos;i="5.64,412,1559520000"; d="scan'208,217";a="619137878"
Received: from alln-core-11.cisco.com ([173.36.13.133]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 21 Aug 2019 17:50:34 +0000
Received: from XCH-ALN-017.cisco.com (xch-aln-017.cisco.com [173.36.7.27]) by alln-core-11.cisco.com (8.15.2/8.15.2) with ESMTPS id x7LHoYxs009220 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 21 Aug 2019 17:50:34 GMT
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by XCH-ALN-017.cisco.com (173.36.7.27) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 21 Aug 2019 12:50:34 -0500
Received: from xhs-aln-001.cisco.com (173.37.135.118) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 21 Aug 2019 13:50:33 -0400
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 21 Aug 2019 12:50:32 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mBYKUJxgbc9e2zqXrTGjnEKmaThrEVT9quc4CqM1agrNpyAOMjt5D8RQfQgEvx27d4ExCFaLTCqLpdYZYYTVb+oVgTyT6DA7hxK0OZuzaS22aQLWQCSzX70fQVuhn3OR3xT8TWhhaJ1wvJxObgcSHNLAoER9L23OoXh0KPoDeQpb5t4uLtiPdhXzbNL298p6uqDsdFZtkdZTs4vUrWP0owp5NHgeBwKxni/R9Q3LNaDUn5qVseNfdRZWnhQoOAqQK1/oKE5Ioy0aNeeyJZlvLUwutH2FzPdh6LbgeJUa6sjoWdNdiwMBOgI3LVDABmr2PMnDR0dJvPVWVrs55oB0kg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xFbvXRvbvvZOzKk2u9ZjYnzLyCE3jm1BfNh9A1AU1ng=; b=dEzJRU1eRO0CJPyphqPcMhfGKzBly5NQzWscEq3SUhctHMOUjCMLF/k6e/vbvgh4T5EvET975x1hKJVpO2jN8dFltph5Qg35vkj2cACmyzt3t0mpyfK4sOtsPOEytiV8QLFxbloLyWLnA7P4L4BF7PB44cMFBbDXuYTLOtXj/4fk0sFZ/fKXWSyETxM1pFC9RkAxMOkIBeCf+t+Gs+2L33Gm8UaYAap/DoycJfd6VErO1eCohIeAwIoZnpqHLRSysGsB8Kih6ci0Fso0+ffs6bx3qQ/4nv5gppoe7m1HbqIGltwMXo5julvQE5P9gKCVK9B9TDkJtCaFRu5kfFDCaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xFbvXRvbvvZOzKk2u9ZjYnzLyCE3jm1BfNh9A1AU1ng=; b=SJyTKdno6eiVk/nZTtf42VSQoRgxLw9CHVSP2/f7JpfMSgfs0cfkj46XDDx4Nc49DakVXSv2smjnq/jmJAK5lExBR1OJKaSztkbUY1bQ9aFsWrXYVMJuZuaxoSTX8zyjklhwwNHNqf61DvKolbVZ17pnKW0ga2a+4I7Bi6fC+h8=
Received: from MN2PR11MB4221.namprd11.prod.outlook.com (52.135.38.14) by MN2PR11MB4208.namprd11.prod.outlook.com (52.135.36.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16; Wed, 21 Aug 2019 17:50:32 +0000
Received: from MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::859c:f271:3be2:74e0]) by MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::859c:f271:3be2:74e0%3]) with mapi id 15.20.2178.020; Wed, 21 Aug 2019 17:50:31 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Alvaro Retana <aretana.ietf@gmail.com>, "draft-ietf-ospf-yang@ietf.org" <draft-ietf-ospf-yang@ietf.org>
CC: Roman Danyliw <rdd@cert.org>, Stephane Litkowski <stephane.litkowski@orange.com>, "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, The IESG <iesg@ietf.org>
Thread-Topic: =?utf-8?B?Um9tYW4gRGFueWxpd+KAmXMgRElTQ1VTUyBvbiBkcmFmdC1pZXRmLW9zcGYt?= =?utf-8?Q?yang-26?=
Thread-Index: AQHVWDLCA0dMG1KrR0yv+3jHy3LViKcFnmWA
Date: Wed, 21 Aug 2019 17:50:31 +0000
Message-ID: <44866583-78BC-489A-91F8-EF0419F2DBA0@cisco.com>
References: <CAMMESswWu7E+DHW+8t9y5BXTGn3tqYo=vTR+j536MXcdsNEpog@mail.gmail.com>
In-Reply-To: <CAMMESswWu7E+DHW+8t9y5BXTGn3tqYo=vTR+j536MXcdsNEpog@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=acee@cisco.com;
x-originating-ip: [2001:420:c0c4:1007::de]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 070516f8-d5c1-430d-e613-08d726600fcb
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR11MB4208;
x-ms-traffictypediagnostic: MN2PR11MB4208:
x-ms-exchange-purlcount: 3
x-microsoft-antispam-prvs: <MN2PR11MB4208E6A808FB8D7838FC8A3BC2AA0@MN2PR11MB4208.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3631;
x-forefront-prvs: 0136C1DDA4
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(199004)(189003)(6306002)(54896002)(9326002)(229853002)(186003)(66946007)(46003)(33656002)(5660300002)(7736002)(110136005)(256004)(14444005)(14454004)(54906003)(71190400001)(478600001)(8936002)(966005)(486006)(2501003)(606006)(53936002)(81166006)(81156014)(6246003)(4326008)(99286004)(76176011)(2906002)(476003)(11346002)(86362001)(2616005)(102836004)(25786009)(66574012)(446003)(71200400001)(6116002)(316002)(66556008)(6486002)(6512007)(66476007)(66446008)(64756008)(236005)(6506007)(53546011)(36756003)(76116006)(6436002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4208; H:MN2PR11MB4221.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: tTAT9aiZo7K7GYVVY+Sefdn26sojD8XaQQA5PoWCQbZYUFbM5Uo6FZYcd9bOSmvdZReXF+JZNEnhgpH9Pny1nHk7GPvcUIlaTsFbH/1/KuPtYK9lZjxDxpmcSPJHDy/vZIeH6w4TOmRTJzE1xLZblUOraa24/+3ymRCKDW9km6AfkEg8UP/Zm92+Nx62VW1zQ+t/2J6jh/9DXL0CAhRPk+CVq3wmqrhwflDXDpuQyxDHfJ5oNAC464tW9a9zZxRH0w4mQ1ddSA9/iHvE5Vb11preXAcfnQxdEv12kwueK8PzlY3ZpO6uhRVvBj7bznjo0fV384WJsJzb4jjdMam/URnS8REB8AfXiJCIq5iuqufTDymDjKEA1yBfb846ZtrVYc87ZHavsacbbiwRUq1TSZbKwkxNNh0cEDLucZJq550=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_4486658378BC489A91F8EF0419F2DBA0ciscocom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 070516f8-d5c1-430d-e613-08d726600fcb
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2019 17:50:31.8502 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DS+G3Kv+0++C66Gnnct8FzMTl0kFLKWh+J2UM1IZ2dzpoxrUp64HrV9IjduIBYSb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4208
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.27, xch-aln-017.cisco.com
X-Outbound-Node: alln-core-11.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/BAlJDdHzkItL-oP33lR6SUk7AC4>
Subject: Re: [Lsr] =?utf-8?q?Roman_Danyliw=E2=80=99s_DISCUSS_on_draft-ietf-os?= =?utf-8?q?pf-yang-26?=
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Aug 2019 17:50:40 -0000

Hi Roman,

Discussion on discuss.

From: Alvaro Retana <aretana.ietf@gmail.com>;
Date: Wednesday, August 21, 2019 at 11:11 AM
To: "draft-ietf-ospf-yang@ietf.org"; <draft-ietf-ospf-yang@ietf.org>;
Cc: Roman Danyliw <rdd@cert.org>;, Stephane Litkowski <stephane.litkowski@orange.com>;, "lsr-chairs@ietf.org"; <lsr-chairs@ietf.org>;, "lsr@ietf.org"; <lsr@ietf.org>;, The IESG <iesg@ietf.org>;
Subject: Roman Danyliw’s DISCUSS on draft-ietf-ospf-yang-26
Resent-From: <alias-bounces@ietf.org>;
Resent-To: Yingzhen Qu <yingzhen.ietf@gmail.com>;, Christian Hopps <chopps@chopps.org>;, Acee Lindem <acee@cisco.com>;
Resent-Date: Wednesday, August 21, 2019 at 11:08 AM

[It looks like the datatracker didn’t send out the text to Roman’s DISCUSS.  I didn’t receive it, nor do I see it in the mail archive.  So I’m pasting it here. — Alvaro.]

- - - - - - - - - - -
DISCUSS
- - - - - - - - - - -

A “discuss to discuss”.  Per the convention outlined in https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines, thank you for clearly noting the implication of not securing these nodes properly.

Furthermore, following the convention, I would have expected Section 4 to have enumerated the sensitive writeable/creatable/deletable data nodes; and the sensitive readable nodes individually.  For a model this large, I can imagine that individual enumeration would be a long list.

It doesn’t make sense to talk about every configurable leaf so the section describes the general problems that can ensue if OSPF protocol configuration is compromised. We could go into classes of writeable nodes but I question what benefit that would actually have.


In the case of read operations, the text opens with saying that “some of the readable data nodes ...” and later says “The exposure of the ... LSDB will expose the detailed topology ...”.  Can you help me understand which part of ietf-ospf.yang is the LSDB and which parts refer to “some of the readable nodes”?  Is there are a difference, or is this text asserting that all parts of the modules are sensitive and need access control?

The LSDB refers to the instance, area, virtual link, sham-link, and interface Link State DataBases (LSDB).

             /ospf/database
            /ospf/areas/area[area-id]/database
            /ospf/virtual-links/virtual-link[transit-area-id router-id]/database
            /ospf/areas/area[area-id]/interfaces/interface[name]/database
            /ospf/area/area[area-id]/sham-links/sham-link[local-id remote-id]/database

All parts are sensitive. The LSDB is more so since it gives visibility beyond the network device itself.



A related line of questioning for the write operation.  The text opens with saying that “There are a number of data nodes defined in ietf-ospf.yang ... [and that] [w]rite operations ... to these nodes without proper protection can have a negative effect on the network operations ... [and] ... the ability to modify OSPF configuration ...” is problematic.  Can you help me understand which parts of the text is the “OSPF configuration” vs. “there are number of data nodes ...”?  If there isn’t a different, is the text asserting that all parts of the modules are sensitive and need access control?

This is alludes to the “config true” nodes which comprise OSPF configuration. I guess this is a repeat of your first comment.

Thanks,
Acee


- - - - - - - - - - -
COMMENT
- - - - - - - - - - -

(1) Idnits returned a seemingly valid few reference issues:

  ** Downref: Normative reference to an Experimental RFC: RFC 1765

  ** Downref: Normative reference to an Experimental RFC: RFC 4973

(2) Editorial
-- Section 4.  Isn’t RFC8341, “the Network Configuration Access Control Model” rather than the “NETCONF access control model”?

-- Section 4.  Typo.  s/specificationn/specification/

-- Section 4.  Remove the duplicate instance of the phrase “for legacy implementations that do not support key-chains”.

-- Section 4.  Typo.  s/The OSPF YANG module support/the OSPF YANG module supports/

Alvaro Retana