Re: [Lsr] Warren Kumari's No Objection on draft-ietf-isis-segment-routing-msd-15: (with COMMENT)

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Mon, 24 September 2018 06:12 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A6F6F130E51; Sun, 23 Sep 2018 23:12:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i-ihwweG0wj9; Sun, 23 Sep 2018 23:12:14 -0700 (PDT)
Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EBD70130DD8; Sun, 23 Sep 2018 23:12:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4948; q=dns/txt; s=iport; t=1537769534; x=1538979134; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Q4tbMHGXmQFRLjODbzL6cvDRwgMox4r3tHrvfpitgJY=; b=idyvk4zoIU/CK37Q0v7EMlPJUlpHwF/hs5K9MIj7LMcKyOCAYGRSywkV BXu/I+E6lQupYiou4steZWEdbIr6/XaInpH521Be6kg8r6APIJP0xMJq2 HoyR2dC4TyIebQoaK6vwakjPxkdksTh986TUXBFP4sIfncC1f6XQBc013 A=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BIAACKf6hb/5ldJa1ZGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUYIOZX8oCoNqiBWMKYINgz2FIY1xFIFmCyeERQIXgzQ?= =?us-ascii?q?hNBgBAwEBAgEBAm0cDIU4AQEBAQIBIxFFBQcEAgEIEQQBAQMCJgICAh8RFQg?= =?us-ascii?q?IAgQBDQUIgxqBaQMNCA+hZYEuhDMHgm4NgkwFgQuJbReBQT+BEoMSglZFAgE?= =?us-ascii?q?BAQGBKgESAQcvgmqCVwKISJQLLAkChkGGTYMRH4FFhFGDBoYQi3pth3sCERS?= =?us-ascii?q?BJR04ZFgRCHAVgyeCJRcRiEmFPm8BinWBH4EeAQE?=
X-IronPort-AV: E=Sophos;i="5.54,296,1534809600"; d="scan'208";a="175276715"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 06:12:12 +0000
Received: from XCH-RCD-003.cisco.com (xch-rcd-003.cisco.com [173.37.102.13]) by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id w8O6CCLD018532 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 24 Sep 2018 06:12:12 GMT
Received: from xch-aln-001.cisco.com (173.36.7.11) by XCH-RCD-003.cisco.com (173.37.102.13) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 24 Sep 2018 01:12:12 -0500
Received: from xch-aln-001.cisco.com ([173.36.7.11]) by XCH-ALN-001.cisco.com ([173.36.7.11]) with mapi id 15.00.1395.000; Mon, 24 Sep 2018 01:12:11 -0500
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Warren Kumari <warren@kumari.net>, The IESG <iesg@ietf.org>
CC: "draft-ietf-isis-segment-routing-msd@ietf.org" <draft-ietf-isis-segment-routing-msd@ietf.org>, Christian Hopps <chopps@chopps.org>, "aretana.ietf@gmail.com" <aretana.ietf@gmail.com>, "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>, "chopps@chopps.org" <chopps@chopps.org>, "lsr@ietf.org" <lsr@ietf.org>, "wangzitao@huawei.com" <wangzitao@huawei.com>
Thread-Topic: Warren Kumari's No Objection on draft-ietf-isis-segment-routing-msd-15: (with COMMENT)
Thread-Index: AQHUU5hfWVwnOSdjJU2oDGLYs51KPKT+8JJg
Date: Mon, 24 Sep 2018 06:12:11 +0000
Message-ID: <fe40de63ca4e4e63880494af361ee4fe@XCH-ALN-001.cisco.com>
References: <153774669744.29272.15657588887368208840.idtracker@ietfa.amsl.com>
In-Reply-To: <153774669744.29272.15657588887368208840.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.93.154]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.37.102.13, xch-rcd-003.cisco.com
X-Outbound-Node: rcdn-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/KamosCApoDApO-TTtjmPY-egOqw>
Subject: Re: [Lsr] Warren Kumari's No Objection on draft-ietf-isis-segment-routing-msd-15: (with COMMENT)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Sep 2018 06:12:17 -0000

Warren -

Thanx for the review, your kind words, and your sense of humor. 

I have published V16 of the draft which addresses your comments except as noted below.



> -----Original Message-----
> From: Warren Kumari <warren@kumari.net>;
> Sent: Sunday, September 23, 2018 4:52 PM
> To: The IESG <iesg@ietf.org>;
> Cc: draft-ietf-isis-segment-routing-msd@ietf.org; Christian Hopps
> <chopps@chopps.org>;; aretana.ietf@gmail.com; lsr-chairs@ietf.org;
> chopps@chopps.org; lsr@ietf.org; wangzitao@huawei.com
> Subject: Warren Kumari's No Objection on draft-ietf-isis-segment-routing-
> msd-15: (with COMMENT)
> 
> Warren Kumari has entered the following ballot position for
> draft-ietf-isis-segment-routing-msd-15: No Objection
> 
> When responding, please keep the subject line intact and reply to all email
> addresses included in the To and CC lines. (Feel free to cut this introductory
> paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-isis-segment-routing-msd/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thank you for a well written, clear and easy to understand document.
> Also thanks to Zitao Wang for the OpsDir review (
> https://mailarchive.ietf.org/arch/msg/ops-
> dir/GT5r_8_OukxlqMb1NFdsbNysJIw )
> 
> While reviewing it I found some minor nits - these are not blocking
> comments, but please consider addressing them to make the document
> even better:
> 
> 1: Section 1:
> " Path Computation Element Protocol (PCEP) SR extensions"
> I think this would read better as "The Path Computation ..." (Hey! I did say
> they were nits :-))
> 
[Les:] I removed the text and simply let the reference be used as the identifier for the document.

> 2: Section 2.  Node MSD Advertisement
> "Type: 23 (allocated by IANA via the early assignment process)"
> Comment:  Thank you for mentioning here that this is an early allocation - it
> makes it much easier on the reviewer than flipping to the back of the
> document to check, flipping forward, etc.!
> 
> 3: Section 3.  Link MSD Advertisement
> "MSD values may be learned via a hardware API or may be provisioned."
> I don't quite get what a "hardware API" is -- perhaps "an API which talks
> directly to the hardware"? Or just drop API (or hardware)?

[Les:] Some merchant silicon may provide APIs to report the info used to derive link MSD. We wanted to indicate that the value may be derived from such APIs or simply be provisioned.
I modified the text to say " signaled by the forwarding plane".

> 
> 4: Section 6.  IANA Considerations
> "Per TLV information where Link MSD sub-TLV can be part of:
>    TLV  22 23 25 141 222 223
>    ---  --------------------
> yyyyyy
>         Figure 5: TLVs where LINK MSD Sub-TLV can be present"
> 
> I understand what this is trying to say, but I don't think it does a very good
> job of doing so. Perhaps remove the figure and just say "The LINK MSD Sub-
> TLV can be in TLVs 22, 23, 25,141, 222 or 223" or similar....
> 

[Les:] This text mimics the format of the registry which will be updated:  https://www.iana.org/assignments/isis-tlv-codepoints/isis-tlv-codepoints.xhtml#isis-tlv-codepoints-22-23-25-141-222-223 
So it needs to be in this format.

   Les