Re: [MIB-DOCTORS] MIB Doctor review of draft-ietf-sidr-rpki-rtr-protocol-mib-04

Benoit Claise <bclaise@cisco.com> Mon, 11 February 2013 18:39 UTC

Return-Path: <bclaise@cisco.com>
X-Original-To: mib-doctors@ietfa.amsl.com
Delivered-To: mib-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4A79221F8849 for <mib-doctors@ietfa.amsl.com>; Mon, 11 Feb 2013 10:39:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.562
X-Spam-Level:
X-Spam-Status: No, score=-10.562 tagged_above=-999 required=5 tests=[AWL=0.037, BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A2oQJkhCCTJh for <mib-doctors@ietfa.amsl.com>; Mon, 11 Feb 2013 10:39:43 -0800 (PST)
Received: from av-tac-bru.cisco.com (weird-brew.cisco.com [144.254.15.118]) by ietfa.amsl.com (Postfix) with ESMTP id 7DF6A21F87DF for <mib-doctors@ietf.org>; Mon, 11 Feb 2013 10:38:55 -0800 (PST)
X-TACSUNS: Virus Scanned
Received: from strange-brew.cisco.com (localhost.cisco.com [127.0.0.1]) by av-tac-bru.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id r1BIXQGI014419; Mon, 11 Feb 2013 19:33:26 +0100 (CET)
Received: from [10.60.67.84] (ams-bclaise-8913.cisco.com [10.60.67.84]) by strange-brew.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id r1BIVwmQ014366; Mon, 11 Feb 2013 19:32:13 +0100 (CET)
Message-ID: <5119391E.3010308@cisco.com>
Date: Mon, 11 Feb 2013 19:31:58 +0100
From: Benoit Claise <bclaise@cisco.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2
MIME-Version: 1.0
To: Michael Baer <michael.baer@sparta.com>
References: <00f101cdf336$889656f0$99c304d0$@comcast.net> <87zjzfke9d.fsf@rebma.mikesoffice.com> <511917C6.90801@cisco.com> <87d2w6hhq4.fsf@rebma.mikesoffice.com>
In-Reply-To: <87d2w6hhq4.fsf@rebma.mikesoffice.com>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: MIB Doctors <mib-doctors@ietf.org>, randy@psg.com, keyupate@cisco.com, adrian@olddog.co.uk, stbryant@cisco.com
Subject: Re: [MIB-DOCTORS] MIB Doctor review of draft-ietf-sidr-rpki-rtr-protocol-mib-04
X-BeenThere: mib-doctors@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: MIB Doctors list <mib-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mib-doctors>
List-Post: <mailto:mib-doctors@ietf.org>
List-Help: <mailto:mib-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2013 18:39:44 -0000

Thanks.
I just cleared my DISCUSS.

Regards, Benoit
> Hi Benoit,
>
> A updated 06 version of the draft was just submitted.  I have inline
> comments below.
>
>>>>>> On Mon, 11 Feb 2013 17:09:42 +0100, Benoit Claise <bclaise@cisco.com> said:
>      BC> Hi Michael, Thanks for addressing the MIB doctor points.
>
>      >>
>      DH> The Errors table contains counters that represent "the number of
>      DH> XXX errors received." This description seems to indicate that
>      DH> counters start at zero (and implicitly reset to zero on a
>      DH> discontinuity). An NMS developer certainly might interpret this
>      DH> text as indicating zero-based counters. I think if there is an
>      DH> assumption these are zero-based, there are TC-s that could be
>      DH> used to show that assumption. OTOH, counters typically are not
>      DH> zero-based because if errors occur during system startup, the
>      DH> counter might be initialized partway through the startup and not
>      DH> reflect all the errors that occurred during the startup phase. I
>      DH> think this table would benefit from a discussion of the expected
>      DH> initial values (zero or unpredictable/implementation-dependent)
>      DH> and the nature of expected discontinuities, so NMS developers
>      DH> can be sure to understand the relevant assumptions.  (is the
>      DH> only discontinuity a restart of the management system?  What
>      DH> about rollovers? Are all these error counters not preserved
>      DH> across system restarts? Or can an implementation choose to
>      DH> preserve them across resets to enhance debugging history?) Some
>      DH> of this discussion would seem to apply to all the error
>      DH> counters; if that is true of all current counters and should be
>      DH> true for an potentially new counters added to this table, this
>      DH> type of discussion could be captured in the Table or TableEntry
>      DH> description.  (including the discussion of
>      DH> rpkiRtrDiscontinuityTimer, which seems to apply to the whole
>      DH> table).
>      >>
>      >> I meant to add clarifying text to the discontinuity time (e.g. a
>      >> manager can only compare values pulled since the discontinuity
>      >> time...). But double checking now, I didn't get this change into
>      >> the current draft.
>      BC> The document would really benefit from this clarification.
>      BC> Please post a new version with this improvement, and I'll clear
>      BC> my DISCUSS.
>
> I added text to the rpkiRtrDiscontinuityTimer object:
>
>      For objects that use rpkiRtrDiscontinuityTimer to indicate
>      discontinuity, only values received since the time indicated by
>      rpkiRtrDiscontinuityTimer are comparable to each other. A manager
>      should take the possibility of rollover into account when
>      calculating difference values.
>
>      DH> rpkiRtrCacheServerId would benefit from a reference.
>      >> meant to, but not added
>      BC> It would nice to add it, along with above improvement.
>
> I did add a reference clause to this object (as well as fixing a
> spelling nit mentioned by Brian Carpenter).
>
> Thanks,
> Mike
>
>