Re: [MMUSIC] ICE-SIP-SDP: Concluding ICE statement

[Roman Shpount <[e-mail]>]

On Thu, Jul 18, 2019 at 2:15 AM Christer Holmberg <
[e-mail]> wrote:

>
> >>>This makes sense, but I am not sure it is precise enough. What we are
> trying to say is that ICE nomination
>
> >>>process is done (completed or failed) for all streams and no new
> candidate pairs are going to be nominated.
>
> >>
>
> >> The text talks about when the nomination starts.
>
> >
>
> >Starts or ends?
>
> >
>
> >The sentence in 3.3.4 was supposed to mean that when ICE nomination
> process completes and if for any stream non-default
>
> >candidate was nominated and ice2 option was not set, to send a new offer.
>
>
>
> It also says that :)
>
>
>
> But, the first sentence says:
>
>
>
> “Once the state of each check list is Completed, and if the agent is
>
> the controlling agent, it nominates a candidate pair [RFC8445]…”
>
>
>
> …which at least to me describes when the nomination starts.
>
>
>

This is actually still about the nomination end. Essentially, what is
described here is at the end of the nomination process, for each stream a
candidate pair is nominated (or the stream failed). If ice2 option is not
set, and pair nominated in the end is not the default candidate pair for
this stream, then new offer should be sent to "true up" default candidates.

What this whole language is missing is that for some streams nomination can
fail without failure of the entire session. Stream failure should also
result in a new offer with the failed streams disabled (port set to 0). I
am not sure this is specified anywhere. Another thing which is not
specified anywhere if new offer due to stream failure is only required if
ice2 option is not set or always. I would vote for always to make sure this
m= line can be reused.

Best Regards.
_____________
Roman Shpount