Re: [mpls] RtgDir Review: draft-ietf-mpls-ri-rsvp-frr-05

<julien.meuric@orange.com> Fri, 21 June 2019 13:30 UTC

Return-Path: <julien.meuric@orange.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CA9B1120269; Fri, 21 Jun 2019 06:30:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.29
X-Spam-Level:
X-Spam-Status: No, score=-0.29 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FORGED_MUA_MOZILLA=2.309, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3ZoQj2EjNvrh; Fri, 21 Jun 2019 06:30:23 -0700 (PDT)
Received: from orange.com (mta241.mail.business.static.orange.com [80.12.66.41]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 546AC120265; Fri, 21 Jun 2019 06:30:23 -0700 (PDT)
Received: from opfedar05.francetelecom.fr (unknown [xx.xx.xx.7]) by opfedar20.francetelecom.fr (ESMTP service) with ESMTP id 45Vfgw4lxbz8wWM; Fri, 21 Jun 2019 15:30:20 +0200 (CEST)
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.51]) by opfedar05.francetelecom.fr (ESMTP service) with ESMTP id 45Vfgw3JPYz2xC9; Fri, 21 Jun 2019 15:30:20 +0200 (CEST)
Received: from [10.193.71.104] (10.114.13.245) by OPEXCAUBM22.corporate.adroot.infra.ftgroup (10.114.13.51) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 21 Jun 2019 15:30:20 +0200
To: Chandrasekar Ramachandran <csekar@juniper.net>
CC: "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-mpls-ri-rsvp-frr.all@ietf.org" <draft-ietf-mpls-ri-rsvp-frr.all@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
References: <25527_1555000351_5CAF6C1F_25527_187_1_c344649c-bea5-5d0e-3b76-2bd28be6d226@orange.com> <BYAPR05MB547700FDE3B96DEF070438E6D9E40@BYAPR05MB5477.namprd05.prod.outlook.com> <2098_1561039664_5D0B9330_2098_160_1_84b25e23-a628-854e-fb5d-f9ffdcdb170e@orange.com> <BYAPR05MB54778F145B53DCC233032F48D9E40@BYAPR05MB5477.namprd05.prod.outlook.com> <30928_1561107317_5D0C9B75_30928_253_5_092a01d2-2c01-1f57-7b13-47a85b103048@orange.com> <BYAPR05MB5477CD42582D01E9D0C314CCD9E70@BYAPR05MB5477.namprd05.prod.outlook.com>
From: <julien.meuric@orange.com>
Organization: Orange
Message-ID: <11774_1561123820_5D0CDBEC_11774_443_1_31b27e1f-bca9-a331-6f32-e1504486610c@orange.com>
Date: Fri, 21 Jun 2019 15:30:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <BYAPR05MB5477CD42582D01E9D0C314CCD9E70@BYAPR05MB5477.namprd05.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [10.114.13.245]
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/aXQsIH5zGxCfEVLwipADr3e1Vko>
Subject: Re: [mpls] RtgDir Review: draft-ietf-mpls-ri-rsvp-frr-05
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2019 13:30:26 -0000

Hi Chandra,

OK, after refreshing the context, I think I get it and why I got confused.

What puzzles me then is the 1st sentence of section 4.6.2.2, and
especially the "upstream direction" phrase, which happens to be wrong
with respect to the section title and content. I suggest two
clarification tweaks:
- drop the confusing phrase (e.g., just say "The procedures are as
follows."), as the section title already does the right job;
- add a parenthesis at the end of the 2nd bullet, e.g. "(Thus, the Nhop
is informed and can use compatible values when sending a Resv.)"

Another typo spotted from the diff: in the terminology section,
Next-Next-hop points to the PPhop acronym.

Thanks for your time,

Julien


On 21/06/2019 11:14, Chandrasekar Ramachandran wrote:
> Hi Julien,
>
>
> Juniper Business Use Only
>
>> -----Original Message-----
>> From: julien.meuric@orange.com <julien.meuric@orange.com>;
>> Sent: Friday, June 21, 2019 2:25 PM
>>
>> Hi Chandra,
>>
>> Your response seems to summarize section 4.6.2.1. about the "downstream
>> direction", which is fine. My comment below is about section 4.6.2.2.
>> which describes the "upstream direction": how could an RSVP-TE message
>> sent to a Phop be a Path instead of a Resv? Am I missing something?
> [Chandra] Let me illustrate with an example LSP as shown below.
>
>     A  -> B -> C -> D
>
> If ingress A does not support the extensions defined in the draft and requests node protection for the LSP, then long refresh will not be enforced on the LSP segment A -> B -> C. In other words, Path messages from A to B, Path messages from B to C, Resv messages from B to A, and Resv messages from C to B, will not use long refresh interval. This behavior ensures that neither primary Path from B to C nor backup LSP Path from A to C during local repair would use long refresh. Hence, node C may opt to time out LSP state normally in case of B-C link failure without requiring any explicit state cleanup messages from node A or node B.
>
> In general, if there is a non-compliant node along the path of an LSP and if the ingress node has requested node protection, then backward compatibility procedures will come into force on two hops upstream & two hops downstream of that non-compliant node.
>
> Thanks,
> Chandra.
>
>> Cheers,
>>
>> Julien
>>
>>
>> On 20/06/2019 17:08, Chandrasekar Ramachandran wrote:
>>> Hi Julien,
>>> Please refer inline.
>>>
>>>
>>> Juniper Internal
>>>
>>>> -----Original Message-----
>>>> From: julien.meuric@orange.com <julien.meuric@orange.com>;
>>>> Sent: Thursday, June 20, 2019 7:38 PM
>>>>
>>>> Hi Chandra,
>>>>
>>>> Thanks for the update. I've just taken a look at the diff: it looks
>>>> fine, with an improved MUST/SHOULD ratio. I haven't checked all nits,
>>>> but it seems you missed a key one in section 4.6.2.2., leaving a Path
>>>> message when talking about upstream (see below).
>>> [Chandra] The text "carried in the Path to" is intended because the
>> expected outcome is not to apply long refresh in the two hop
>> neighborhood. That is, if the Phop node (say node X) does not support the
>> extensions, then two nodes downstream of node X must use backward
>> compatible refresh interval. This will enable the NP-MP of node X to time
>> out the path state normally when the refresh timeout expires.
>>> Thanks,
>>> Chandra.
>>>
>>>> Cheers,
>>>>
>>>> Julien
>>>>
>>>>
>>>> On 20/06/2019 15:42, Chandrasekar Ramachandran wrote:
>>>>> [...]
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: julien.meuric@orange.com <julien.meuric@orange.com>;
>>>>>> Sent: Thursday, April 11, 2019 10:03 PM
>>>>>>
>>>>>> - s/in TIME_VALUES object carried in PATH to default value/in the
>>>>>> TIME_VALUES object carried in the *Resv* message to a default
>>>>>> value/
>>>>
>> ______________________________________________________________
>>>> ___________________________________________________________
>>>>
>>>> Ce message et ses pieces jointes peuvent contenir des informations
>>>> confidentielles ou privilegiees et ne doivent donc pas etre diffuses,
>>>> exploites ou copies sans autorisation. Si vous avez recu ce message
>>>> par erreur, veuillez le signaler a l'expediteur et le detruire ainsi
>>>> que les pieces jointes. Les messages electroniques etant susceptibles
>>>> d'alteration, Orange decline toute responsabilite si ce message a ete
>> altere, deforme ou falsifie. Merci.
>>>> This message and its attachments may contain confidential or
>>>> privileged information that may be protected by law; they should not
>>>> be distributed, used or copied without authorisation.
>>>> If you have received this email in error, please notify the sender
>>>> and delete this message and its attachments.
>>>> As emails may be altered, Orange is not liable for messages that have
>>>> been modified, changed or falsified.
>>>> Thank you.
>>
>> ______________________________________________________________
>> ___________________________________________________________
>>
>> Ce message et ses pieces jointes peuvent contenir des informations
>> confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites
>> ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez
>> le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les
>> messages electroniques etant susceptibles d'alteration, Orange decline
>> toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
>>
>> This message and its attachments may contain confidential or privileged
>> information that may be protected by law; they should not be distributed,
>> used or copied without authorisation.
>> If you have received this email in error, please notify the sender and delete
>> this message and its attachments.
>> As emails may be altered, Orange is not liable for messages that have been
>> modified, changed or falsified.
>> Thank you.


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.