Re: [Netconf] [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-netconf-event-notifications-16

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Wed, 09 January 2019 18:48 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D3CE4130F46; Wed, 9 Jan 2019 10:48:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -19.054
X-Spam-Level:
X-Spam-Status: No, score=-19.054 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HgZAJQ3QZbv1; Wed, 9 Jan 2019 10:48:45 -0800 (PST)
Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 128CE130F44; Wed, 9 Jan 2019 10:48:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4816; q=dns/txt; s=iport; t=1547059725; x=1548269325; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LSRXJJ8GUf9RM7N4LMAzhg3nuZYiSaG+aG6qW9P4M+A=; b=UC41jeMWdNhHanJJ7py/hqtW/y2yeuYDxIaWFI7N41+/AKbwv8aXF3Ki QEOr8MPnJRFr5WqUNal8kWUaWGIXRlwcoAmyjUZjPyLTQnrKUVtYOjtgU smn8q/cz4fs3t5XAaF6OkorWiKf7uRKQTNa77AP5ksMNagYa02DJwmwQo U=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AHAABsQTZc/5ldJa1jGgEBAQEBAgE?= =?us-ascii?q?BAQEHAgEBAQGBUgQBAQEBCwGBWilmgQInCoN2lW6YFxSBZwsBARgPBYRAAhe?= =?us-ascii?q?CCCI1CA0BAwEBAgEBAm0cAQuFSwIEAQEhEToJAhACAQgaAgkWBwICAiULFRA?= =?us-ascii?q?CBA4FgldLAYIBD6wbgS+EMQIBCwI/AYUsBYELizQXgUA/gTgME4IXNYMeAQE?= =?us-ascii?q?DAYEqARIBHxeCcjGCBCICoRJaCQKHF4NMhxgYgWSIWIc7iWyFCos2AhEUgSc?= =?us-ascii?q?gATZlcXAVOyoBgkGCUYhMhT9ygSiGYw0XB4EBAYEeAQE?=
X-IronPort-AV: E=Sophos;i="5.56,458,1539648000"; d="scan'208";a="493388643"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 18:48:44 +0000
Received: from XCH-ALN-005.cisco.com (xch-aln-005.cisco.com [173.36.7.15]) by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id x09ImhiQ031602 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 9 Jan 2019 18:48:44 GMT
Received: from xch-rcd-005.cisco.com (173.37.102.15) by XCH-ALN-005.cisco.com (173.36.7.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 9 Jan 2019 12:48:42 -0600
Received: from xch-rcd-005.cisco.com ([173.37.102.15]) by XCH-RCD-005.cisco.com ([173.37.102.15]) with mapi id 15.00.1395.000; Wed, 9 Jan 2019 12:48:43 -0600
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-netconf-netconf-event-notifications.all@ietf.org" <draft-ietf-netconf-netconf-event-notifications.all@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>
Thread-Topic: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-netconf-event-notifications-16
Thread-Index: AQHUqDk0MEtk4/aZ2E+MAjzaT3aN2aWnWDMA
Date: Wed, 9 Jan 2019 18:48:42 +0000
Message-ID: <B9679402-7DF0-445C-8455-E7FB90A3E9DB@cisco.com>
References: <154705166883.4820.16710277209489694478@ietfa.amsl.com>
In-Reply-To: <154705166883.4820.16710277209489694478@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.5.181209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [161.44.212.37]
Content-Type: text/plain; charset="utf-8"
Content-ID: <014DB4056B1FDC4A86591A047BFC0889@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.36.7.15, xch-aln-005.cisco.com
X-Outbound-Node: rcdn-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/p9tDvcANq8pkLdpgBC-zB71k5f8>
Subject: Re: [Netconf] [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-netconf-event-notifications-16
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 18:48:47 -0000

Don't know why newlines aren't showing up in the email, if you want a nicer view (also a slight revision):
https://datatracker.ietf.org/doc/review-ietf-netconf-netconf-event-notifications-16-yangdoctors-lc-rahman-2019-01-09/

´╗┐On 2019-01-09, 11:34 AM, "yang-doctors on behalf of Reshad Rahman" <yang-doctors-bounces@ietf.org on behalf of rrahman@cisco.com>; wrote:

    Reviewer: Reshad Rahman
    Review result: Ready with Issues
    
    YANG Doctor review of draft-ietf-netconf-netconf-event-notifications-16 (by
    Reshad Rahman)
    
    No YANG module in this draft but there are numerous examples based on the YANG
    modules in draft-ietf-netconf-subscribed-notifications and
    draft-ietf-netconf-yang-push. Validation of the examples was done with yanglint
    0.16.59.
    
    The major issues are related to the examples, although in 2) below  the
    root-cause might be with the YANG module in
    draft-ietf-netconf-subscribed-notifications  and in 3) there is an issue which
    has already been reported on draft-ietf-netconf-yang-push: 1) The
    establish-subscription request in Figure 3 fails yanglint validation, the
    "stream" element has to be moved after the "stream-xpath-filter" element, that
    fixed the following issue: err : Invalid order of elements
    "stream-xpath-filter" and "stream".
    (/ietf-subscribed-notifications:establish-subscription/stream-xpath-filter) 2)
    The establish-subscription error response in Figure 5 fails yanglint
    validation, the "id" element is missing. This is because
    draft-ietf-netconf-subscribed-notifications has leaf id as mandatory in
    establish-subscription output, either we remove the mandatory or we reserve a
    value as invalid id or we add err : Missing required element "id" in
    "establish-subscription".
    (/ietf-subscribed-notifications:establish-subscription) 3) The
    modify-subscription request in Figure 7 fails yanglint validation because of
    missing "datastore" element. err : When condition
    "../ietf-subscribed-notifications:target/ietf-yang-push:datastore" not
    satisfied.
    (/ietf-subscribed-notifications:modify-subscription/ietf-yang-push:periodic)
    There are 2 causes here: missing "datastore" element and incorrect when
    statements in draft-ietf-netconf-yang-push (as reported by Andy Bierman).
    Fixing ietf-yang-push.yang and adding the following before element
    "datastore-xpath-filter " fixed the example.
        <yp:datastore
        xmlns:ds="urn:ietf:params:xml:ns:yang:ietf-datastores">ds:running</yp:datastore>
    
    Minor comments and nits:
    - Abstract s/YANG Push/YANG-Push/ since YANG-Push is the term introduced in
    draft-ietf-netconf-yang-push - Introduction. Last sentence doesn't read well,
    "...a RESTCONF client via a dynamic subscription..." may need tweaking -
    Section 5 s/terminates/terminates,/ - Section 7 3rd bullet. s/this MAY but does
    not have to be included/this MAY be included/? - Section 7
    s/kill-subscription-error/delete-subscription-error/ (thanks Rob) - Figure 3,
    stream-xpath-filter uses prefix "ds" for example-datastore.yang. Since "ds" is
    used by ietf-datastores.yang, might be better to choose another prefix such as
    "ex"
    
    Regards,
    Reshad.
    
    
    _______________________________________________
    yang-doctors mailing list
    yang-doctors@ietf.org
    https://www.ietf.org/mailman/listinfo/yang-doctors