IETF Logo Mail Archive

[Netmod-ver-dt] Balazs Review of draft-verdt-netmod-yang-semver-01

Balázs Lengyel <balazs.lengyel@ericsson.com> Fri, 13 September 2019 13:34 UTC

Return-Path: <balazs.lengyel@ericsson.com>
X-Original-To: netmod-ver-dt@ietfa.amsl.com
Delivered-To: netmod-ver-dt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 573E6120170 for <netmod-ver-dt@ietfa.amsl.com>; Fri, 13 Sep 2019 06:34:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YKKANBsMBqNT for <netmod-ver-dt@ietfa.amsl.com>; Fri, 13 Sep 2019 06:34:50 -0700 (PDT)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03on060f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0a::60f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E1B0B12004F for <netmod-ver-dt@ietf.org>; Fri, 13 Sep 2019 06:34:49 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q5fZOJjQ+GvHWr8knk6/mf2DimWN6QxLi97rZSRWvNAbw10bPzG0FCi4QCgACBhLUYYUpznQ4wwRiWRhquqCb1B8qwQSrzJ7Ymz0vS3pYxQKKd2BwlMnkyM53yjpAZ7WMOXVmsUvGsz7FsZp0Ir9tGyhexxCE8Sent/dMOMRgaSUq5Ew4mTV8QHw/7Y5nR+s16twMaYonCaUUUFiyZxgyTdOmESHE/yvaQmjB5MmiVrZx1JGfJl+ofp9eWkpdBkYmDtGRldrNGTo3mNdhERsKPmpuwc3VA4WewMJCbQrTy1GpUu73gygmcmeXMGWa3HiVtPWeNp991wFB+17KtXQkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w0t6aUrXriN5Opd8diQH4G6pCXr3Nfd/zN4N06Z8pFI=; b=hnDdybyhv9ufrqgHFWr6GAKF0ZysIb6qwjRT3EzdD/PMR4q4FI358MPZ+1pqjXY6EZF7geoyiEiC5hkVecafD85SnReyqrkQCyqxkzAwl6EBGy6CL7XO579QlmmBhKtpPpURltToBsncBRDXbQfUZIWsALbCLb7OLSgp3OXxiL3+oha7ylkZtKlLCRAmGeByUevtoREiw6+tpUYldiAT6s4gl/ZDzm6f7jvCKCuSr0u0mSzdntrIwcpaKjImRtTsvKqyh58roWcwIm6PpKY/HlXQiCKEHhmdaFOAna4V4JdTYRsXyNEJt0Fb8afNQXilQJQJLDnl7aWGrdoIWmXkCg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w0t6aUrXriN5Opd8diQH4G6pCXr3Nfd/zN4N06Z8pFI=; b=Q4yfCBU57dp82GYn3uxFadLn87wFXglGA95rQO1lZjC8cHlCuL00LLcRDKKOUe6Sv7R/AK0fBHtcZop9rkmZrACE3W5fUkRF08an0Oi48s/BQi2qSo11rSNNGjQfV+Xg3MAA7BmL0zv2Jfzw5yvB79Gr2V+GfEcewkITZupftXU=
Received: from VI1PR0701MB2286.eurprd07.prod.outlook.com (10.169.137.153) by VI1PR0701MB2637.eurprd07.prod.outlook.com (10.173.79.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.7; Fri, 13 Sep 2019 13:34:47 +0000
Received: from VI1PR0701MB2286.eurprd07.prod.outlook.com ([fe80::f44b:854c:51cf:c69f]) by VI1PR0701MB2286.eurprd07.prod.outlook.com ([fe80::f44b:854c:51cf:c69f%7]) with mapi id 15.20.2263.016; Fri, 13 Sep 2019 13:34:47 +0000
From: Balázs Lengyel <balazs.lengyel@ericsson.com>
To: "netmod-ver-dt@ietf.org" <netmod-ver-dt@ietf.org>
Thread-Topic: Balazs Review of draft-verdt-netmod-yang-semver-01
Thread-Index: AdVqNKnthC5BjNxRS1GW8Oyeg5frcw==
Date: Fri, 13 Sep 2019 13:34:47 +0000
Message-ID: <VI1PR0701MB22860937DD03832F4B6CBF09F0B30@VI1PR0701MB2286.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=balazs.lengyel@ericsson.com;
x-originating-ip: [89.135.192.225]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 72843d5a-c751-4107-d80e-08d7384f2540
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(49563074)(7193020); SRVR:VI1PR0701MB2637;
x-ms-traffictypediagnostic: VI1PR0701MB2637:
x-microsoft-antispam-prvs: <VI1PR0701MB263744E846D472F84CBD5B08F0B30@VI1PR0701MB2637.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0159AC2B97
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(396003)(136003)(376002)(366004)(39860400002)(189003)(199004)(6116002)(316002)(256004)(2501003)(790700001)(53936002)(9686003)(3846002)(99286004)(45776006)(54896002)(6306002)(99936001)(2351001)(476003)(71190400001)(71200400001)(86362001)(486006)(5640700003)(55016002)(6436002)(8676002)(66616009)(81156014)(66556008)(66946007)(5660300002)(6916009)(6506007)(64756008)(25786009)(102836004)(76116006)(8936002)(66446008)(66476007)(9326002)(66066001)(33656002)(14454004)(2906002)(186003)(74316002)(52536014)(7696005)(26005)(7736002)(478600001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0701MB2637; H:VI1PR0701MB2286.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: MSyED9OqL/PV91aWwP8AExeKLw+4IlJosycUnV/Dnh35Wj3y0Sgj92oemMtobPPeQYN4jPLi9egQQuda1VOu4/mCAmRicJlw4lQOyRKdXuNqgctaFlUtt8omrL7FoaXqxRgf1WvhMeYcMOo1khWj7bTnzl9Ri9XbD6xfkTqUrdl7uKBjOD6qTeZyh9sUOe/vUea4MFDnDWFvFj/by9otesRnCBcOsFjfSbDNP3IwPxnum2Obf3Y1c9x4tTOsMFkHXo6TyGyZOTkSGNbZdRZVU+e8AtdTUb3KtuY3WmvFlCuVIfFhEwcTUAaqQT5V77GJaFZrBSDIFPlw3xiMg/o9RHyVWOVMuKEbB2U42M9GuzrmkLY3CMkKLe0Nxd539QmF4J9wkZOuTsuRPKhCMhZddNV6GsNdcp4W25hDnQH5PIs=
x-ms-exchange-transport-forked: True
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg="SHA1"; boundary="----=_NextPart_000_0417_01D56A48.C4F3CFC0"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72843d5a-c751-4107-d80e-08d7384f2540
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2019 13:34:47.4203 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VzciaNKq6SumE5gzff/p00DpR4tksPUZjVOTPlriMRCyLEM4OpV/4S8mSjOodLd7cvu5fqlw/qi5mbvCvZysD9N2KHMq7f398pLPbnGFSXc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB2637
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod-ver-dt/6gv8UyxYzRItHik7_AbBrqeJ5SA>
Subject: [Netmod-ver-dt] Balazs Review of draft-verdt-netmod-yang-semver-01
X-BeenThere: netmod-ver-dt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NetMod WG YANG Model Versioning Design Team <netmod-ver-dt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod-ver-dt>, <mailto:netmod-ver-dt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod-ver-dt/>
List-Post: <mailto:netmod-ver-dt@ietf.org>
List-Help: <mailto:netmod-ver-dt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod-ver-dt>, <mailto:netmod-ver-dt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Sep 2019 13:34:53 -0000

Hello Joe,

Some comments:

General: I would like this to be merged with module-versioning. 

*	I would like this to be main-stream. It may be optional, but it
should be the single recommended scheme.
*	Putting restrictions on “other” schemes that use the revision label
can not be enforced. If they don’t support this draft/RFC they will never
know what they are not allowed to do.
*	A YANG module with a single typedef looks really strange.

After workgroup adoption I would raise this issue again.

 

Ch 1) 

Add something like:

“The goal is to add a human readable version label that provides
compatibility information for the module without comparing or parsing the
module’s body.”

This is the whole reason to create this draft.

 

Ch 2. And General) We really need to give our versioning scheme a “name” and
refer to it as such. I propose “yangver”.

 

Ch 3.1 paragraph after the bullets)

Do we need to specify different metadata  types? Or is this text directly
from semver?

 

Reword as it is hard to understand:

Old text:

   Versioning schemes that are not this modified semver MUST NOT use

   this same version pattern.  Other schemes may, for example, use

   additional leading characters to distinguish them from this semantic

   versioning scheme.

New text:

   Other version schemes MUST use versioning strings that do not match the
format and the pattern specified for yangver , e.g. use

   additional leading characters to distinguish them from yangver.

 

Ch 3.4.2) I have not read the package draft recently, but does this example
imply that a package has a single revision-label? IMHO for each revision a
description, reference and revision label is needed.

 

Ch 4) Shouldn’t we allow any BC version to be used for import even if it is
not in the revision history.

 

Ch 5.) I would find a more descriptive name for the typedef e.g. yangver

 

Regards Balazs

 

-- 

Balazs Lengyel                    Senior Specialist
Ericsson Hungary Ltd. 

Mobile: +36-70-330-7909              email: Balazs.Lengyel@ericsson.com

v2.23.0 | Report a Bug | By Email