Re: [netmod] Opsdir last call review of draft-ietf-netmod-schema-mount-10

Martin Bjorklund <mbj@tail-f.com> Fri, 29 June 2018 19:39 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 40683130E85; Fri, 29 Jun 2018 12:39:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Im4LHuACavKs; Fri, 29 Jun 2018 12:39:33 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 72057130E71; Fri, 29 Jun 2018 12:39:33 -0700 (PDT)
Received: from localhost (h-80-27.A165.priv.bahnhof.se [212.85.80.27]) by mail.tail-f.com (Postfix) with ESMTPSA id 355E81AE02F0; Fri, 29 Jun 2018 21:39:31 +0200 (CEST)
Date: Fri, 29 Jun 2018 21:39:30 +0200 (CEST)
Message-Id: <20180629.213930.2172009982679785114.mbj@tail-f.com>
To: mersue@gmail.com
Cc: ops-dir@ietf.org, netmod@ietf.org, ietf@ietf.org, draft-ietf-netmod-schema-mount.all@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <153028126733.30438.7990879178207113700@ietfa.amsl.com>
References: <153028126733.30438.7990879178207113700@ietfa.amsl.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/HUdAYd4otYd_7Z1GPZF1OaCBRgI>
Subject: Re: [netmod] Opsdir last call review of draft-ietf-netmod-schema-mount-10
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jun 2018 19:39:36 -0000

Hi,

Thank you for this review, comments inline.

Mehmet Ersue <mersue@gmail.com>; wrote:
> Reviewer: Mehmet Ersue
> Review result: Has Nits
> 
> I have reviewed this document as part of the Operational directorate's ongoing
> effort to review all IETF documents being processed by the IESG.  These
> comments were written with the intent of improving the operational aspects of
> the IETF drafts. Comments that are not addressed in last call may be included
> in AD reviews during the IESG review.  Document editors and WG chairs should
> treat these comments just like any other last call comments.
> 
> Intended status: Standards Track
> Current IESG state: Waiting for Writeup
> IANA review state: Not OK / Expert review needed (see
> https://datatracker.ietf.org/doc/draft-ietf-netmod-schema-mount/history/)
> 
> Summary:
> The document defines a mechanism to add the schema trees defined by a set of
> YANG modules onto a mount point defined in the schema tree in some YANG modules.
> 
> I think the document is well-written and can be published after addressing last
> issues indicated by different reviews.
> 
> A few nits below:
> 
> - In 2.  Terminology and Notation
> for both "system-controlled interface" and "YANG library checksum":
> s/are not/is not/

Fixed, thanks.

> - In 2.1.  Glossary of New Terms
> As there are indeed terms which are not new I would suggest to change the
> section title to: "Glossary of Used Terms". One can even merge section 2 and
> section 2.1.

Ok.  I suggest we remove 2.1 and instead add:

   The following additional terms are used within this document:


> - As one of the commenters indicated, the words "schema mount" are often used
> casually and without an article. Though what the author means is "the schema
> mount mechanism" which is specifically defined in this document.

In the Introduction, the document says:

  This document introduces a new mechanism, denoted as schema
  mount, that allows for mounting one data model [...]

so I wonder if the solution to both these problem is to define "schema
mount" as a term in 2.1, instead of replacing "schema mount" with "the
schema mount mechanism" in the whole document?


/martin