Re: [netmod] YANG doctor review of draft-ietf-netmod-intf-ext-yang-04
Robert Wilton <rwilton@cisco.com> Wed, 05 July 2017 10:30 UTC
Return-Path: <rwilton@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D34B131C6C; Wed, 5 Jul 2017 03:30:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fEA2vs2s7UoX; Wed, 5 Jul 2017 03:30:40 -0700 (PDT)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 934B2131C73; Wed, 5 Jul 2017 03:30:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=8077; q=dns/txt; s=iport; t=1499250639; x=1500460239; h=subject:to:references:from:message-id:date:mime-version: in-reply-to; bh=J8w5GAOyKZoeaxZaXJggf16kA3GfeVIK+4YE7cjofz8=; b=KSBcZ7B0YHpIOXWhMlMKydQ68Nx59NH9RMlo0RcLLCAq/UZeJ5Mq7HB0 EJ+/0+bz0ngqq0PTjXLEsd27PbrlNLZFs1r0OEsdpUyMuHOMZDpO+GEf6 erfLJGTsfQuGJsbIMwd9c5SjltlrGMOmtzkUByLaRjkU7oXwfh6wTfyoo w=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DuAADRvlxZ/xbLJq1TCRoBAQEBAgEBAQEIAQEBAYMsgRCBEI4Jc5BZIpBUhSyCESEBCoUhTwKDTxgBAgEBAQEBAQFrKIUZAQEBAwEBbBsLGC4nMAYBDAYCAQEVihYQr2IpixUBAQEBAQEBAQEBAQEBAQEBAQEBAQEYBYMng0yBYSsLgm6EQ4V8HwWfBpQFiySGeoxhiFIfOIEKMSEIGxVJhxY/NohpAQEB
X-IronPort-AV: E=Sophos;i="5.40,311,1496102400"; d="scan'208,217";a="655882416"
Received: from aer-iport-nat.cisco.com (HELO aer-core-1.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2017 10:30:35 +0000
Received: from [10.63.23.55] (dhcp-ensft1-uk-vla370-10-63-23-55.cisco.com [10.63.23.55]) by aer-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id v65AUYde009989; Wed, 5 Jul 2017 10:30:34 GMT
To: Andy Bierman <andy@yumaworks.com>, "netmod@ietf.org" <netmod@ietf.org>, YANG Doctors <yang-doctors@ietf.org>
References: <CABCOCHTtihJuFauSW4KmaoCHJSFYgNCR200MWsLQ_7456HsO0w@mail.gmail.com>
From: Robert Wilton <rwilton@cisco.com>
Message-ID: <c8921b96-7907-75fa-820c-8eca9d08d218@cisco.com>
Date: Wed, 05 Jul 2017 11:30:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CABCOCHTtihJuFauSW4KmaoCHJSFYgNCR200MWsLQ_7456HsO0w@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------47F09D9D3B17A8B7DE1A7217"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/LUOKOEzUx168s5rwpq5NfpTIKmY>
Subject: Re: [netmod] YANG doctor review of draft-ietf-netmod-intf-ext-yang-04
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jul 2017 10:30:42 -0000
Hi Andy, Thanks for this review, and sorry for the very slow reply. I believe that I have addressed most of your comments in the updated draft-ietf-netmod-intf-ext-yang-05 version. The only comment that I have not directly addressed relates to "identity ethSubInterface", and this is because I believe that may be a better way of solving this by defining generic interface property identities that are then inherited by the interface types identities defined in iana-if-types.yang. I've written up how this approach could work in draft-wilton-netmod-interface-properties-00. As always, comments welcome. Thanks, Rob On 06/04/2017 18:43, Andy Bierman wrote: > > Overall: > > The document is well-written and almost ready for publication > > Comments: > > 1) No examples or guidance for "encaps-type" > > The document does not really define the standards value > for this empty choice. There are no examples showing its use. > More work is needed for this part of the module. > > The following TODO needs to be resolved and the note removed > from the document: > > /* > * TODO - Should we introduce an abstract type to make this > * extensible to new interface types, or vendor > * specific interface types? > */ > > 2) normative overlap > > The text and layout of sec. 3 is good. > The issue is that the YANG module text copies from this section > in some places (leafs) and references it in others (feature definitions) > > Some parts like "half-life" are more detailed in the leaf definition > than the plain text in sec. 3 > > Perhaps the leaf definitions can have reference-stmts added > as needed, so it is clear that the YANG leaf is not the > entire normative text. The YANG descriptions are good, > but maybe not complete wrt/ sec. 3 additional text. > > > sec 3.7 typo: > > the existing the sub-interface > ^^^ remove extra 'the' > > 3) identity ethSubInterface > > This identity is used in the encapsulation container when-stmt. > It is not clear if this is intended as a base identity (like identity > sub-interface) > An example for the encapsulation container would help clarify the > expected usage > > This also has 2 bases (sub-interface and l2vlan). > Some explanation in the identity-stmt would be helpful > (since this is a new YANG 1.1 construct) > > > > Andy > > > > _______________________________________________ > netmod mailing list > netmod@ietf.org > https://www.ietf.org/mailman/listinfo/netmod
- Re: [netmod] YANG doctor review of draft-ietf-net… Vladimir Vassilev
- Re: [netmod] YANG doctor review of draft-ietf-net… Robert Wilton
- Re: [netmod] YANG doctor review of draft-ietf-net… Martin Bjorklund
- Re: [netmod] YANG doctor review of draft-ietf-net… Ladislav Lhotka
- Re: [netmod] YANG doctor review of draft-ietf-net… Martin Bjorklund
- Re: [netmod] YANG doctor review of draft-ietf-net… Ladislav Lhotka
- [netmod] YANG doctor review of draft-ietf-netmod-… Andy Bierman
- Re: [netmod] YANG doctor review of draft-ietf-net… Robert Wilton