Re: [netmod] I-D Action: draft-ietf-netmod-syslog-model-10.txt
"Clyde Wildes (cwildes)" <cwildes@cisco.com> Thu, 03 November 2016 20:55 UTC
Return-Path: <cwildes@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5489112989C for <netmod@ietfa.amsl.com>; Thu, 3 Nov 2016 13:55:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -16.018
X-Spam-Level:
X-Spam-Status: No, score=-16.018 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.497, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IwSuS2ncwp3q for <netmod@ietfa.amsl.com>; Thu, 3 Nov 2016 13:55:54 -0700 (PDT)
Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 37F07129887 for <netmod@ietf.org>; Thu, 3 Nov 2016 13:55:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=6640; q=dns/txt; s=iport; t=1478206554; x=1479416154; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=1jEq6GHdj3rYhtT7ZpJdSFXtWkkE/ALtwRUpwVxk/lI=; b=WZ/fjeZaDg/Abrs8LEdQKR7P9uAw38FHe2QE9bH5TAuwnR6MekENmFX0 wzrnuq5N8gm8tpviMCVR7BeO0ahP5eT32GJcb6YHekjZa90ELy3hpQ3ae Kygn1m/qVNcXRRXnU9OKx1xmcpjVeom0woLX5v1LSx5llwLpbXC6XiAzL M=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CNBQAToxtY/4oNJK1dGgEBAQECAQEBAQgBAQEBgzABAQEBAR9YfAcBpC+UR4IIHQuFMEoCGoFqQRIBAgEBAQEBAQFiKIRiAQEDAQEBASAROhsCAQgaAiYCAgIlCxUQAgQBEohOCA6vII0IAQEBAQEBAQEBAQEBAQEBAQEBAQEBFwWBCYU2gX0IglCER4MELYIvBY5Ri08BkDyQCpEgASUFK2uFH3KGbgGBCwEBAQ
X-IronPort-AV: E=Sophos;i="5.31,440,1473120000"; d="scan'208";a="342454293"
Received: from alln-core-5.cisco.com ([173.36.13.138]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 Nov 2016 20:55:53 +0000
Received: from xch-rcd-011.cisco.com (xch-rcd-011.cisco.com [173.37.102.21]) by alln-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id uA3Ktr54027091 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 3 Nov 2016 20:55:53 GMT
Received: from xch-aln-015.cisco.com (173.36.7.25) by XCH-RCD-011.cisco.com (173.37.102.21) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 3 Nov 2016 15:55:52 -0500
Received: from xch-aln-015.cisco.com ([173.36.7.25]) by XCH-ALN-015.cisco.com ([173.36.7.25]) with mapi id 15.00.1210.000; Thu, 3 Nov 2016 15:55:52 -0500
From: "Clyde Wildes (cwildes)" <cwildes@cisco.com>
To: Phil Shafer <phil@juniper.net>, "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] I-D Action: draft-ietf-netmod-syslog-model-10.txt
Thread-Index: AQHSM7RZCxGcQy3BvEiKjl31JnOfYKDDnskAgAQBmYA=
Date: Thu, 03 Nov 2016 20:55:52 +0000
Message-ID: <8A582A29-B955-4036-A02A-02A5C5114CC0@cisco.com>
References: <147794524409.23193.8224652494540792820.idtracker@ietfa.amsl.com> <201611010045.uA10j6vH004555@idle.juniper.net>
In-Reply-To: <201611010045.uA10j6vH004555@idle.juniper.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [128.107.151.23]
Content-Type: text/plain; charset="utf-8"
Content-ID: <EE5D691BE2396643BE84042A1F5A291B@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/WXslcHT7Bn-PzdB2LG6EpatYazE>
Subject: Re: [netmod] I-D Action: draft-ietf-netmod-syslog-model-10.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Nov 2016 20:55:56 -0000
Hi Phil, Thanks for your review. My comments inline as [clyde]. On 10/31/16, 5:45 PM, "netmod on behalf of Phil Shafer" <netmod-bounces@ietf.org on behalf of phil@juniper.net> wrote: > Title : A YANG Data Model for Syslog Configuration I've a few questions: - The description says that the "facility/no-facility" case/leaf is used "to effectively disable a particular log-action". Why not make an explicit "disable" leaf instead? Using no-facilities like this is confusing. - Why use an explicit/mandatory selector node instead of making this implicit, with the lack of a selector meaning match all? - compare-op: we've always tried to use full words; would this be better as "compare-operation" or just "compare"? - equals-or-higher: you might want to explain that this is the default even in the absence of the "select-sev-compare" feature. (I'm assuming this is true.) - You use "facility" as both a case and a list under selector-facility. This seems confusing and misleading. [clyde] There have been numerous iterations of the filter specification to make it clearer, to simplify, and to include the requirements put forward by the vendors that we have worked with. I welcome your input to make it even better. We have reached agreement on the intent of the filter specification. Here it is in words: A selector consists of two parts: one or more facility-severity matches, and if supported via the select-match feature, an optional regular expression pattern match that is performed on the SYSLOG-MSG field. The facility is one of a specific syslogtypes:syslog-facility, none, or all facilities. None is a special case that can be used to turn off an action. The severity is one of syslogtypes:severity, all severities, or none. None is a special case that can be used to turn off a facility. When filtering severity, the default comparison is that all messages of the specified severity and higher are logged. This is shown in the model as “default equals-or-higher”. This behavior can be altered if the select-sev-compare feature is enabled to specify: “equals” to specify only this single severity; “not-equals” to ignore that severity; “equals-or-higher” to specify all messages of the specified severity and higher. [clyde] I agree that “compare-op” can be simplified to “compare”. - "structured-data": says "describes how log messages are written to the log file" but it applies to more than log files. [clyde] I will reword this to “This leaf describes how log messages are written.” - Consider making "syslog-sign" into "signing-options" or something similar, to be more clear. The "syslog-" prefix is not needed, since the reader knows we are talking about syslog, and the "sign" is not clear. Then you can remove the "sig-" prefix on the child nodes. [clyde] I will change “syslog-sign” leaf to “signing-options” if no one objects, and remove the “sig-“ prefix. - The "session" name is not clear, since there are many sort of sessions; would "local-users" be better? [clyde] An earlier version of the model supported a “user” action. Alcatel/Lucent requested that we rename the user action into a session action that could be augmented if needed to handle more than user sessions. - What purpose for the "actions" container serve? Can it be removed? [clyde] “actions” serve a purpose should a vendor wish to extend the model to support operational data ie “show log” or an RPC such as “clear log”. - "buffer" should be a feature, since many platforms do not implement it. [clyde] I will make “buffer” a feature since it is only implemented by Cisco and Alcatel/Lucent. - How does an implementation specify the set of valid characters usable for user names? [clyde] Would a pattern statement like ‘pattern "[0-9a-fA-F]*";’ solve this issue? - Many networking devices have special tags at the front of their messages, indicating the specific message. For example "%ASA-1-104001" in IOS, or "BGP_CEASE_PREFIX_LIMIT_EXCEEDED" in JUNOS. We carry these are specific SD-PARAMS when SD is used. Is there a way to filter using theses tags, or more generic SD-PARAMS? [clyde] We added the ability to filter anything in the SYSLOG-MSG field including structured data using a regular expression with the pattern-match leaf. That should cover this. Thanks, Clyde Thanks, Phil _______________________________________________ netmod mailing list netmod@ietf.org https://www.ietf.org/mailman/listinfo/netmod
- [netmod] I-D Action: draft-ietf-netmod-syslog-mod… internet-drafts
- Re: [netmod] I-D Action: draft-ietf-netmod-syslog… Phil Shafer
- Re: [netmod] I-D Action: draft-ietf-netmod-syslog… Clyde Wildes (cwildes)