Re: [OAUTH-WG] Google's OAuth endpoints now fully support PKCE (RFC7636)

William Denniss <wdenniss@google.com> Tue, 19 January 2016 17:08 UTC

Return-Path: <wdenniss@google.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 01BCC1B32B4 for <oauth@ietfa.amsl.com>; Tue, 19 Jan 2016 09:08:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.379
X-Spam-Level:
X-Spam-Status: No, score=-1.379 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MUeaXArDvUye for <oauth@ietfa.amsl.com>; Tue, 19 Jan 2016 09:08:47 -0800 (PST)
Received: from mail-oi0-x22c.google.com (mail-oi0-x22c.google.com [IPv6:2607:f8b0:4003:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 584FB1B32B0 for <oauth@ietf.org>; Tue, 19 Jan 2016 09:08:47 -0800 (PST)
Received: by mail-oi0-x22c.google.com with SMTP id o124so188224961oia.3 for <oauth@ietf.org>; Tue, 19 Jan 2016 09:08:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=nmLtHq4gPsOYvAZ9/bNOX7Qhi1WdXh4IJpWfXMSvu04=; b=N4ax7woSjlF+GJp3sFstxBQ4zb05QUjQJNm8ay5kFwQhdTQzec2GcCJxsoWGnM9z1t d5lo9buQO5pYiz1aAn6IHoMkwB1ztTLoFPgRjmzfgpvtGRk99g5jsckwU1pVq4xK2qeG 3t7xCTeW1oP/12R+LdkibZ4OBLKwgfMiLr1tl01V3x1/Ccl9k37zTiI0VDwQTIaqhpMv rZs7XlqoGFRZEJcLKnLIMY9BSqIJ1Tj4b/8H5B6bfQJSdJxDypkAhzMpntS5cW3Fn8BJ a1DlnsFZO2xYNh7r2xcp+xixMsa8BayZoB08RAOa45yvOxmBX0kq37ZYdElL03SVAJIT K2ww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=nmLtHq4gPsOYvAZ9/bNOX7Qhi1WdXh4IJpWfXMSvu04=; b=aO0JgISgKWDbaXvX16eD6WDrU4nVuZUkDsdkc2wOwug2TCvgInQp3lpYpZU3a0x8ri 68KkCdRHN2MEJ/ja+yGSMfVX1CyScF145pthuNDm7nk96OlfEF1/ws2ZXAGVxX89pU1i VlPlB8r9i2dAA93MczHYCKhJnaYR0MrHx9udSeZTJECCc6PgQ+FDXn3owyIJhZdP1fSB Z6tE5B4zB29OSHNI5wbWNKsNK1YvfCj1TkKawVPM5fn4Y0S1F/FX0PQJtWiJ6eYSt42s uW0p1jxRF3Lh751Kb2jBXxUAgdCLYmmDDU600PZW42gML8OBPLQwV5lNmwGquoLxkxiK EFRg==
X-Gm-Message-State: ALoCoQkS6f47sCbyJfao405MfXGbv74bPOXbSMBt5N3+IhiJ9ySDVM55ndvnLQcpAyhK6dnF3l+UhLOpj8f84gjGyzZwhqvtW8oXS3KCs2rSHrC2EcI3JRA=
X-Received: by 10.202.48.6 with SMTP id w6mr23418431oiw.97.1453223326606; Tue, 19 Jan 2016 09:08:46 -0800 (PST)
MIME-Version: 1.0
Received: by 10.182.227.39 with HTTP; Tue, 19 Jan 2016 09:08:26 -0800 (PST)
In-Reply-To: <8E6EBF44-2057-4429-8347-1BA447C3F3DB@ve7jtb.com>
References: <CAAP42hD3vpwnBYzu6YZVXtTimVuFHzgQ9Pksn1RQNEwogPZRJw@mail.gmail.com> <8E6EBF44-2057-4429-8347-1BA447C3F3DB@ve7jtb.com>
From: William Denniss <wdenniss@google.com>
Date: Tue, 19 Jan 2016 09:08:26 -0800
Message-ID: <CAAP42hBePMmP1HttrS6kx6F1oiqm_6OMypatOtGNht4aavbYow@mail.gmail.com>
To: John Bradley <ve7jtb@ve7jtb.com>
Content-Type: multipart/alternative; boundary=001a113cd98629ad9a0529b2ecc2
Archived-At: <http://mailarchive.ietf.org/arch/msg/oauth/sysECXB2Fj2K8yZDS3e4jokbwNQ>
Cc: "oauth@ietf.org" <oauth@ietf.org>
Subject: Re: [OAUTH-WG] Google's OAuth endpoints now fully support PKCE (RFC7636)
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jan 2016 17:08:49 -0000

On Tue, Jan 19, 2016 at 4:32 AM, John Bradley <ve7jtb@ve7jtb.com>; wrote:

> Great news.
>
> If you have sent a PKCE challenge and no verifier that should be a
> authentication failure as if the value were wrong.
>

I agree that case would always error.

This is the opposite case, where there was no challenge on the
authorization request, but there was the verifier on the token request.



> I don’t know if it needs a special error.
>
> Thanks for bringing it up.
>
> John B.
>
> On Jan 19, 2016, at 2:46 AM, William Denniss <wdenniss@google.com>; wrote:
>
> This month we rolled out full PKCE (RFC7636) support on our OAuth
> endpoints.
>
> We'd previously implemented an earlier draft but were not conformant to
> the final spec when it was published – now we are. Both "plain" and "S256"
> transforms are supported. As always, get the latest endpoints from our
> discovery document:
> https://accounts.google.com/.well-known/openid-configuration
>
> If you give it a spin, let me know how you go! The team monitors the Stack
> Overflow google-oauth
> <http://stackoverflow.com/questions/tagged/google-oauth> tag too, for any
> implementation questions.
>
> I'm keen to know what we should be putting in our discovery doc to declare
> PKCE support (see the thread "Advertise PKCE support in OAuth 2.0
> Discovery"), hope we can agree on that soon.
>
> One implementation detail not covered in the spec: we error if you
> send code_verifier to the token endpoint when exchanging a code that was
> issued without a code_challenge being present. The assumption being that if
> you are sending code_verifier on the token exchange, you are using PKCE and
> should have sent code_challenge on the authorization request, so something
> is amiss.
>
> William
>
>
>
>
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth
>
>
>