[OPS-DIR]draft-ietf-netconf-notif-envelope-03 early Opsdir review

Joe Clarke via Datatracker <noreply@ietf.org> Wed, 22 October 2025 14:12 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: ops-dir@ietf.org
Delivered-To: ops-dir@mail2.ietf.org
Received: from [10.244.8.84] (unknown [4.156.85.76]) by mail2.ietf.org (Postfix) with ESMTP id 7889D7A593D1; Wed, 22 Oct 2025 07:12:53 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joe Clarke via Datatracker <noreply@ietf.org>
To: ops-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.51.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <176114237340.1133.4616423096347649354@dt-datatracker-675c8fd764-bsflw>
Date: Wed, 22 Oct 2025 07:12:53 -0700
Message-ID-Hash: HZQFURORIYLOM3OC4TGIIUXXYRZCS4UL
X-Message-ID-Hash: HZQFURORIYLOM3OC4TGIIUXXYRZCS4UL
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-ops-dir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-netconf-notif-envelope.all@ietf.org, netconf@ietf.org
X-Mailman-Version: 3.3.9rc6
Reply-To: Joe Clarke <jclarke@cisco.com>
Subject: [OPS-DIR]draft-ietf-netconf-notif-envelope-03 early Opsdir review
List-Id: Ops Directorate <ops-dir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/ops-dir/LlNOz1aPpnxr6pHg54AkKCIvMPI>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ops-dir>
List-Help: <mailto:ops-dir-request@ietf.org?subject=help>
List-Owner: <mailto:ops-dir-owner@ietf.org>
List-Post: <mailto:ops-dir@ietf.org>
List-Subscribe: <mailto:ops-dir-join@ietf.org>
List-Unsubscribe: <mailto:ops-dir-leave@ietf.org>

Document: draft-ietf-netconf-notif-envelope
Title: Extensible YANG Model for YANG-Push Notifications
Reviewer: Joe Clarke
Review result: Has Issues

I have been asked to review this document on behalf of the OPS directorate. 
This document specifies a new envelope header for YANG notifications that can
be extended with richer metadata beyond eventTime and used in other encodings. 
The document is well-written and easy to follow.  As such, I found it easy to
spot what I feel are two points to discuss.  I hesitated to mark this "has
issues".  I really wanted a DISCUSS-like option just so I could get some
authors' and WG members thoughts.

1. I appreciate your Operational Considerations concerning a mix of "new" and
"old" collectors.  However, since the knob to control this new envelope is
network element-wide, I feel something should be said in this section that
separating collectors MUST be done at a network element level.  But that begs
the question, why?  Why can't this be controlled at a subscription level?  I'm
sure it was considered, but I don't recall seeing text that explained why this
was a sub-optimal choice.

2. MINOR: As it stands, it makes sense that all subscriptions would be
terminated when toggling `enable-notification-envelope`, but would it possibly
less astonishing to operators that toggle this if implementors force all
subscriptions to already be terminated for the config to be accepted?  Baring
that, I would strongly recommend you add the text about subscriptions being
terminated to the description of this boolean in the YANG module.  And also,
see #1 as to why this can't be done more gracefully at a per-subscription or
per client level.

Finally, one nit:

Section 1.1: s/messsage/message/